From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 295E4C43603 for ; Tue, 10 Dec 2019 19:51:25 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EB24E2077B for ; Tue, 10 Dec 2019 19:51:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="em/zZov7" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EB24E2077B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=NawunuYEjOGBmFXm7GYuPMVXBrNBdnYgevO0xLruSyQ=; b=em/zZov74Vs59Z 5XaWa0AocBkBD8FfHaqBCEzFYuayB6wOhE5Vx0zrKg6jNyJ0pLgU6SIssfs7MWrD6mJmlNCZhEeCi iWoDdACzpNJLz8OadkYoddsj5pF9lByB5MEpzlyS1Ik2afg5SYo9qwu80LVK1UhdMJaGI5mQE2tEj EocdFD84dpvg2PnwH/NX1eIF80hluyev3GfQvOOi4vyo4D6n9Gjsq5Bq/le0/JCjzqnQbMDCAQJqN uVRDsXVxovZwSHhfcjbtJaFTqBexSPDj+wh/kUUQseUXz49LN4g0wr1HzNwvnH+lOPNNr8bZsNHOD xUWG4cSASLSbYefdxPXw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1ielXR-0005fF-K0; Tue, 10 Dec 2019 19:51:17 +0000 Received: from 179-240-167-103.3g.claro.net.br ([179.240.167.103] helo=quaco.ghostprotocols.net) by bombadil.infradead.org with esmtpsa (Exim 4.92.3 #3 (Red Hat Linux)) id 1ielXP-0005eg-RA; Tue, 10 Dec 2019 19:51:16 +0000 Received: by quaco.ghostprotocols.net (Postfix, from userid 1000) id DF0AC40352; Tue, 10 Dec 2019 16:51:13 -0300 (-03) Date: Tue, 10 Dec 2019 16:51:13 -0300 From: Arnaldo Carvalho de Melo To: John Garry Subject: Re: perf top for arm64? Message-ID: <20191210195113.GD13965@kernel.org> References: <1573045254-39833-1-git-send-email-john.garry@huawei.com> <20191106140036.GA6259@kernel.org> <418023e7-a50d-cb6f-989f-2e6d114ce5d8@huawei.com> <20191210163655.GG14123@krava> <952dc484-2739-ee65-f41c-f0198850ab10@huawei.com> <20191210170841.GA23357@krava> <9a31536b-f266-e305-1107-2f745d0a33e3@huawei.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <9a31536b-f266-e305-1107-2f745d0a33e3@huawei.com> X-Url: http://acmel.wordpress.com X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, peterz@infradead.org, will@kernel.org, Linuxarm , Arnaldo Carvalho de Melo , linux-kernel@vger.kernel.org, "linux-perf-users@vger.kernel.org" , alexander.shishkin@linux.intel.com, mingo@redhat.com, namhyung@kernel.org, Jiri Olsa , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Em Tue, Dec 10, 2019 at 05:17:56PM +0000, John Garry escreveu: > On 10/12/2019 17:08, Jiri Olsa wrote: > > On Tue, Dec 10, 2019 at 04:52:52PM +0000, John Garry wrote: > > > On 10/12/2019 16:36, Jiri Olsa wrote: > > > > On Tue, Dec 10, 2019 at 04:13:49PM +0000, John Garry wrote: > > > > > Hi all, > > > > > > > > > > I find to my surprise that "perf top" does not work for arm64: > > > > > > > > > > root@ubuntu:/home/john/linux# tools/perf/perf top > > > > > Couldn't read the cpuid for this machine: No such file or directory > > > > > > > > > > Hi Jirka, > > > > > > > there was recent change that check on cpuid and quits: > > > > 608127f73779 perf top: Initialize perf_env->cpuid, needed by the per arch annotation init routine > > > > > > > > > > ok, this is new code. I obviously didn't check the git history... > > > > > > But, apart from this, there are many other places where get_cpuid() is > > > called. I wonder what else we're missing out on, and whether we should still > > > add it. > > > > right, I was just wondering how come vendor events are working for you, > > but realized we have get_cpuid_str being called in there ;-) > > > > I think we should add it as you have it prepared already, > > could you post it with bigger changelog that would explain > > where it's being used for arm? > > ok, I can look to do that. > > But, as you know, we still need to fix perf top for other architectures > affected. Right, I need to make that just a pr_debug() message and then check in the annotation code when that is needed to see if it is set, if not, then show a popup error message and refuse to do whatever annotation feature requires that. Anyway, your patch should make sense and provide info that the ARM64 annotation may use now or in the future. - Arnaldo _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel