From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNWANTED_LANGUAGE_BODY,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 01563C2D0C6 for ; Wed, 11 Dec 2019 12:28:49 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CC3EC20836 for ; Wed, 11 Dec 2019 12:28:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="BkBF2PER"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="pDSVd7nL" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CC3EC20836 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=free-electrons.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=0HGF7NN0SnHXpDR082C038yaUe5LTTtzhmq/8aj+R28=; b=BkBF2PER8MAWVW mJO+G/Y36ihcRboY4Jpnr2qYDCmLYEw1OQdb8HTByUpphIOJ74PEkT1jgEzMH7LTBFi/1owh3l2T1 aYllVW/EnwnE0fpk0wRpcmh68lJtmej0fn5DbXyOc57a2yCmTuivTnxYJfj9D4AJ9to7UQ4oQ2FsE 8vtB6qfqyPGJZEyFco0ZnSKQyzORD/3UG4Fyv/vF40nuKOH7cIZIvYwVjAAc6Vx0se5R78T/X18dE 0G+j+xfNtUA5x5ZME7JaeWsR/Jl+tIdWXX/hH5MCtBOYklulIlZ+9SLCrjNKFCat2PUnP0nysY1Zi HZZVdV2cwqL7lH/JfHMw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1if16e-0008DX-OA; Wed, 11 Dec 2019 12:28:40 +0000 Received: from merlin.infradead.org ([2001:8b0:10b:1231::1]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1if16d-0008DH-Dl; Wed, 11 Dec 2019 12:28:39 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=merlin.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=EBCUa+Pcb8uKUJ7Yz4ydf8QJdT/W7rXSHJV5ZRXv2po=; b=pDSVd7nLlLkscRPC7CU0NgsBS 18pvpl/j3Auv2y5lv4gaw4h8xg/nmuU1IVLqr43NhWPjpajpFTKdeIDRbLW3d1whKGAjrhwfGMkFN JL4nH1+V3ZT4ESrSdz+4ArBwixANR8p+4eptro+dwqnvvpfr2JMG25RZo1zuSYJ5/m1CieoEW88nx 4Ufacq4YTU5GsFGpuxsj48jn5Ad9QedHv6ubhd4il92Pis94/h2LNdbiqcY1P5oJSlzCkEHxT5zrj EE3u0vdqzkpL5ZPKYNglLvqk1JIbRJcFNIdfSh72BtvQ3Kw75si57axpUP9uK9Arl9mJSs2fzslYN 6b6vwEiaQ==; Received: from relay11.mail.gandi.net ([217.70.178.231]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1if16Y-0003q3-Mo; Wed, 11 Dec 2019 12:28:37 +0000 Received: from localhost (136.112.broadband15.iol.cz [90.182.112.136]) (Authenticated sender: alexandre.belloni@bootlin.com) by relay11.mail.gandi.net (Postfix) with ESMTPSA id 04970100004; Wed, 11 Dec 2019 12:28:01 +0000 (UTC) Date: Wed, 11 Dec 2019 13:27:57 +0100 From: Alexandre Belloni To: Hsin-Hsiung Wang Subject: Re: [PATCH v7 6/6] rtc: Add support for the MediaTek MT6358 RTC Message-ID: <20191211122757.GY1463890@piout.net> References: <1576057435-3561-1-git-send-email-hsin-hsiung.wang@mediatek.com> <1576057435-3561-7-git-send-email-hsin-hsiung.wang@mediatek.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1576057435-3561-7-git-send-email-hsin-hsiung.wang@mediatek.com> User-Agent: Mutt/1.12.1 (2019-06-15) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Alessandro Zummo , Josef Friedl , srv_heupstream@mediatek.com, Frank Wunderlich , Ran Bi , Sean Wang , linux-kernel@vger.kernel.org, Tianping Fang , devicetree@vger.kernel.org, Rob Herring , linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Matthias Brugger , Thomas Gleixner , Eddie Huang , Lee Jones , Kate Stewart , linux-rtc@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, Nitpick, the subject should have been: rtc: mt6397: Add support for the MediaTek MT6358 RTC On 11/12/2019 17:43:55+0800, Hsin-Hsiung Wang wrote: > From: Ran Bi > > This add support for the MediaTek MT6358 RTC. Driver using > compatible data to store different RTC_WRTGR address offset. > > Signed-off-by: Ran Bi > Signed-off-by: Hsin-Hsiung Wang > Acked-by: Alexandre Belloni > --- > drivers/rtc/rtc-mt6397.c | 24 ++++++++++++++++-------- > include/linux/mfd/mt6397/rtc.h | 16 +++++++++++++++- > 2 files changed, 31 insertions(+), 9 deletions(-) > > diff --git a/drivers/rtc/rtc-mt6397.c b/drivers/rtc/rtc-mt6397.c > index 9135e21..6ca54f9 100644 > --- a/drivers/rtc/rtc-mt6397.c > +++ b/drivers/rtc/rtc-mt6397.c > @@ -15,12 +15,24 @@ > #include > #include > > +static const struct of_device_id mt6397_rtc_of_match[] = { > + { .compatible = "mediatek,mt6323-rtc", > + .data = (void *)&mt6397_rtc_data, }, > + { .compatible = "mediatek,mt6358-rtc", > + .data = (void *)&mt6358_rtc_data, }, > + { .compatible = "mediatek,mt6397-rtc", > + .data = (void *)&mt6397_rtc_data, }, > + {} > +}; > +MODULE_DEVICE_TABLE(of, mt6397_rtc_of_match); > + > static int mtk_rtc_write_trigger(struct mt6397_rtc *rtc) > { > int ret; > u32 data; > > - ret = regmap_write(rtc->regmap, rtc->addr_base + RTC_WRTGR, 1); > + ret = regmap_write(rtc->regmap, > + rtc->addr_base + rtc->data->wrtgr, 1); > if (ret < 0) > return ret; > > @@ -269,6 +281,9 @@ static int mtk_rtc_probe(struct platform_device *pdev) > res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > rtc->addr_base = res->start; > > + rtc->data = (struct mtk_rtc_data *) > + of_device_get_match_data(&pdev->dev); > + > rtc->irq = platform_get_irq(pdev, 0); > if (rtc->irq < 0) > return rtc->irq; > @@ -333,13 +348,6 @@ static int mt6397_rtc_resume(struct device *dev) > static SIMPLE_DEV_PM_OPS(mt6397_pm_ops, mt6397_rtc_suspend, > mt6397_rtc_resume); > > -static const struct of_device_id mt6397_rtc_of_match[] = { > - { .compatible = "mediatek,mt6323-rtc", }, > - { .compatible = "mediatek,mt6397-rtc", }, > - { } > -}; > -MODULE_DEVICE_TABLE(of, mt6397_rtc_of_match); > - > static struct platform_driver mtk_rtc_driver = { > .driver = { > .name = "mt6397-rtc", > diff --git a/include/linux/mfd/mt6397/rtc.h b/include/linux/mfd/mt6397/rtc.h > index 7dfb63b..8810e6f 100644 > --- a/include/linux/mfd/mt6397/rtc.h > +++ b/include/linux/mfd/mt6397/rtc.h > @@ -18,7 +18,8 @@ > #define RTC_BBPU_CBUSY BIT(6) > #define RTC_BBPU_KEY (0x43 << 8) > > -#define RTC_WRTGR 0x003c > +#define RTC_WRTGR_MT6358 0x3a > +#define RTC_WRTGR_MT6397 0x3c > > #define RTC_IRQ_STA 0x0002 > #define RTC_IRQ_STA_AL BIT(0) > @@ -65,6 +66,10 @@ > #define MTK_RTC_POLL_DELAY_US 10 > #define MTK_RTC_POLL_TIMEOUT (jiffies_to_usecs(HZ)) > > +struct mtk_rtc_data { > + u32 wrtgr; > +}; > + > struct mt6397_rtc { > struct device *dev; > struct rtc_device *rtc_dev; > @@ -74,6 +79,15 @@ struct mt6397_rtc { > struct regmap *regmap; > int irq; > u32 addr_base; > + const struct mtk_rtc_data *data; > +}; > + > +static const struct mtk_rtc_data mt6358_rtc_data = { > + .wrtgr = RTC_WRTGR_MT6358, > +}; > + > +static const struct mtk_rtc_data mt6397_rtc_data = { > + .wrtgr = RTC_WRTGR_MT6397, > }; > > #endif /* _LINUX_MFD_MT6397_RTC_H_ */ > -- > 2.6.4 -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel