* [PATCH] ARM: exynos_defconfig: Bring back explicitly wanted options @ 2019-12-05 20:00 ` Krzysztof Kozlowski 2019-12-06 8:01 ` Marek Szyprowski 0 siblings, 1 reply; 3+ messages in thread From: Krzysztof Kozlowski @ 2019-12-05 20:00 UTC (permalink / raw) To: Kukjin Kim, Krzysztof Kozlowski, Marek Szyprowski, Sylwester Nawrocki, Lukasz Luba, linux-arm-kernel, linux-samsung-soc, linux-kernel Few options KALLSYMS_ALL, SCSI, PM_DEVFREQ and mutex/spinlock debugging were removed with savedefconfig because they were selected by other options. However these are user-visible options and they might not be selected in the future. Exactly this happened with commit 0e4a459f56c3 ("tracing: Remove unnecessary DEBUG_FS dependency") removing the dependency between DEBUG_FS and TRACING. To avoid losing these options in the future, explicitly mention them in defconfig. Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> --- arch/arm/configs/exynos_defconfig | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/arch/arm/configs/exynos_defconfig b/arch/arm/configs/exynos_defconfig index e7e4bb5ad8d5..026407101cf2 100644 --- a/arch/arm/configs/exynos_defconfig +++ b/arch/arm/configs/exynos_defconfig @@ -38,6 +38,7 @@ CONFIG_CRYPTO_SHA256_ARM=m CONFIG_CRYPTO_SHA512_ARM=m CONFIG_CRYPTO_AES_ARM_BS=m CONFIG_CRYPTO_CHACHA20_NEON=m +CONFIG_KALLSYMS_ALL=y CONFIG_MODULES=y CONFIG_MODULE_UNLOAD=y CONFIG_PARTITION_ADVANCED=y @@ -92,6 +93,7 @@ CONFIG_BLK_DEV_LOOP=y CONFIG_BLK_DEV_CRYPTOLOOP=y CONFIG_BLK_DEV_RAM=y CONFIG_BLK_DEV_RAM_SIZE=8192 +CONFIG_SCSI=y CONFIG_BLK_DEV_SD=y CONFIG_CHR_DEV_SG=y CONFIG_ATA=y @@ -291,6 +293,7 @@ CONFIG_CROS_EC_SPI=y CONFIG_COMMON_CLK_MAX77686=y CONFIG_COMMON_CLK_S2MPS11=y CONFIG_EXYNOS_IOMMU=y +CONFIG_PM_DEVFREQ=y CONFIG_DEVFREQ_GOV_PERFORMANCE=y CONFIG_DEVFREQ_GOV_POWERSAVE=y CONFIG_DEVFREQ_GOV_USERSPACE=y @@ -355,4 +358,7 @@ CONFIG_SOFTLOCKUP_DETECTOR=y # CONFIG_DETECT_HUNG_TASK is not set CONFIG_PROVE_LOCKING=y CONFIG_DEBUG_ATOMIC_SLEEP=y +CONFIG_DEBUG_RT_MUTEXES=y +CONFIG_DEBUG_SPINLOCK=y +CONFIG_DEBUG_MUTEXES=y CONFIG_DEBUG_USER=y -- 2.17.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ARM: exynos_defconfig: Bring back explicitly wanted options 2019-12-05 20:00 ` [PATCH] ARM: exynos_defconfig: Bring back explicitly wanted options Krzysztof Kozlowski @ 2019-12-06 8:01 ` Marek Szyprowski 2019-12-11 18:09 ` Krzysztof Kozlowski 0 siblings, 1 reply; 3+ messages in thread From: Marek Szyprowski @ 2019-12-06 8:01 UTC (permalink / raw) To: Krzysztof Kozlowski, Kukjin Kim, Sylwester Nawrocki, Lukasz Luba, linux-arm-kernel, linux-samsung-soc, linux-kernel Hi Krzyszotof, On 05.12.2019 21:00, Krzysztof Kozlowski wrote: > Few options KALLSYMS_ALL, SCSI, PM_DEVFREQ and mutex/spinlock debugging > were removed with savedefconfig because they were selected by other > options. However these are user-visible options and they might not be > selected in the future. Exactly this happened with commit 0e4a459f56c3 > ("tracing: Remove unnecessary DEBUG_FS dependency") removing the > dependency between DEBUG_FS and TRACING. > > To avoid losing these options in the future, explicitly mention them in > defconfig. > > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> I will not mind adding: Reported-by: Marek Szyprowski <m.szyprowski@samsung.com> as this patch is a direct result of the discussion on my initial patch: https://patchwork.kernel.org/patch/11260361/ and my previous findings. > --- > arch/arm/configs/exynos_defconfig | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/arch/arm/configs/exynos_defconfig b/arch/arm/configs/exynos_defconfig > index e7e4bb5ad8d5..026407101cf2 100644 > --- a/arch/arm/configs/exynos_defconfig > +++ b/arch/arm/configs/exynos_defconfig > @@ -38,6 +38,7 @@ CONFIG_CRYPTO_SHA256_ARM=m > CONFIG_CRYPTO_SHA512_ARM=m > CONFIG_CRYPTO_AES_ARM_BS=m > CONFIG_CRYPTO_CHACHA20_NEON=m > +CONFIG_KALLSYMS_ALL=y > CONFIG_MODULES=y > CONFIG_MODULE_UNLOAD=y > CONFIG_PARTITION_ADVANCED=y > @@ -92,6 +93,7 @@ CONFIG_BLK_DEV_LOOP=y > CONFIG_BLK_DEV_CRYPTOLOOP=y > CONFIG_BLK_DEV_RAM=y > CONFIG_BLK_DEV_RAM_SIZE=8192 > +CONFIG_SCSI=y > CONFIG_BLK_DEV_SD=y > CONFIG_CHR_DEV_SG=y > CONFIG_ATA=y > @@ -291,6 +293,7 @@ CONFIG_CROS_EC_SPI=y > CONFIG_COMMON_CLK_MAX77686=y > CONFIG_COMMON_CLK_S2MPS11=y > CONFIG_EXYNOS_IOMMU=y > +CONFIG_PM_DEVFREQ=y > CONFIG_DEVFREQ_GOV_PERFORMANCE=y > CONFIG_DEVFREQ_GOV_POWERSAVE=y > CONFIG_DEVFREQ_GOV_USERSPACE=y > @@ -355,4 +358,7 @@ CONFIG_SOFTLOCKUP_DETECTOR=y > # CONFIG_DETECT_HUNG_TASK is not set > CONFIG_PROVE_LOCKING=y > CONFIG_DEBUG_ATOMIC_SLEEP=y > +CONFIG_DEBUG_RT_MUTEXES=y > +CONFIG_DEBUG_SPINLOCK=y > +CONFIG_DEBUG_MUTEXES=y > CONFIG_DEBUG_USER=y Best regards -- Marek Szyprowski, PhD Samsung R&D Institute Poland _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ARM: exynos_defconfig: Bring back explicitly wanted options 2019-12-06 8:01 ` Marek Szyprowski @ 2019-12-11 18:09 ` Krzysztof Kozlowski 0 siblings, 0 replies; 3+ messages in thread From: Krzysztof Kozlowski @ 2019-12-11 18:09 UTC (permalink / raw) To: Marek Szyprowski Cc: linux-samsung-soc, linux-kernel, Lukasz Luba, Kukjin Kim, Sylwester Nawrocki, linux-arm-kernel On Fri, Dec 06, 2019 at 09:01:07AM +0100, Marek Szyprowski wrote: > Hi Krzyszotof, > > On 05.12.2019 21:00, Krzysztof Kozlowski wrote: > > Few options KALLSYMS_ALL, SCSI, PM_DEVFREQ and mutex/spinlock debugging > > were removed with savedefconfig because they were selected by other > > options. However these are user-visible options and they might not be > > selected in the future. Exactly this happened with commit 0e4a459f56c3 > > ("tracing: Remove unnecessary DEBUG_FS dependency") removing the > > dependency between DEBUG_FS and TRACING. > > > > To avoid losing these options in the future, explicitly mention them in > > defconfig. > > > > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> > > I will not mind adding: > Applied. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-12-11 18:10 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <CGME20191205200017epcas5p446f5f29988e34d939601287a7517fdfe@epcas5p4.samsung.com>
2019-12-05 20:00 ` [PATCH] ARM: exynos_defconfig: Bring back explicitly wanted options Krzysztof Kozlowski
2019-12-06 8:01 ` Marek Szyprowski
2019-12-11 18:09 ` Krzysztof Kozlowski
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).