From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,FAKE_REPLY_C,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8502C00454 for ; Wed, 11 Dec 2019 22:46:58 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8E0F120836 for ; Wed, 11 Dec 2019 22:46:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="HBepjnsa"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="OnTKLlyW" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8E0F120836 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References: List-Owner; bh=FifYuswYScasL2aCfc1o4nY0MXeXy0RG1rJD4aJoYG0=; b=HBepjnsaxopZ6C qd4xDkn74WuHRFiBCWme5pDs/5DUPnFQBu6LveHLN0U/fGTii6ctLfJXcj7+uM0NnFiO73nMneLHt H6X+dV9fvXnpAmAAvDZ6ORe9OlAOOb+vHas+2RhY8wrUmUg6RC1SBOBt19lONYxaLC/wv/Ad5nMwi NPPsFUs7JqBDKALIBjMB5NtJXjgA1pbOeszE0+owFPsE+YSS4Yj+IBqw3izGAPThKUhkjpTccOSij paChKBKiWI/sfqRdvDch/ONg9gxO/vHb69vioUvyHPmP7N/fWDglJyrQCRipE9PLV+QjidsptusQr TRGc9BPDD+6PrwZtfX5Q==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1ifAkm-0007lT-II; Wed, 11 Dec 2019 22:46:44 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1ifAkj-0007kX-AD for linux-arm-kernel@lists.infradead.org; Wed, 11 Dec 2019 22:46:42 +0000 Received: from localhost (mobile-166-170-223-177.mycingular.net [166.170.223.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 681C620836; Wed, 11 Dec 2019 22:46:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1576104400; bh=DO7UyfzEBz8p1xfKYT9necVU3BMFfuI27Qs6t3xiY3w=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=OnTKLlyWPmJTjY3iUjPJT0/C8AUPYg7+AIsI4GGDlsiPJBnvr4OMAGjBpVvXqflnb /oqNzVnkS5LSZu4nbtJS26Gi/oc7tXBWG+5TcMNpdM+M7+yCdXeW524IcSsjnr3Dvg IcCcZEpa5rYkE1c8W/kLCNqmx2nsvnKCUPuU8U9A= Date: Wed, 11 Dec 2019 16:46:36 -0600 From: Bjorn Helgaas To: Kishon Vijay Abraham I Subject: Re: [PATCH 0/4] Redesign MSI-X support in PCIe Endpoint Core Message-ID: <20191211224636.GA122332@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20191211124608.887-1-kishon@ti.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191211_144641_373663_170823BB X-CRM114-Status: GOOD ( 14.98 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Lorenzo Pieralisi , Xiaowei Bao , Jingoo Han , linux-kernel@vger.kernel.org, Murali Karicheri , linux-pci@vger.kernel.org, Andrew Murray , Gustavo Pimentel , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Dec 11, 2019 at 06:16:04PM +0530, Kishon Vijay Abraham I wrote: > Existing MSI-X support in Endpoint core has limitations: > 1) MSIX table (which is mapped to a BAR) is not allocated by > anyone. Ideally this should be allocated by endpoint > function driver. > 2) Endpoint controller can choose any random BARs for MSIX > table (irrespective of whether the endpoint function driver > has allocated memory for it or not) > > In order to avoid these limitations, pci_epc_set_msix() is > modified to include BAR Indicator register (BIR) configuration > and MSIX table offset as arguments. This series also fixed MSIX > support in dwc driver and add MSI-X support in Cadence PCIe driver. > > The previous version of Cadence EP MSI-X support is @ [1]. > This series is created on top of [2] > > [1] -> https://patchwork.ozlabs.org/patch/971160/ > [2] -> http://lore.kernel.org/r/20191209092147.22901-1-kishon@ti.com > > Alan Douglas (1): > PCI: cadence: Add MSI-X support to Endpoint driver > > Kishon Vijay Abraham I (3): > PCI: endpoint: Fix ->set_msix() to take BIR and offset as arguments > PCI: dwc: Fix dw_pcie_ep_raise_msix_irq() to get correct MSIX table > address > PCI: keystone: Add AM654 PCIe Endpoint to raise MSIX interrupt Trivial nits: - There's a mix of "MSI-X" and "MSIX" in the subjects, commit logs, and comments. I prefer "MSI-X" to match usage in the spec. - "Fixes:" tags need not include "commit". It doesn't *hurt* anything, but it takes up space that could be used for the subject. - Commit references typically use a 12-char SHA1. Again, doesn't hurt anything. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel