linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Soeren Moch <smoch@web.de>
To: Kalle Valo <kvalo@codeaurora.org>, Heiko Stuebner <heiko@sntech.de>
Cc: brcm80211-dev-list.pdl@broadcom.com, netdev@vger.kernel.org,
	linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-rockchip@lists.infradead.org, Soeren Moch <smoch@web.de>,
	brcm80211-dev-list@cypress.com,
	linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 8/9] arm64: dts: rockchip: RockPro64: enable wifi module at sdio0
Date: Thu, 12 Dec 2019 00:52:52 +0100	[thread overview]
Message-ID: <20191211235253.2539-9-smoch@web.de> (raw)
In-Reply-To: <20191211235253.2539-1-smoch@web.de>

RockPro64 supports an Ampak AP6359SA based wifi/bt combo module.
The BCM4359/9 wifi controller in this module is connected to sdio0,
enable this interface.

Use the in-band sdio irq instead of the out-of-band wifi_host_wake_l
signal since the latter is not working reliably on this board (probably
due to it's PCIe WAKE# connection).

Signed-off-by: Soeren Moch <smoch@web.de>
---
changes in v2:
- add comment about irq in commit message

Not sure where to place exactly the sdio0 node in the dts because
existing sd nodes are not sorted alphabetically.

Cc: Heiko Stuebner <heiko@sntech.de>
Cc: Kalle Valo <kvalo@codeaurora.org>
Cc: linux-wireless@vger.kernel.org
Cc: brcm80211-dev-list.pdl@broadcom.com
Cc: brcm80211-dev-list@cypress.com
Cc: netdev@vger.kernel.org
Cc: linux-arm-kernel@lists.infradead.org
Cc: linux-rockchip@lists.infradead.org
Cc: linux-kernel@vger.kernel.org
---
 .../boot/dts/rockchip/rk3399-rockpro64.dts    | 21 ++++++++++++-------
 1 file changed, 14 insertions(+), 7 deletions(-)

diff --git a/arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dts b/arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dts
index 7f4b2eba31d4..9fa92790d6e0 100644
--- a/arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dts
@@ -71,13 +71,6 @@
 		clock-names = "ext_clock";
 		pinctrl-names = "default";
 		pinctrl-0 = <&wifi_enable_h>;
-
-		/*
-		 * On the module itself this is one of these (depending
-		 * on the actual card populated):
-		 * - SDIO_RESET_L_WL_REG_ON
-		 * - PDN (power down when low)
-		 */
 		reset-gpios = <&gpio0 RK_PB2 GPIO_ACTIVE_LOW>;
 	};

@@ -650,6 +643,20 @@
 	status = "okay";
 };

+&sdio0 {
+	bus-width = <4>;
+	cap-sd-highspeed;
+	cap-sdio-irq;
+	disable-wp;
+	keep-power-in-suspend;
+	mmc-pwrseq = <&sdio_pwrseq>;
+	non-removable;
+	pinctrl-names = "default";
+	pinctrl-0 = <&sdio0_bus4 &sdio0_cmd &sdio0_clk>;
+	sd-uhs-sdr104;
+	status = "okay";
+};
+
 &sdmmc {
 	bus-width = <4>;
 	cap-sd-highspeed;
--
2.17.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2019-12-11 23:54 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-11 23:52 [PATCH v2 0/9] brcmfmac: add support for BCM4359 SDIO chipset Soeren Moch
2019-12-11 23:52 ` [PATCH v2 1/9] brcmfmac: reset two D11 cores if chip has two D11 cores Soeren Moch
2019-12-18 19:08   ` Kalle Valo
2019-12-11 23:52 ` [PATCH v2 2/9] brcmfmac: set F2 blocksize and watermark for 4359 Soeren Moch
2019-12-11 23:52 ` [PATCH v2 3/9] brcmfmac: fix rambase for 4359/9 Soeren Moch
2019-12-12  2:07   ` Chi-Hsien Lin
2019-12-11 23:52 ` [PATCH v2 4/9] brcmfmac: make errors when setting roaming parameters non-fatal Soeren Moch
2019-12-11 23:52 ` [PATCH v2 5/9] brcmfmac: add support for BCM4359 SDIO chipset Soeren Moch
2019-12-12  1:02   ` Soeren Moch
2019-12-12  2:09   ` Chi-Hsien Lin
2019-12-12  8:33   ` Ulf Hansson
2019-12-11 23:52 ` [PATCH v2 6/9] brcmfmac: add RSDB condition when setting interface combinations Soeren Moch
2019-12-11 23:52 ` [PATCH v2 7/9] brcmfmac: not set mbss in vif if firmware does not support MBSS Soeren Moch
2019-12-11 23:52 ` Soeren Moch [this message]
2019-12-11 23:52 ` [PATCH v2 9/9] arm64: dts: rockchip: RockPro64: hook up bluetooth at uart0 Soeren Moch
2019-12-12 10:22   ` Robin Murphy
2019-12-12 10:47     ` Soeren Moch
2019-12-12  9:42 ` [PATCH v2 0/9] brcmfmac: add support for BCM4359 SDIO chipset Kalle Valo
2019-12-12 10:59   ` Soeren Moch
2019-12-15 21:24     ` Soeren Moch
2019-12-15 23:43       ` Heiko Stübner
2020-03-13 11:03         ` Chi-Hsien Lin
2020-03-13 13:17           ` Soeren Moch
2020-03-15  7:01             ` Chi-Hsien Lin
2019-12-18 11:55 ` Christian Hewitt
2019-12-18 23:04   ` Soeren Moch
2019-12-22  4:35     ` Christian Hewitt
2019-12-24  9:01       ` Arend Van Spriel
2019-12-24  9:44         ` Christian Hewitt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191211235253.2539-9-smoch@web.de \
    --to=smoch@web.de \
    --cc=brcm80211-dev-list.pdl@broadcom.com \
    --cc=brcm80211-dev-list@cypress.com \
    --cc=heiko@sntech.de \
    --cc=kvalo@codeaurora.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).