From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 81EE6C43603 for ; Thu, 12 Dec 2019 11:09:50 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5759E2173E for ; Thu, 12 Dec 2019 11:09:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="uGfAldJq"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="ir9rKrBJ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5759E2173E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=QQx6ASdA3ROHaJLJDxTX93WZ0UdE/JSLgKiP132DTuU=; b=uGfAldJqUraTlC ooXOqs7I3QNSDLoL3Y6/TrF9jS0mxsJZcDSfA+oVFTV/X8YTKDrtOIQEUHmkPaueia+we0KNJoWYN YN7EtuBIR4Mn6GTCV8XQOoNdoMFV3gOi2phb9lk4QngKNvveZ5WPCxTbVzLqi/vzZcWH4fTi1esmW ga/q+FcgzL+/hzim2+Dbb32L5V8oG8NUtkE+BnFUe7HYpZnDctReJDAej2daeg4tG3uF9almwgaJe YzUipOOKCk8DbcUWI4UeZEDJw/GKwn4HLQUc+xWNqVA3vIJ4Mu5mC6F86xjzGpDgcfUp4y7WwGkcT UyZNVw39f7j/nuocqNmg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1ifMLu-0000kH-0D; Thu, 12 Dec 2019 11:09:50 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1ifMLr-0000jF-Jm for linux-arm-kernel@lists.infradead.org; Thu, 12 Dec 2019 11:09:48 +0000 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D1CC32173E; Thu, 12 Dec 2019 11:09:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1576148987; bh=+GFNXfvIWLY+SyoBzCk2uPC4c9BxTnXM+rB6AmqcWi4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ir9rKrBJyZLhcb8cL8S3osHkFAebLn3LOLLxEQn1GXzulDC+tR9ZhMDLVa+m29V22 AVEnnsapucoGJ0KWTtnniU0FFfkEwfuH/lq28WJAze2KDaN7zacX8dP894EdRi3IOU 85Um7jiHOB6+SUWWV+gg+qtGjU88vV0wqKqVwY5Y= Date: Thu, 12 Dec 2019 12:09:44 +0100 From: Greg Kroah-Hartman To: Krzysztof Kozlowski Subject: Re: [PATCH 10/10] tty: serial: samsung_tty: fix blank line checkpatch warning Message-ID: <20191212110944.GC1490894@kroah.com> References: <20191210143706.3928480-1-gregkh@linuxfoundation.org> <20191210143706.3928480-10-gregkh@linuxfoundation.org> <20191210151345.GI11222@pi3> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20191210151345.GI11222@pi3> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191212_030947_671999_F47F6953 X-CRM114-Status: GOOD ( 10.44 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Shinbeom Choi , Hyunki Koo , Kukjin Kim , linux-arm-kernel@lists.infradead.org, linux-serial@vger.kernel.org, Jiri Slaby , HYUN-KI KOO Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Dec 10, 2019 at 04:13:45PM +0100, Krzysztof Kozlowski wrote: > On Tue, Dec 10, 2019 at 03:37:06PM +0100, Greg Kroah-Hartman wrote: > > checkpatch is giving a bunch of: > > WARNING: Missing a blank line after declarations > > messages on this file, so fix up all instances of that issue. > > I would prefer to squash it with previous. These are not bugs, just > minor coding style violations so there is no point to split it per > patch. Too much churn. For coding style fixes, in staging, I require "one type of change per patch" otherwise big "fix all the coding style issues" patches are impossible to review. Breaking it up into tiny pieces makes it easy/trivial to review, which makes it easier for maintainers, which is the key here. There is no "churn". thanks, greg k-h _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel