From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8DAFAC43603 for ; Fri, 13 Dec 2019 22:24:27 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 61B072077B for ; Fri, 13 Dec 2019 22:24:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="slrsJqQM" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 61B072077B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Ilrk0iJzrWD6uTl62tRmHK00b/+HQS/ddYM1GbmDCkE=; b=slrsJqQMy5Q6IO 6vdfVSmhvkjI9xVql4cm5LmUh7HzVtq1jb2zu5lSEi1DFyhK4hjy+4+eGdGA4ccqGVZ4Kk1TxHruD H4LzMCNTgRYYOTIxqwDCmxcJDq1leAUEB1o+fK/xskMJ7TQFDMZKp1IQH4SzgshD4lkvApNuLqkVv xlXJhcg4zbENO/sfOGe8/0rfrh85e6CqCJVS8VCXfITp+9yGyoe7nngDPpsZX4TQDIil9YXNMnspL 9jpy9cCA5Xv5ZG0HGkbt1VzFmZ7uSzYhm/N5fYJO8Qy1GF8zgAPAdM6cVw9ou35ZB++lLR+I/SNPJ o2QeS1GabFDDi4HNSgEw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1ifr8n-0006oF-HW; Fri, 13 Dec 2019 20:02:21 +0000 Received: from mga14.intel.com ([192.55.52.115]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1ifr8j-0006nl-Sa for linux-arm-kernel@lists.infradead.org; Fri, 13 Dec 2019 20:02:19 +0000 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 13 Dec 2019 12:01:51 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,311,1571727600"; d="scan'208";a="208563026" Received: from sjchrist-coffee.jf.intel.com (HELO linux.intel.com) ([10.54.74.202]) by orsmga008.jf.intel.com with ESMTP; 13 Dec 2019 12:01:51 -0800 Date: Fri, 13 Dec 2019 12:01:51 -0800 From: Sean Christopherson To: James Hogan , Paul Mackerras , Christian Borntraeger , Janosch Frank , Paolo Bonzini , Radim =?utf-8?B?S3LEjW3DocWZ?= , Marc Zyngier Subject: Re: [PATCH v3 00/15] KVM: Dynamically size memslot arrays Message-ID: <20191213200151.GF31552@linux.intel.com> References: <20191024230744.14543-1-sean.j.christopherson@intel.com> <20191203221433.GK19877@linux.intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20191203221433.GK19877@linux.intel.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191213_120217_935847_2AEB4ECB X-CRM114-Status: GOOD ( 16.59 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Christoffer Dall , Wanpeng Li , kvm@vger.kernel.org, David Hildenbrand , Joerg Roedel , Cornelia Huck , linux-mips@vger.kernel.org, kvm-ppc@vger.kernel.org, linux-kernel@vger.kernel.org, James Morse , linux-arm-kernel@lists.infradead.org, Vitaly Kuznetsov , Suzuki K Poulose , kvmarm@lists.cs.columbia.edu, Julien Thierry , Jim Mattson Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Dec 03, 2019 at 02:14:33PM -0800, Sean Christopherson wrote: > On Thu, Oct 24, 2019 at 04:07:29PM -0700, Sean Christopherson wrote: > > The end goal of this series is to dynamically size the memslot array so > > that KVM allocates memory based on the number of memslots in use, as > > opposed to unconditionally allocating memory for the maximum number of > > memslots. On x86, each memslot consumes 88 bytes, and so with 2 address > > spaces of 512 memslots, each VM consumes ~90k bytes for the memslots. > > E.g. given a VM that uses a total of 30 memslots, dynamic sizing reduces > > the memory footprint from 90k to ~2.6k bytes. > > > > The changes required to support dynamic sizing are relatively small, > > e.g. are essentially contained in patches 14/15 and 15/15. Patches 1-13 > > clean up the memslot code, which has gotten quite crusty, especially > > __kvm_set_memory_region(). The clean up is likely not strictly necessary > > to switch to dynamic sizing, but I didn't have a remotely reasonable > > level of confidence in the correctness of the dynamic sizing without first > > doing the clean up. > > > > Christoffer, I added your Tested-by to the patches that I was confident > > would be fully tested based on the desription of what you tested. Let me > > know if you disagree with any of 'em. > > > > v3: > > - Fix build errors on PPC and MIPS due to missed params during > > refactoring [kbuild test robot]. > > - Rename the helpers for update_memslots() and add comments describing > > the new algorithm and how it interacts with searching [Paolo]. > > - Remove the unnecessary and obnoxious warning regarding memslots being > > a flexible array [Paolo]. > > - Fix typos in the changelog of patch 09/15 [Christoffer]. > > - Collect tags [Christoffer]. > > > > v2: > > - Split "Drop kvm_arch_create_memslot()" into three patches to move > > minor functional changes to standalone patches [Janosch]. > > - Rebase to latest kvm/queue (f0574a1cea5b, "KVM: x86: fix ...") > > - Collect an Acked-by and a Reviewed-by > > Paolo, do you want me to rebase this to the latest kvm/queue? Ping. Applies cleanly on the current kvm/queue and nothing caught fire in testing (though I only re-tested the series as a whole). _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel