From: Tao Ren <rentao.bupt@gmail.com>
To: Joel Stanley <joel@jms.id.au>
Cc: Andrew Jeffery <andrew@aj.id.au>,
Alexander Filippov <a.filippov@yadro.com>,
linux-aspeed@lists.ozlabs.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] ARM: dts: aspeed: AST2400 disables hw checksum
Date: Sun, 15 Dec 2019 23:01:32 -0800 [thread overview]
Message-ID: <20191216070131.GA11755@taoren-ubuntu-R90MNF91> (raw)
In-Reply-To: <20191216064132.78015-1-joel@jms.id.au>
On Mon, Dec 16, 2019 at 05:41:32PM +1100, Joel Stanley wrote:
> There is no need to specify this property in the device tree as the
> AST2400 does not have working hardware checksum and disables it in the
> driver.
>
> Signed-off-by: Joel Stanley <joel@jms.id.au>
> ---
> arch/arm/boot/dts/aspeed-bmc-facebook-wedge100.dts | 1 -
> arch/arm/boot/dts/aspeed-bmc-facebook-wedge40.dts | 1 -
> arch/arm/boot/dts/aspeed-bmc-opp-vesnin.dts | 3 ---
> 3 files changed, 5 deletions(-)
>
> diff --git a/arch/arm/boot/dts/aspeed-bmc-facebook-wedge100.dts b/arch/arm/boot/dts/aspeed-bmc-facebook-wedge100.dts
> index b1e10f0c85c9..322587b7b67d 100644
> --- a/arch/arm/boot/dts/aspeed-bmc-facebook-wedge100.dts
> +++ b/arch/arm/boot/dts/aspeed-bmc-facebook-wedge100.dts
> @@ -76,7 +76,6 @@ &uart5 {
>
> &mac1 {
> status = "okay";
> - no-hw-checksum;
> pinctrl-names = "default";
> pinctrl-0 = <&pinctrl_rgmii2_default &pinctrl_mdio2_default>;
> };
> diff --git a/arch/arm/boot/dts/aspeed-bmc-facebook-wedge40.dts b/arch/arm/boot/dts/aspeed-bmc-facebook-wedge40.dts
> index aaa77a597d1a..54e508530dce 100644
> --- a/arch/arm/boot/dts/aspeed-bmc-facebook-wedge40.dts
> +++ b/arch/arm/boot/dts/aspeed-bmc-facebook-wedge40.dts
> @@ -75,7 +75,6 @@ &uart5 {
>
> &mac1 {
> status = "okay";
> - no-hw-checksum;
> pinctrl-names = "default";
> pinctrl-0 = <&pinctrl_rgmii2_default &pinctrl_mdio2_default>;
> };
> diff --git a/arch/arm/boot/dts/aspeed-bmc-opp-vesnin.dts b/arch/arm/boot/dts/aspeed-bmc-opp-vesnin.dts
> index affd2c8743b1..041f28e3ac10 100644
> --- a/arch/arm/boot/dts/aspeed-bmc-opp-vesnin.dts
> +++ b/arch/arm/boot/dts/aspeed-bmc-opp-vesnin.dts
> @@ -107,10 +107,7 @@ flash@0 {
>
> &mac0 {
> status = "okay";
> -
> use-ncsi;
> - no-hw-checksum;
> -
> pinctrl-names = "default";
> pinctrl-0 = <&pinctrl_rmii1_default>;
> };
> --
> 2.24.0
Thanks for the fix, Joel. I totally forget I added the property in
ast2400 dts.
Reviewed-by: Tao Ren <rentao.bupt@gmail.com>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-12-16 7:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-16 6:41 [PATCH] ARM: dts: aspeed: AST2400 disables hw checksum Joel Stanley
2019-12-16 7:01 ` Tao Ren [this message]
2019-12-16 7:55 ` Alexander A. Filippov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191216070131.GA11755@taoren-ubuntu-R90MNF91 \
--to=rentao.bupt@gmail.com \
--cc=a.filippov@yadro.com \
--cc=andrew@aj.id.au \
--cc=joel@jms.id.au \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).