* [PATCH] ARM: dts: aspeed: AST2400 disables hw checksum
@ 2019-12-16 6:41 Joel Stanley
2019-12-16 7:01 ` Tao Ren
2019-12-16 7:55 ` Alexander A. Filippov
0 siblings, 2 replies; 3+ messages in thread
From: Joel Stanley @ 2019-12-16 6:41 UTC (permalink / raw)
To: linux-arm-kernel, linux-aspeed, Andrew Jeffery
Cc: Tao Ren, Alexander Filippov
There is no need to specify this property in the device tree as the
AST2400 does not have working hardware checksum and disables it in the
driver.
Signed-off-by: Joel Stanley <joel@jms.id.au>
---
arch/arm/boot/dts/aspeed-bmc-facebook-wedge100.dts | 1 -
arch/arm/boot/dts/aspeed-bmc-facebook-wedge40.dts | 1 -
arch/arm/boot/dts/aspeed-bmc-opp-vesnin.dts | 3 ---
3 files changed, 5 deletions(-)
diff --git a/arch/arm/boot/dts/aspeed-bmc-facebook-wedge100.dts b/arch/arm/boot/dts/aspeed-bmc-facebook-wedge100.dts
index b1e10f0c85c9..322587b7b67d 100644
--- a/arch/arm/boot/dts/aspeed-bmc-facebook-wedge100.dts
+++ b/arch/arm/boot/dts/aspeed-bmc-facebook-wedge100.dts
@@ -76,7 +76,6 @@ &uart5 {
&mac1 {
status = "okay";
- no-hw-checksum;
pinctrl-names = "default";
pinctrl-0 = <&pinctrl_rgmii2_default &pinctrl_mdio2_default>;
};
diff --git a/arch/arm/boot/dts/aspeed-bmc-facebook-wedge40.dts b/arch/arm/boot/dts/aspeed-bmc-facebook-wedge40.dts
index aaa77a597d1a..54e508530dce 100644
--- a/arch/arm/boot/dts/aspeed-bmc-facebook-wedge40.dts
+++ b/arch/arm/boot/dts/aspeed-bmc-facebook-wedge40.dts
@@ -75,7 +75,6 @@ &uart5 {
&mac1 {
status = "okay";
- no-hw-checksum;
pinctrl-names = "default";
pinctrl-0 = <&pinctrl_rgmii2_default &pinctrl_mdio2_default>;
};
diff --git a/arch/arm/boot/dts/aspeed-bmc-opp-vesnin.dts b/arch/arm/boot/dts/aspeed-bmc-opp-vesnin.dts
index affd2c8743b1..041f28e3ac10 100644
--- a/arch/arm/boot/dts/aspeed-bmc-opp-vesnin.dts
+++ b/arch/arm/boot/dts/aspeed-bmc-opp-vesnin.dts
@@ -107,10 +107,7 @@ flash@0 {
&mac0 {
status = "okay";
-
use-ncsi;
- no-hw-checksum;
-
pinctrl-names = "default";
pinctrl-0 = <&pinctrl_rmii1_default>;
};
--
2.24.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ARM: dts: aspeed: AST2400 disables hw checksum
2019-12-16 6:41 [PATCH] ARM: dts: aspeed: AST2400 disables hw checksum Joel Stanley
@ 2019-12-16 7:01 ` Tao Ren
2019-12-16 7:55 ` Alexander A. Filippov
1 sibling, 0 replies; 3+ messages in thread
From: Tao Ren @ 2019-12-16 7:01 UTC (permalink / raw)
To: Joel Stanley
Cc: Andrew Jeffery, Alexander Filippov, linux-aspeed,
linux-arm-kernel
On Mon, Dec 16, 2019 at 05:41:32PM +1100, Joel Stanley wrote:
> There is no need to specify this property in the device tree as the
> AST2400 does not have working hardware checksum and disables it in the
> driver.
>
> Signed-off-by: Joel Stanley <joel@jms.id.au>
> ---
> arch/arm/boot/dts/aspeed-bmc-facebook-wedge100.dts | 1 -
> arch/arm/boot/dts/aspeed-bmc-facebook-wedge40.dts | 1 -
> arch/arm/boot/dts/aspeed-bmc-opp-vesnin.dts | 3 ---
> 3 files changed, 5 deletions(-)
>
> diff --git a/arch/arm/boot/dts/aspeed-bmc-facebook-wedge100.dts b/arch/arm/boot/dts/aspeed-bmc-facebook-wedge100.dts
> index b1e10f0c85c9..322587b7b67d 100644
> --- a/arch/arm/boot/dts/aspeed-bmc-facebook-wedge100.dts
> +++ b/arch/arm/boot/dts/aspeed-bmc-facebook-wedge100.dts
> @@ -76,7 +76,6 @@ &uart5 {
>
> &mac1 {
> status = "okay";
> - no-hw-checksum;
> pinctrl-names = "default";
> pinctrl-0 = <&pinctrl_rgmii2_default &pinctrl_mdio2_default>;
> };
> diff --git a/arch/arm/boot/dts/aspeed-bmc-facebook-wedge40.dts b/arch/arm/boot/dts/aspeed-bmc-facebook-wedge40.dts
> index aaa77a597d1a..54e508530dce 100644
> --- a/arch/arm/boot/dts/aspeed-bmc-facebook-wedge40.dts
> +++ b/arch/arm/boot/dts/aspeed-bmc-facebook-wedge40.dts
> @@ -75,7 +75,6 @@ &uart5 {
>
> &mac1 {
> status = "okay";
> - no-hw-checksum;
> pinctrl-names = "default";
> pinctrl-0 = <&pinctrl_rgmii2_default &pinctrl_mdio2_default>;
> };
> diff --git a/arch/arm/boot/dts/aspeed-bmc-opp-vesnin.dts b/arch/arm/boot/dts/aspeed-bmc-opp-vesnin.dts
> index affd2c8743b1..041f28e3ac10 100644
> --- a/arch/arm/boot/dts/aspeed-bmc-opp-vesnin.dts
> +++ b/arch/arm/boot/dts/aspeed-bmc-opp-vesnin.dts
> @@ -107,10 +107,7 @@ flash@0 {
>
> &mac0 {
> status = "okay";
> -
> use-ncsi;
> - no-hw-checksum;
> -
> pinctrl-names = "default";
> pinctrl-0 = <&pinctrl_rmii1_default>;
> };
> --
> 2.24.0
Thanks for the fix, Joel. I totally forget I added the property in
ast2400 dts.
Reviewed-by: Tao Ren <rentao.bupt@gmail.com>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ARM: dts: aspeed: AST2400 disables hw checksum
2019-12-16 6:41 [PATCH] ARM: dts: aspeed: AST2400 disables hw checksum Joel Stanley
2019-12-16 7:01 ` Tao Ren
@ 2019-12-16 7:55 ` Alexander A. Filippov
1 sibling, 0 replies; 3+ messages in thread
From: Alexander A. Filippov @ 2019-12-16 7:55 UTC (permalink / raw)
To: Joel Stanley
Cc: Andrew Jeffery, Tao Ren, Alexander Filippov, linux-aspeed,
linux-arm-kernel
Reviewed-by: Alexander Filippov <a.filippov@yadro.com>
On Mon, Dec 16, 2019 at 05:41:32PM +1100, Joel Stanley wrote:
> There is no need to specify this property in the device tree as the
> AST2400 does not have working hardware checksum and disables it in the
> driver.
>
> Signed-off-by: Joel Stanley <joel@jms.id.au>
> ---
> arch/arm/boot/dts/aspeed-bmc-facebook-wedge100.dts | 1 -
> arch/arm/boot/dts/aspeed-bmc-facebook-wedge40.dts | 1 -
> arch/arm/boot/dts/aspeed-bmc-opp-vesnin.dts | 3 ---
> 3 files changed, 5 deletions(-)
>
> diff --git a/arch/arm/boot/dts/aspeed-bmc-facebook-wedge100.dts b/arch/arm/boot/dts/aspeed-bmc-facebook-wedge100.dts
> index b1e10f0c85c9..322587b7b67d 100644
> --- a/arch/arm/boot/dts/aspeed-bmc-facebook-wedge100.dts
> +++ b/arch/arm/boot/dts/aspeed-bmc-facebook-wedge100.dts
> @@ -76,7 +76,6 @@ &uart5 {
>
> &mac1 {
> status = "okay";
> - no-hw-checksum;
> pinctrl-names = "default";
> pinctrl-0 = <&pinctrl_rgmii2_default &pinctrl_mdio2_default>;
> };
> diff --git a/arch/arm/boot/dts/aspeed-bmc-facebook-wedge40.dts b/arch/arm/boot/dts/aspeed-bmc-facebook-wedge40.dts
> index aaa77a597d1a..54e508530dce 100644
> --- a/arch/arm/boot/dts/aspeed-bmc-facebook-wedge40.dts
> +++ b/arch/arm/boot/dts/aspeed-bmc-facebook-wedge40.dts
> @@ -75,7 +75,6 @@ &uart5 {
>
> &mac1 {
> status = "okay";
> - no-hw-checksum;
> pinctrl-names = "default";
> pinctrl-0 = <&pinctrl_rgmii2_default &pinctrl_mdio2_default>;
> };
> diff --git a/arch/arm/boot/dts/aspeed-bmc-opp-vesnin.dts b/arch/arm/boot/dts/aspeed-bmc-opp-vesnin.dts
> index affd2c8743b1..041f28e3ac10 100644
> --- a/arch/arm/boot/dts/aspeed-bmc-opp-vesnin.dts
> +++ b/arch/arm/boot/dts/aspeed-bmc-opp-vesnin.dts
> @@ -107,10 +107,7 @@ flash@0 {
>
> &mac0 {
> status = "okay";
> -
> use-ncsi;
> - no-hw-checksum;
> -
> pinctrl-names = "default";
> pinctrl-0 = <&pinctrl_rmii1_default>;
> };
> --
> 2.24.0
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-12-16 7:55 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-12-16 6:41 [PATCH] ARM: dts: aspeed: AST2400 disables hw checksum Joel Stanley
2019-12-16 7:01 ` Tao Ren
2019-12-16 7:55 ` Alexander A. Filippov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).