From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8A3A6C43603 for ; Mon, 16 Dec 2019 08:21:06 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4B8D620725 for ; Mon, 16 Dec 2019 08:21:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="hShiOW5x" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4B8D620725 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Bi5ISu2MJ3kzYCTcN2mQtmfMpyYN+O3GdWNqATwy9EU=; b=hShiOW5xRAn5Kq pjLuXuGtwdXH820ITXiEw2qkE/VpjQQ7J5MS5QfrnA5u/BykNoRRv5Y7Jsn5Y1YQWA58+rQ/miXdn E2nV9WsspT7Bvl+p9CTtkt4Yy3EOC2mpXmS1hz7hzGkFTWm5sRTnMA1csRjbXx/jAdVFuFZGFNNBQ q0k9c0i4s6FhiGqYdJT8n9QbxiEFVJ/7JgYq1vRp8oaxp6I1X0cu6P7NutB6QmcHIGhZJOyqxhZtN X3t0+ce2j7otIFdDNHcFH3W7baXRhDazjO/iW08nsnaAUQQnQ/fj5f8lPHGa+U2bTwdREOwDUSOu5 Y/gbDvsn+SJnvEvWXOVg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iglcl-000215-4S; Mon, 16 Dec 2019 08:21:03 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iglci-00020N-2X for linux-arm-kernel@lists.infradead.org; Mon, 16 Dec 2019 08:21:01 +0000 Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1iglcg-0007wx-JI; Mon, 16 Dec 2019 09:20:58 +0100 Received: from ukl by ptx.hi.pengutronix.de with local (Exim 4.89) (envelope-from ) id 1iglcg-0003qd-8E; Mon, 16 Dec 2019 09:20:58 +0100 Date: Mon, 16 Dec 2019 09:20:58 +0100 From: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= To: Jitao Shi Subject: Re: [PATCH v2 2/2] pwm/mtk_disp: move the reg enable trigger in config Message-ID: <20191216082058.xisbafewfttpkij6@pengutronix.de> References: <20191216070123.114719-1-jitao.shi@mediatek.com> <20191216070123.114719-3-jitao.shi@mediatek.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20191216070123.114719-3-jitao.shi@mediatek.com> User-Agent: NeoMutt/20170113 (1.7.2) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191216_002100_118422_8C18D030 X-CRM114-Status: UNSURE ( 6.85 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-pwm@vger.kernel.org, linux-kernel@vger.kernel.org, CK Hu , sj.huang@mediatek.com, Thierry Reding , linux-mediatek@lists.infradead.org, Matthias Brugger , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Dec 16, 2019 at 03:01:23PM +0800, Jitao Shi wrote: > Remove the regist enable trigger setting in probe. > Move the trigger to mtk_disp_pwm_config(). Same as in patch 1: You describe what is (somewhat) obvious when reading the patch. But the motivation isn't clear. Best regards Uwe -- = Pengutronix e.K. | Uwe Kleine-K=F6nig | Industrial Linux Solutions | https://www.pengutronix.de/ | _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel