From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B2016C43603 for ; Tue, 17 Dec 2019 13:11:26 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7FF8D21D7D for ; Tue, 17 Dec 2019 13:11:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="GKOK4KVt"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ffwll.ch header.i=@ffwll.ch header.b="fc2Vim7o" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7FF8D21D7D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ffwll.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ndiF/A1amcGXZW5Ux5UNA8OOESxXN6i78gak7/oTK28=; b=GKOK4KVtoMylBW 481xYQ+C42vg7dh7ySp3IAOc6C7R0fm8EJeYTrSk7ZiErGllbPCRbViCQT5S7FhzTyU5JPbdKu4gn LtbxIVmxzXu/bA/60C1fXiei0NoUu+KITGJm+KCUHe60z/HLfUH+ijsKfJgv4nv1h7rOxjxtdcDrU j2TnNv/qMEVHmZ5nbGemAwuZvIxmwDzD3NqPTEDk98nLXWmj+mbxVXeSu9+aMWqgweuQx37D0Q3EU IBjIYwkS43MmR9iVlX78zq4yCZTuEthw82MPwbIyEybtWsOQx0csMWdhUFFEudu06HCdqcMhJLHsO 7O6dYc9YT7kl7KHqtwjQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1ihCdK-0007f4-07; Tue, 17 Dec 2019 13:11:26 +0000 Received: from mail-wm1-x342.google.com ([2a00:1450:4864:20::342]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1ihCdH-0007ea-33 for linux-arm-kernel@lists.infradead.org; Tue, 17 Dec 2019 13:11:24 +0000 Received: by mail-wm1-x342.google.com with SMTP id f129so3101419wmf.2 for ; Tue, 17 Dec 2019 05:11:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=EZSohn1ysZnbfO+3Bztlv6MzaXMOulcwi+iBjK/JuWw=; b=fc2Vim7oz1vcI4NLmDgMW1dhc0j8fgTDpLRrcaLg5cY39SRL+RXduKEm6XXtNlKeLx TOCFDNEAPs7T3Xb5xCtFVMzYDjMqGCEDtkbFKQbQPooDyqWVWTGqXlpgT/wwI7tV5Liz ggTVdpkqzR2EAt8HHECw0hyjZQI018s5nVgdI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=EZSohn1ysZnbfO+3Bztlv6MzaXMOulcwi+iBjK/JuWw=; b=WdGOd0P1mnsNj4tseI3baRCwRCu1MK+k7gXmf6zQuW5FcpoEgpkkRcZwEtaGhqXirG OLNHJ/J5fpTrma23jnQR68JvPl8qKNa5/0bEMe3f7F4AA2bYyMpfvlQDt432Pr9iRjCR 0o8CvWDdxIH9QrT5ZNGluVwQsY4ZVz80zv7PzcezYLon+q658D4PUpxzobxKnHFWCgZ4 xkpY1jxBjgYCPWP7yueHIOnMJU80zOQsi1tBmwaWf+rclIF0jaXm5yrylC9Qqi5Dbdih LXvwhCK5X4c7QdV0tLXL19BG/PVhyfz5a6sEiymTBxzLs0MOhLCrsio8wbAW0ZNBecRH ityg== X-Gm-Message-State: APjAAAVTHvpYj5K7KaYpW9v9cJpJiCoPaEu09Cb1WlKI5CWQP9mBed5m xWM8ewRTdVoM83knb9l6JDbJVg== X-Google-Smtp-Source: APXvYqwnmrkbC3b8LKKLFJqsp0qQ0RvZn9NSTyd4VwnWz/FmEMNPXPPr1xwYT+qU4vMGwbEpGinYzw== X-Received: by 2002:a1c:1f51:: with SMTP id f78mr5256447wmf.60.1576588280808; Tue, 17 Dec 2019 05:11:20 -0800 (PST) Received: from phenom.ffwll.local ([2a02:168:564b:0:7567:bb67:3d7f:f863]) by smtp.gmail.com with ESMTPSA id k4sm3028383wmk.26.2019.12.17.05.11.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Dec 2019 05:11:19 -0800 (PST) Date: Tue, 17 Dec 2019 14:11:18 +0100 From: Daniel Vetter To: DRI Development Subject: Re: [PATCH 04/10] drm/malidp: plane_state->fb iff plane_state->crtc Message-ID: <20191217131118.GX624164@phenom.ffwll.local> References: <20191213172612.1514842-1-daniel.vetter@ffwll.ch> <20191213172612.1514842-4-daniel.vetter@ffwll.ch> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20191213172612.1514842-4-daniel.vetter@ffwll.ch> X-Operating-System: Linux phenom 5.3.0-2-amd64 User-Agent: Mutt/1.12.2 (2019-09-21) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191217_051123_196039_BAF3E1D2 X-CRM114-Status: GOOD ( 17.09 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Fabio Estevam , Philipp Zabel , Daniel Vetter , Sascha Hauer , NXP Linux Team , Pengutronix Kernel Team , Daniel Vetter , Shawn Guo , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Dec 13, 2019 at 06:26:06PM +0100, Daniel Vetter wrote: > Checking both is one too much, so wrap a WARN_ON around it to stope > the copypasta. > > Signed-off-by: Daniel Vetter > Cc: Philipp Zabel > Cc: Shawn Guo > Cc: Sascha Hauer > Cc: Pengutronix Kernel Team > Cc: Fabio Estevam > Cc: NXP Linux Team > Cc: linux-arm-kernel@lists.infradead.org Oops, subect should be drm/imx: ofc here. -Daniel > --- > drivers/gpu/drm/imx/ipuv3-plane.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/imx/ipuv3-plane.c b/drivers/gpu/drm/imx/ipuv3-plane.c > index 28826c0aa24a..6776ebb3246d 100644 > --- a/drivers/gpu/drm/imx/ipuv3-plane.c > +++ b/drivers/gpu/drm/imx/ipuv3-plane.c > @@ -359,7 +359,7 @@ static int ipu_plane_atomic_check(struct drm_plane *plane, > if (!fb) > return 0; > > - if (!state->crtc) > + if (WARN_ON(!state->crtc)) > return -EINVAL; > > crtc_state = > -- > 2.24.0 > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel