From: Tony Lindgren <tony@atomide.com>
To: santosh.shilimkar@oracle.com
Cc: linux-omap@vger.kernel.org, Dave Gerlach <d-gerlach@ti.com>,
linux-kernel@vger.kernel.org,
Santosh Shilimkar <ssantosh@kernel.org>,
Suman Anna <s-anna@ti.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] soc: ti: wkup_m3_ipc: Fix race condition with rproc_boot
Date: Tue, 17 Dec 2019 10:35:48 -0800 [thread overview]
Message-ID: <20191217183548.GE35479@atomide.com> (raw)
In-Reply-To: <05b9f0ff-bbc2-d8a7-3261-54c03a149db8@oracle.com>
* santosh.shilimkar@oracle.com <santosh.shilimkar@oracle.com> [191217 18:33]:
> On 12/17/19 10:25 AM, Tony Lindgren wrote:
> > Hi,
> >
> > * Dave Gerlach <d-gerlach@ti.com> [191211 20:02]:
> > > Any user of wkup_m3_ipc calls wkup_m3_ipc_get to get a handle and this
> > > checks the value of the static variable m3_ipc_state to see if the
> > > wkup_m3 is ready. Currently this is populated during probe before
> > > rproc_boot has been called, meaning there is a window of time that
> > > wkup_m3_ipc_get can return a valid handle but the wkup_m3 itself is not
> > > ready, leading to invalid IPC calls to the wkup_m3 and system
> > > instability.
> > >
> > > To avoid this, move the population of the m3_ipc_state variable until
> > > after rproc_boot has succeeded to guarantee a valid and usable handle
> > > is always returned.
> >
> > Santosh, do you want me to pick this one into my fixes branch?
> >
> Sure, go ahead.
>
> Acked-by: Santosh Shilimkar <ssantosh@kernel.org>
OK thanks applying into fixes.
Tony
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2019-12-17 18:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-12 4:03 [PATCH] soc: ti: wkup_m3_ipc: Fix race condition with rproc_boot Dave Gerlach
2019-12-17 18:25 ` Tony Lindgren
2019-12-17 18:32 ` santosh.shilimkar
2019-12-17 18:35 ` Tony Lindgren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191217183548.GE35479@atomide.com \
--to=tony@atomide.com \
--cc=d-gerlach@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=s-anna@ti.com \
--cc=santosh.shilimkar@oracle.com \
--cc=ssantosh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).