From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 49388C43603 for ; Wed, 18 Dec 2019 02:57:09 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1A263206D8 for ; Wed, 18 Dec 2019 02:57:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="cwzZGiAe" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1A263206D8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=HV+pI6KZIoVAn5hDmL9FHPXcGbzwdKJ/zbTzq9cMPg8=; b=cwzZGiAe4ykaUg 367YnNDaYigGJSv3S7Yg5b0PpLCw+IPGt3w96pKOtpczQcl5AmFIDqasegYhtdqPxlt9BGrA5PjGV 8GYcG0PGbloj45EWdlK0+RkVVdeSgI6DjI2KE0pgI5F8OK0pBQ9pMv8rNgrGf4LjCmys/NAlKYptx lGdS0K5RydmD6klZMOEKP0qCPKzQ0Owwwau3r7bd6LKvlV/NEz+xe+pq/Zne3V5Rkpgfbz72ON7yw Ob58/feRxIzLwW+58JjD4VvpGH3VDBzqQh2tMLEUlbo3X1Ic40OSz1t40YjpRVxOwAh4RaZzVY/hY SSSnvGTI5ojBH85UyECw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1ihPWO-00064M-Jw; Wed, 18 Dec 2019 02:57:08 +0000 Received: from mail-ot1-f67.google.com ([209.85.210.67]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1ihPWK-00063P-F7 for linux-arm-kernel@lists.infradead.org; Wed, 18 Dec 2019 02:57:06 +0000 Received: by mail-ot1-f67.google.com with SMTP id h20so511123otn.5 for ; Tue, 17 Dec 2019 18:57:04 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=HnATBlbL+eZiW12mo0hwrch2CUsppmWX32lWHiTL+YQ=; b=h+f5vmdnaWdkfBJuGCP70Ttojc6LKRRIHciw1Jc/mRdyXtUuRVJDM48HIg6eiv4sLl 7Lal8PEnDf34504canwuOsibMrWMgM85ShFAWa9eKI/Qg5N6l1RZROZJZTfpu151IiAr CQ+wYtFuAzteWaFNnim972RrNOg43/ahsCRnpGLq2T/+1XRiM0KAphIhHjR0DhVpImxp OQW4gOhq3rI/loCsNC7irc00eXMUb4DZr+Gqg+o70EKX7tr5E7dDeA9FVOoMWNFYn61i rfwp+Nv3+4ItVyheI/1Xwkbl0j/fDeu2UMXPnVuQrbWxtRdHzxNfHId6mgRAZ39kjS8L ET1Q== X-Gm-Message-State: APjAAAX60bCCn+beR9nD72Fu5w0v9QT0y7wD0xIroTHGrnuZ4wcNJUNK ZwPRBL75mvDkhHrDqd6VLQ== X-Google-Smtp-Source: APXvYqyihxi8JukdWSv/sqB94AVfuF+A3sZ6QOp7w2twJ4p+CCqPcHedgqwNmZ40BJJHYASG2nIe0Q== X-Received: by 2002:a05:6830:20c6:: with SMTP id z6mr43585otq.272.1576637823440; Tue, 17 Dec 2019 18:57:03 -0800 (PST) Received: from localhost (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.gmail.com with ESMTPSA id z21sm288506oto.52.2019.12.17.18.57.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Dec 2019 18:57:02 -0800 (PST) Date: Tue, 17 Dec 2019 20:57:02 -0600 From: Rob Herring To: Jae Hyun Yoo Subject: Re: [PATCH v11 04/14] dt-bindings: Add bindings document of Aspeed PECI adapter Message-ID: <20191218025702.GA18998@bogus> References: <20191211194624.2872-1-jae.hyun.yoo@linux.intel.com> <20191211194624.2872-5-jae.hyun.yoo@linux.intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20191211194624.2872-5-jae.hyun.yoo@linux.intel.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191217_185705_150110_6DCEE0C6 X-CRM114-Status: GOOD ( 22.74 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Randy Dunlap , Tomer Maimon , devicetree@vger.kernel.org, Benjamin Herrenschmidt , Milton Miller II , Frederic Barrat , Pavel Machek , Mauro Carvalho Chehab , Lee Jones , Jason M Biils , Eric Sandeen , Lorenzo Pieralisi , Jonathan Corbet , openbmc@lists.ozlabs.org, linux-doc@vger.kernel.org, Kishon Vijay Abraham I , Joel Stanley , "Bryant G . Ly" , Uwe Kleine-Konig , David Kershner , Guenter Roeck , Wu Hao , linux-hwmon@vger.kernel.org, Jean Delvare , Arnd Bergmann , Philippe Ombredanne , Johan Hovold , Tomohiro Kusumi , Thomas Gleixner , Sagar Dharia , linux-arm-kernel@lists.infradead.org, Juergen Gross , Cyrille Pitchen , Ryan Chen , Andrew Jeffery , Greg Kroah-Hartman , "Darrick J . Wong" , Stephen Boyd , Vinod Koul , Gustavo Pimentel , Andrew Morton , Robin Murphy , "David S . Miller" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Dec 11, 2019 at 11:46:14AM -0800, Jae Hyun Yoo wrote: > This commit adds bindings document of Aspeed PECI adapter for ASPEED > AST24xx/25xx/26xx SoCs. > > Cc: Mark Rutland > Cc: Joel Stanley > Cc: Andrew Jeffery > Cc: Benjamin Herrenschmidt > Cc: Greg Kroah-Hartman > Cc: Jason M Biils > Cc: Milton Miller II > Cc: Pavel Machek > Cc: Robin Murphy > Cc: Ryan Chen > Signed-off-by: Jae Hyun Yoo > --- > Changes since v10: > - Changed documents format to DT schema format so I dropped all review tags. > Please review it again. > > .../devicetree/bindings/peci/peci-aspeed.yaml | 124 ++++++++++++++++++ > 1 file changed, 124 insertions(+) > create mode 100644 Documentation/devicetree/bindings/peci/peci-aspeed.yaml > > diff --git a/Documentation/devicetree/bindings/peci/peci-aspeed.yaml b/Documentation/devicetree/bindings/peci/peci-aspeed.yaml > new file mode 100644 > index 000000000000..0f5c2993fe9b > --- /dev/null > +++ b/Documentation/devicetree/bindings/peci/peci-aspeed.yaml > @@ -0,0 +1,124 @@ > +# SPDX-License-Identifier: GPL-2.0 > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/peci/peci-aspeed.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Aspeed PECI Bus Device Tree Bindings > + > +maintainers: > + - Jae Hyun Yoo > + > +properties: > + compatible: > + enum: > + - aspeed,ast2400-peci > + - aspeed,ast2500-peci > + - aspeed,ast2600-peci > + > + reg: > + maxItems: 1 > + > + "#address-cells": > + # Required to define a client address. > + const: 1 > + > + "#size-cells": > + # Required to define a client address. > + const: 0 These 2 can be defined by the bus schema. > + > + interrupts: > + maxItems: 1 > + > + clocks: > + description: | You can drop the '|' if there's no formatting to preserve. > + Clock source for PECI controller. Should reference the external > + oscillator clock. > + maxItems: 1 > + > + resets: > + maxItems: 1 > + > + clock-frequency: > + # Operation frequency of PECI controller in units of Hz. > + minimum: 187500 > + maximum: 24000000 > + > + msg-timing: > + description: | > + Message timing negotiation period. This value will determine the period > + of message timing negotiation to be issued by PECI controller. The unit > + of the programmed value is four times of PECI clock period. > + allOf: > + - $ref: /schemas/types.yaml#/definitions/uint32 > + - minimum: 0 > + maximum: 255 > + default: 1 > + > + addr-timing: > + description: | > + Address timing negotiation period. This value will determine the period > + of address timing negotiation to be issued by PECI controller. The unit > + of the programmed value is four times of PECI clock period. > + allOf: > + - $ref: /schemas/types.yaml#/definitions/uint32 > + - minimum: 0 > + maximum: 255 > + default: 1 > + > + rd-sampling-point: > + description: | > + Read sampling point selection. The whole period of a bit time will be > + divided into 16 time frames. This value will determine the time frame > + in which the controller will sample PECI signal for data read back. > + Usually in the middle of a bit time is the best. > + allOf: > + - $ref: /schemas/types.yaml#/definitions/uint32 > + - minimum: 0 > + maximum: 15 > + default: 8 > + > + cmd-timeout-ms: > + # Command timeout in units of ms. > + allOf: > + - $ref: /schemas/types.yaml#/definitions/uint32 > + - minimum: 1 > + maximum: 60000 > + default: 1000 > + > +required: > + - compatible > + - reg > + - "#address-cells" > + - "#size-cells" > + - interrupts > + - clocks > + - resets > + - clock-frequency > + > +examples: > + - | > + #include > + #include > + peci: bus@1e78b000 { > + compatible = "simple-bus"; > + #address-cells = <1>; > + #size-cells = <1>; > + ranges = <0x0 0x1e78b000 0x60>; You can drop this node in the examples. > + > + peci0: peci-bus@0 { > + compatible = "aspeed,ast2600-peci"; > + reg = <0x0 0x100>; > + #address-cells = <1>; > + #size-cells = <0>; > + interrupts = ; > + clocks = <&syscon ASPEED_CLK_GATE_REF0CLK>; > + resets = <&syscon ASPEED_RESET_PECI>; > + clock-frequency = <24000000>; > + msg-timing = <1>; > + addr-timing = <1>; > + rd-sampling-point = <8>; > + cmd-timeout-ms = <1000>; > + }; > + }; > +... > -- > 2.17.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel