From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1E106C43603 for ; Wed, 18 Dec 2019 14:46:10 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E3EE321582 for ; Wed, 18 Dec 2019 14:46:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Nbcarsyq" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E3EE321582 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=6WPGmPog+7ANeq0E3NzuGaco51QTRJw8g2OUWtfim/g=; b=NbcarsyqNkL7a3 FXyVi0x9vtQY6zeAg14PDGijJVeaj9yFtuqouqTlbd7m0x8jnLhqeRhDVOM3J6JtzNIyQ0mzZJdEc id50SADB2qcDwcknx6xS2FQui8QXHyCfBaX0mvCCuU/VBLwbXgcsvWFl9WnMCcRbrVmA7yCrrKzJn UtGXAEkIMafY1KuPw0sCYFQzJdVn2C/VoypQAgAATcafMPQkUwkhuQzR1RqSlC5ysmghs/FnvyWr8 xHd/rJKcKCkiar7LChzM1AxNBEyAwqjEbVYY5BxZPu4zjqsy7J3sxA0dQ0gVp5rA3Cy+323/gwESX wNfKQYMSX5wvm67Zo/oQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1ihaaX-0005tD-DR; Wed, 18 Dec 2019 14:46:09 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1ihaaU-0005sL-5K for linux-arm-kernel@lists.infradead.org; Wed, 18 Dec 2019 14:46:07 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 88F2430E; Wed, 18 Dec 2019 06:46:04 -0800 (PST) Received: from bogus (e107155-lin.cambridge.arm.com [10.1.196.42]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id DDF753F719; Wed, 18 Dec 2019 06:46:02 -0800 (PST) Date: Wed, 18 Dec 2019 14:45:55 +0000 From: Sudeep Holla To: Jolly Shah Subject: Re: [PATCH 0/5] firmware: xilinx: Add xilinx specific sysfs interface Message-ID: <20191218144555.GA12525@bogus> References: <1575502159-11327-1-git-send-email-jolly.shah@xilinx.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1575502159-11327-1-git-send-email-jolly.shah@xilinx.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191218_064606_246126_69E1A308 X-CRM114-Status: UNSURE ( 8.66 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: keescook@chromium.org, ard.biesheuvel@linaro.org, matt@codeblueprint.co.uk, gregkh@linuxfoundation.org, dmitry.torokhov@gmail.com, michal.simek@xilinx.com, linux-kernel@vger.kernel.org, rajanv@xilinx.com, Sudeep Holla , mingo@kernel.org, linux-arm-kernel@lists.infradead.org, hkallweit1@gmail.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Dec 04, 2019 at 03:29:14PM -0800, Jolly Shah wrote: > This patch series adds xilinx specific sysfs interface for below > purposes: > - Register access > - Set shutdown scope > - Set boot health status bit This series defeats the whole abstraction EEMI provides. By providing direct register accesses, you are allowing user-space to do whatever it wants. I had NACKed this idea before. Has anything changed ? If you need it for testing firmware, better put them in debugfs which is off on production builds. -- Regards, Sudeep _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel