From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BFD38C43603 for ; Fri, 20 Dec 2019 00:01:15 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 91A1E222C2 for ; Fri, 20 Dec 2019 00:01:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="UftmzVaw" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 91A1E222C2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=PCihIxEHfHfsVKXz5N5OJsiK2bLzCL7yCKaghAuBO7M=; b=UftmzVawcKfl50 GIBK55eJyyIqLz+P5zUAUeJHrhhdXsjE5gUSr30tWFrLuF4aotMvN3gD8DMV78XDz7f9LQO8CwB6R gfEvIvXIKdntM5/au14Bu79jklsURVXtazdy+a4aqqhItgwIMK93622R6rLVU69CexCQ80vDdA9CD A8vG3OLoKkfYhSMbX83VUhKvBHGJyR9Gg4sedJv5LIkj8D2RkfdvbcfAzXI9Od8x5ev9FEwdRnS1Y ybJuilY8VMw/cEOpGXw8+vOaHVdz24hu1BK7JxcM+NXHxMwKUU/eqRIO9jnSGeHrRBOeznKnpP7xs qAslRWxWApXCXJtnxlPA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1ii5j8-0001nf-Jx; Fri, 20 Dec 2019 00:01:06 +0000 Received: from mail-ot1-f68.google.com ([209.85.210.68]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1ii5j5-0001n1-8H for linux-arm-kernel@lists.infradead.org; Fri, 20 Dec 2019 00:01:04 +0000 Received: by mail-ot1-f68.google.com with SMTP id c22so9380099otj.13 for ; Thu, 19 Dec 2019 16:01:03 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=ixxxBsIzEckZyMKz6FP9blKKJXoRngv5HsAGvReLZD4=; b=b3sNR3JM2PnCxL6bgl3odlJ9zbdWwdsRSWrgoWF5ci+TfBA01iCPAZbifp4fP/Ox3L vlWdG/5zoMPKapsvPUhXGFu5KuHuSqFDGLYAGKySLvJVEhT7wz7jVTH2HvsPqh4oGJSb wRZp4R5lveLUBxG48CZU7W8yCO6TQoOlVhH8s+Z04Uv1Uah2Q9Ix7FkhMlJ5bMQJ4wGA vtHl87lm8Ix0yudqfcvcddIfawMzsT5dc4qoF55tHbo533ZkI0trjxjIHdlsr0pdupqc 9OIfYWJChsQduQmwzySCua8ASkLkwZk4jrWxNn/35Qy0sUeqxzdSeXhbH2p+KnCr/7vf EqcA== X-Gm-Message-State: APjAAAUnit0mmjJDAgcwbrLcmtz0oXsH2gCRO+u/Lz/UmHVi4z69evE1 Lasd1XJsNBXdcVx05MFnbQ== X-Google-Smtp-Source: APXvYqzEJwtRPN0UXZ/xR2ptdwnUmxXBKOPtOTRVoyqaKCSz+7WnsyzpWFMgdicP0Vvzr157+uUKXg== X-Received: by 2002:a9d:6a5a:: with SMTP id h26mr11893681otn.103.1576800062626; Thu, 19 Dec 2019 16:01:02 -0800 (PST) Received: from localhost (ip-184-205-174-147.ftwttx.spcsdns.net. [184.205.174.147]) by smtp.gmail.com with ESMTPSA id l128sm2541590oif.55.2019.12.19.16.01.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Dec 2019 16:01:02 -0800 (PST) Date: Thu, 19 Dec 2019 18:01:01 -0600 From: Rob Herring To: Andrew Jeffery Subject: Re: [PATCH v2 1/3] dt-bindings: ipmi: aspeed: Introduce a v2 binding for KCS Message-ID: <20191220000101.GA16104@bogus> References: <8aec8994bbe1186d257b0a712e13cf914c5ebe35.1576462051.git-series.andrew@aj.id.au> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <8aec8994bbe1186d257b0a712e13cf914c5ebe35.1576462051.git-series.andrew@aj.id.au> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191219_160103_294818_6D4FF347 X-CRM114-Status: GOOD ( 17.02 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, devicetree@vger.kernel.org, minyard@acm.org, arnd@arndb.de, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, linux-aspeed@lists.ozlabs.org, robh+dt@kernel.org, joel@jms.id.au, openipmi-developer@lists.sourceforge.net, haiyue.wang@linux.intel.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, 16 Dec 2019 12:57:40 +1030, Andrew Jeffery wrote: > The v2 binding utilises reg and renames some of the v1 properties. > > Signed-off-by: Andrew Jeffery > --- > v2: Rename slave-reg to aspeed,lpc-io-reg > > Rob: After our discussion about the name of 'slave-reg' on v1 I've thought > about it some more and have landed on aspeed,lpc-io-reg. In v1 I argued that > the name should be generic and you suggested that if so it should go in a > generic binding document - I've thought about this some more and concluded that > it was hard to pin down exactly where it should be documented if it were > generic (the generic ASPEED LPC binding is one place, but that would suggest > that the property is still ASPEED-specific; maybe some discussion with > Nuvoton might give some insight). > > Regardless, it turns out that the address specification is really > ASPEED-specific in this case: The KCS host interface in the LPC IO space > consists of a data and status register, but the slave controller infers the > address of the second from the address of the first and thus only the address > of the first can be programmed on the BMC-side. ASPEED supply documentation > that maps the LPC-side register layout for given LPC IO base addresses. I think > this is esoteric enough to warrant the aspeed prefix. > > Documentation/devicetree/bindings/ipmi/aspeed-kcs-bmc.txt | 20 +++++--- > 1 file changed, 14 insertions(+), 6 deletions(-) > Reviewed-by: Rob Herring _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel