From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 48689C43603 for ; Fri, 20 Dec 2019 08:32:25 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1E8D5227BF for ; Fri, 20 Dec 2019 08:32:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="DHw1R6zA"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="EHVWANNv" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1E8D5227BF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=gfsKwlfnsyZMh4NwJTXow2v31rzn2bdaFx1YSRYnXGQ=; b=DHw1R6zAc55g9B beqalS0lXEiAFKsHDbxw64TotQTV/c4y18aMFT7JmA/V0Hp0T45x5PEmF8WTNXDEudj2b/wYdlA9A pIt580J4JRgwXNUQrYYpRIEfZhDI6LwMAiRlehqCjaAV+/ofeOWfpPxHjT31fRhqrUPgTfwKrgkD1 k1LtoVWSpQvYzMQHnQhrODeaoKVIiZQhfUywoAxeMKHPAtqY1nIAZiabJFgBlWGYUw9J9TEuUg1LT caRZDbaLTO6Ubsv5JL+BoL6GHjjQJoFDJSwnsVBLBUBT61OZUHHksvtUwfYEXnmmhlI28C4/oeURO NWWGLSl+Kwa7Vsb+RLfw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iiDhw-0005Ra-Lk; Fri, 20 Dec 2019 08:32:24 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iiDhu-0005RF-6Z for linux-arm-kernel@lists.infradead.org; Fri, 20 Dec 2019 08:32:23 +0000 Received: from localhost (unknown [106.201.107.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E99F1227BF; Fri, 20 Dec 2019 08:32:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1576830741; bh=hBWzx2yIsLDhvkyJawI2ZCRbOghi05yT23MBgF01k/g=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=EHVWANNvlC3Dk/sWI4RHpbbVPN5qlthby8A4ORphYODzu08WzIloK8ma7wKqJ55P4 M6vFsWoHicY+3Inil6sSALU5DspaucNFJ0ihPIpmuU49+pGZ8o/7ibrWK0+EaHxiFL UdiTJJIuNap/BD3JY06DG6MEBMy57lU3oGsPjtFc= Date: Fri, 20 Dec 2019 14:02:16 +0530 From: Vinod Koul To: Peter Ujfalusi Subject: Re: [PATCH v7 04/12] dmaengine: Add metadata_ops for dma_async_tx_descriptor Message-ID: <20191220083216.GK2536@vkoul-mobl> References: <20191209094332.4047-1-peter.ujfalusi@ti.com> <20191209094332.4047-5-peter.ujfalusi@ti.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20191209094332.4047-5-peter.ujfalusi@ti.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191220_003222_262577_95FB9B29 X-CRM114-Status: UNSURE ( 7.82 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: nm@ti.com, devicetree@vger.kernel.org, grygorii.strashko@ti.com, vigneshr@ti.com, lokeshvutla@ti.com, j-keerthy@ti.com, linux-kernel@vger.kernel.org, t-kristo@ti.com, tony@atomide.com, robh+dt@kernel.org, ssantosh@kernel.org, dmaengine@vger.kernel.org, dan.j.williams@intel.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Peter, On 09-12-19, 11:43, Peter Ujfalusi wrote: > +int dmaengine_desc_attach_metadata(struct dma_async_tx_descriptor *desc, > + void *data, size_t len) > +{ > + int ret; > + > + if (!desc) > + return -EINVAL; > + > + ret = desc_check_and_set_metadata_mode(desc, DESC_METADATA_CLIENT); > + if (ret) > + return ret; > + > + if (!desc->metadata_ops || !desc->metadata_ops->attach) > + return -ENOTSUPP; > + > + return desc->metadata_ops->attach(desc, data, len); this looks good to me, only thing is we should check if people are mixing the modes :) -- ~Vinod _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel