Re: [PATCH 12/14] dmaengine: ti: omap-dma: Use cpu notifier to block idle for omap2

Vinod Koul
2019-12-23T07:47:50Z

On 16-12-19, 16:27, Tony Lindgren wrote:
> * Tony Lindgren <tony@atomide.com> [191217 00:20]:
> > diff --git a/drivers/dma/ti/omap-dma.c b/drivers/dma/ti/omap-dma.c
> > --- a/drivers/dma/ti/omap-dma.c
> > +++ b/drivers/dma/ti/omap-dma.c
> > + case CPU_CLUSTER_PM_ENTER:
> > + while (1) {
> > + lch = find_next_bit(od->lch_bitmap, od->lch_count,
> > + lch + 1);
> > + if (lch >= od->lch_count)
> > + break;
> > + c = od->lch_map[lch];
> > + if (!c)
> > + continue;
> > + if (omap_dma_chan_read(c, CCR) & CCR_ENABLE) {
> > + pr_info("XXX %s: lch%i busy\n", __func__, lch);
> > + return NOTIFY_BAD;
>
> Oops the pr_info line here can be dropped :)

feel free to add my after after fixing :)

Acked-by: Vinod Koul <vkoul@kernel.org>

--
~Vinod