From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EDD55C2D0CF for ; Mon, 23 Dec 2019 15:42:45 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C0A3E2073A for ; Mon, 23 Dec 2019 15:42:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="S/sALnMj"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="s//tC+nT" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C0A3E2073A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=i46u/mL1qG0zG1PDkXgJSaQlybrYJQMv/3NN0Ynsc/s=; b=S/sALnMj88xZlQ CUkGcndeiWwCWq5eUXTmEmZ5erj6F3xc4hk3JafHNF+vTtet1kVZGus079Sw3IGhhjEtSuTEZzjPO lXHAk6Fd2LBFf91LrSXDeQNGl9nuIFQhOfZSk/82eNBLxn+5tKSGvocAEjV/tSkp2jra0sijt1B+E kwArEL9HlhSMQqoZACalVcwjRFEWx6500iT7QIlaJYFXI+/8AZEZ62BvjRb90E8NuLy+gDEMQodGX eKy7y9d7hH8WW1F7pz1bj7FnEUTswpwjhvuFjHlBcBJp+391fknLKNajWUE0vmcETJUD5CskTGWEJ yw+TceZqr3i5zKYa/E2g==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1ijPqw-0005bn-8K; Mon, 23 Dec 2019 15:42:38 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1ijPqt-0005bM-L4 for linux-arm-kernel@lists.infradead.org; Mon, 23 Dec 2019 15:42:36 +0000 Received: from archlinux (cpc149474-cmbg20-2-0-cust94.5-4.cable.virginm.net [82.4.196.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 3BE0520409; Mon, 23 Dec 2019 15:42:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1577115754; bh=W7dVTbz3atfdVAhEErfOc/0Hk/lMKKZVb4bYQnWDj2A=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=s//tC+nTdBusmIDHh3w/JHuWKUr8WZVN0KLC+5/wqYR78n9MAxMnp6XKUU4AC657c U14znr1zujKNxf6wQUO+8FMnp7RkFlmi3LhRux36l3jmUeE1S5MfamQvscwQPE3N9f V1cD1j/T75J6/4t7OPNogFXjcHgnMBW3Nc+c3bpQ= Date: Mon, 23 Dec 2019 15:42:30 +0000 From: Jonathan Cameron To: Peter Ujfalusi Subject: Re: [PATCH] iio: adc: stm32-adc: Use dma_request_chan() instead dma_request_slave_channel() Message-ID: <20191223154230.7fb2a988@archlinux> In-Reply-To: <20191217075153.23766-1-peter.ujfalusi@ti.com> References: <20191217075153.23766-1-peter.ujfalusi@ti.com> X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191223_074235_711374_FF9B95C0 X-CRM114-Status: GOOD ( 16.39 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alexandre.torgue@st.com, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, vkoul@kernel.org, mcoquelin.stm32@gmail.com, Fabrice Gasnier , linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, 17 Dec 2019 09:51:53 +0200 Peter Ujfalusi wrote: > dma_request_slave_channel() is a wrapper on top of dma_request_chan() > eating up the error code. > > By using dma_request_chan() directly the driver can support deferred > probing against DMA. > > Signed-off-by: Peter Ujfalusi Hi Peter, Change looks sensible to me, but I'd like to leave a little longer for others to look at this. Give me a poke if I seem to have lost it by the end of the first week in Jan. Thanks, Jonathan > --- > drivers/iio/adc/stm32-adc.c | 10 ++++++++-- > 1 file changed, 8 insertions(+), 2 deletions(-) > > diff --git a/drivers/iio/adc/stm32-adc.c b/drivers/iio/adc/stm32-adc.c > index 3b291d72701c..5dab23f1fdee 100644 > --- a/drivers/iio/adc/stm32-adc.c > +++ b/drivers/iio/adc/stm32-adc.c > @@ -1746,9 +1746,15 @@ static int stm32_adc_dma_request(struct iio_dev *indio_dev) > struct dma_slave_config config; > int ret; > > - adc->dma_chan = dma_request_slave_channel(&indio_dev->dev, "rx"); > - if (!adc->dma_chan) > + adc->dma_chan = dma_request_chan(&indio_dev->dev, "rx"); > + if (IS_ERR(adc->dma_chan)) { > + if (PTR_ERR(adc->dma_chan) == -EPROBE_DEFER) > + return -EPROBE_DEFER; > + > + /* Ignore errors to fall back to IRQ mode */ > + adc->dma_chan = NULL; > return 0; > + } > > adc->rx_buf = dma_alloc_coherent(adc->dma_chan->device->dev, > STM32_DMA_BUFFER_SIZE, _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel