From: Tony Lindgren <tony@atomide.com>
To: "André Hentschel" <nerv@dawncrow.de>
Cc: mark.rutland@arm.com, devicetree@vger.kernel.org,
linux@arm.linux.org.uk, webmaster@dawncrow.de,
linux-kernel@vger.kernel.org, robh+dt@kernel.org,
bcousson@baylibre.com, linux-omap@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] ARM: dts: Add omap3-echo
Date: Tue, 24 Dec 2019 10:45:03 -0800 [thread overview]
Message-ID: <20191224184503.GK35479@atomide.com> (raw)
In-Reply-To: <20191224161005.28083-1-nerv@dawncrow.de>
* André Hentschel <nerv@dawncrow.de> [191224 16:11]:
> This is the first generation Amazon Echo from 2016.
> Audio support is not yet implemented.
OK looks good to me, just worried about one part:
> +&sgx_module {
> + status = "disabled";
> +};
We should have a separate am3703.dtsi or whatever the SoC model
disabling sgx if not there on the SoC. That way board specific
dts files can just include it without having to debug this issue
over and over.
Regards,
Tony
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-12-24 18:45 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-24 16:10 [PATCH] ARM: dts: Add omap3-echo André Hentschel
2019-12-24 18:45 ` Tony Lindgren [this message]
2019-12-25 12:05 ` André Hentschel
2019-12-25 12:53 ` Adam Ford
2019-12-25 17:01 ` H. Nikolaus Schaller
2019-12-27 14:28 ` André Hentschel
2019-12-30 17:29 ` Tony Lindgren
2019-12-30 20:22 ` André Hentschel
2019-12-31 8:14 ` H. Nikolaus Schaller
2020-01-02 19:51 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191224184503.GK35479@atomide.com \
--to=tony@atomide.com \
--cc=bcousson@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mark.rutland@arm.com \
--cc=nerv@dawncrow.de \
--cc=robh+dt@kernel.org \
--cc=webmaster@dawncrow.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).