linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Yangtao Li <tiny.windzz@gmail.com>
Cc: thierry.reding@gmail.com, f.fainelli@gmail.com,
	alexandre.torgue@st.com, sbranden@broadcom.com,
	rjui@broadcom.com, linux-arm-msm@vger.kernel.org,
	jassisinghbrar@gmail.com, linux-mediatek@lists.infradead.org,
	linux-kernel@vger.kernel.org, jonathanh@nvidia.com,
	linux-tegra@vger.kernel.org, agross@kernel.org,
	bcm-kernel-feedback-list@broadcom.com,
	linux-rpi-kernel@lists.infradead.org, mcoquelin.stm32@gmail.com,
	nios2-dev@lists.rocketboards.org, matthias.bgg@gmail.com,
	lftan@altera.com, linux-stm32@st-md-mailman.stormreply.com,
	nsaenzjulienne@suse.de, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 03/13] mailbox: qcom-apcs: convert to devm_platform_ioremap_resource
Date: Sat, 28 Dec 2019 17:59:04 -0800	[thread overview]
Message-ID: <20191229015904.GG3755841@builder> (raw)
In-Reply-To: <20191228183538.26189-3-tiny.windzz@gmail.com>

On Sat 28 Dec 10:35 PST 2019, Yangtao Li wrote:

> Use devm_platform_ioremap_resource() to simplify code.
> 
> Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>

Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>

> ---
>  drivers/mailbox/qcom-apcs-ipc-mailbox.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/mailbox/qcom-apcs-ipc-mailbox.c b/drivers/mailbox/qcom-apcs-ipc-mailbox.c
> index eeebafd546e5..0faf69137780 100644
> --- a/drivers/mailbox/qcom-apcs-ipc-mailbox.c
> +++ b/drivers/mailbox/qcom-apcs-ipc-mailbox.c
> @@ -49,7 +49,6 @@ static int qcom_apcs_ipc_probe(struct platform_device *pdev)
>  {
>  	struct qcom_apcs_ipc *apcs;
>  	struct regmap *regmap;
> -	struct resource *res;
>  	unsigned long offset;
>  	void __iomem *base;
>  	unsigned long i;
> @@ -64,8 +63,7 @@ static int qcom_apcs_ipc_probe(struct platform_device *pdev)
>  	if (!apcs)
>  		return -ENOMEM;
>  
> -	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> -	base = devm_ioremap_resource(&pdev->dev, res);
> +	base = devm_platform_ioremap_resource(pdev, 0);
>  	if (IS_ERR(base))
>  		return PTR_ERR(base);
>  
> -- 
> 2.17.1
> 

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2019-12-29  1:59 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-28 18:35 [PATCH 01/13] mailbox: altera: convert to devm_platform_ioremap_resource Yangtao Li
2019-12-28 18:35 ` [PATCH 02/13] mailbox: xgene-slimpro: do some cleanup Yangtao Li
2019-12-28 18:35 ` [PATCH 03/13] mailbox: qcom-apcs: convert to devm_platform_ioremap_resource Yangtao Li
2019-12-29  1:59   ` Bjorn Andersson [this message]
2019-12-28 18:35 ` [PATCH 04/13] mailbox: mediatek: cmdq: " Yangtao Li
2019-12-30  1:58   ` CK Hu
2019-12-28 18:35 ` [PATCH 05/13] mailbox: bcm2835: " Yangtao Li
2020-01-07 10:57   ` Nicolas Saenz Julienne
2019-12-28 18:35 ` [PATCH 06/13] mailbox: hi3660: " Yangtao Li
2019-12-30  1:04   ` Leo Yan
2019-12-28 18:35 ` [PATCH 07/13] mailbox: platform-mhu: " Yangtao Li
2019-12-28 18:35 ` [PATCH 08/13] mailbox: stm32-ipcc: " Yangtao Li
2019-12-28 18:35 ` [PATCH 09/13] mailbox: sti: do some cleanup Yangtao Li
2019-12-28 18:35 ` [PATCH 10/13] mailbox: tegra: convert to devm_platform_ioremap_resource Yangtao Li
2019-12-28 18:35 ` [PATCH 11/13] mailbox: hi6220: " Yangtao Li
2019-12-28 18:35 ` [PATCH 12/13] mailbox: omap: do some cleanup Yangtao Li
2019-12-28 18:35 ` [PATCH 13/13] mailbox: armada-37xx-rwtm: convert to devm_platform_ioremap_resource Yangtao Li
2020-01-08  9:43   ` Gregory CLEMENT
2019-12-30  1:50 ` [PATCH 01/13] mailbox: altera: " Tan, Ley Foon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191229015904.GG3755841@builder \
    --to=bjorn.andersson@linaro.org \
    --cc=agross@kernel.org \
    --cc=alexandre.torgue@st.com \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=f.fainelli@gmail.com \
    --cc=jassisinghbrar@gmail.com \
    --cc=jonathanh@nvidia.com \
    --cc=lftan@altera.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=linux-rpi-kernel@lists.infradead.org \
    --cc=linux-stm32@st-md-mailman.stormreply.com \
    --cc=linux-tegra@vger.kernel.org \
    --cc=matthias.bgg@gmail.com \
    --cc=mcoquelin.stm32@gmail.com \
    --cc=nios2-dev@lists.rocketboards.org \
    --cc=nsaenzjulienne@suse.de \
    --cc=rjui@broadcom.com \
    --cc=sbranden@broadcom.com \
    --cc=thierry.reding@gmail.com \
    --cc=tiny.windzz@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).