From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3483AC54E64 for ; Mon, 25 Mar 2024 19:43:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=fAJnBCj0QYbM7lcLVRzteRcIqam0Nq3t8qm18sL4bO4=; b=a2LwoL2yHa+fWC n9Cgcul+9WewKtLmwnsQ+LSkUbnyRM0nQYEHiUlWIfppEdmOcnuKN5ynv68DznLNf+xxIOYfpooHs F/9whVC9RStR0DP0WSi3+/y7cn6tKMyVd7DIGX+KAhEbi/8lC0GdlW9xq/kFaPKNSCVbN98AlU2+A CByjMiYKEF7SeGBsbS9Lm1HoWbSnzATWKgIy300Fk8GAenYZemaJgXAnj2WqkNm0jdsbbs1jo+4YL sfg71QX4zwL6S+JRgwUL3JAfVyq4gR7ICAb20/AppOZshzFyLrixotAOa13fFSi7XA5nYNZWvPzEE DyX9AzwomOSuJhyqRbHQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1roqDV-00000001eS4-23Az; Mon, 25 Mar 2024 19:42:45 +0000 Received: from mail-ed1-x52b.google.com ([2a00:1450:4864:20::52b]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1roqDS-00000001eQS-0GQ2 for linux-arm-kernel@lists.infradead.org; Mon, 25 Mar 2024 19:42:43 +0000 Received: by mail-ed1-x52b.google.com with SMTP id 4fb4d7f45d1cf-566e869f631so5090837a12.0 for ; Mon, 25 Mar 2024 12:42:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1711395759; x=1712000559; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=KuzOZKWfexqxW20YM2/HIeua9/M06pZ/a0UxyioS85Q=; b=PYmS2AxZCrvYBPhSqBXAWXFcDBbhM2Q831Op+I+qnwJpUfPHinclCX6sm98qJGTl9s hDlqtI4NRaTtKdG5TfJelnfMCixDoA+beDYRr2j48P4TzHxVgzu2fxjL0LFY9e55KN6A BoSG9aXQ8yQlzqP00NC+evK/WJDl2sIFDCBUUmbMMAcTUt6oXm15NbmJxX39k6S8onxP EjWf/rGy0rUBQIw3+rEhKv5Jx4Q9mJlMCHaN3vWnZJQU3QW2AS9aYJ7xsg1mcerVVD6B wPp0/YfCrbJJstOEa0yDZn/NnBvSBP26cYkR27SRCOC1tq0OBucV3Q+lI87tVcdSxTEF EPsg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711395759; x=1712000559; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=KuzOZKWfexqxW20YM2/HIeua9/M06pZ/a0UxyioS85Q=; b=orfScHbjV0nTSGSObx05sSiS3+c3JTcx4PR6h2XzgUBHNYaEOeu6Hv9kU5eIiZmp/H ptbLqQNS9UwoqGnZD/H8SyAjtSrdPjyJ48/wlFvF9P+alV6ixZqjCM+PqDKiUxTnEnD8 9fA2afLjguqStvbt6pEpU5LOfAF/phY41L58w1+X/M4yHETBpp7tXdfdb7KYO3xWyU0i FRuMgSQS1MxET+8pwXPIokqcGFDnozDqVaN1BOtp1HSvZwtZJsQPKkYcogzPujUuLGvl kZdUQu5bM9xKW0YRLyYjp6gIUT7RCoDqx/AZ8lzwso4N6WwbyBmXkjMUmzgxGwpGpXrc lbBw== X-Forwarded-Encrypted: i=1; AJvYcCVZlxO+CGDTxwVF1PNrwGYo1GhqvcmoaN/CwVWtT9cDJSO2nMPrQuemlGG0W24NdYiKPHjumY2GyfT4t1syG4bcTs+xnBiRru8EdU9PqTKPPGdI9SU= X-Gm-Message-State: AOJu0Yy5RHRugCC+VAv7ljk/olpHbPuK65LKaCKrqX5Fl1UAV2I8asdx Hxt6f52zZKbhLJ/QRuVs0DcVT1veQbBxa79uBZnf6EvX4pTTOEq5Scch5gg+G1c= X-Google-Smtp-Source: AGHT+IHJIy9p7akZElmhV942HZMfhlm4dCbkmPK86uIB7i5F9c7KRMFn/SQ4Eba22ZuVgffwIIA3og== X-Received: by 2002:a50:c357:0:b0:56c:1884:90cb with SMTP id q23-20020a50c357000000b0056c188490cbmr1784534edb.5.1711395759202; Mon, 25 Mar 2024 12:42:39 -0700 (PDT) Received: from localhost ([102.222.70.76]) by smtp.gmail.com with ESMTPSA id cn28-20020a0564020cbc00b0056bf2e2c898sm3307359edb.1.2024.03.25.12.42.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Mar 2024 12:42:38 -0700 (PDT) Date: Mon, 25 Mar 2024 22:42:35 +0300 From: Dan Carpenter To: Greg KH Cc: Prasad Pandit , florian.fainelli@broadcom.com, bcm-kernel-feedback-list@broadcom.com, linux-arm-kernel@lists.infradead.org, rjui@broadcom.com, sbranden@broadcom.com, linux-staging@lists.linux.dev, linux-rpi-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Prasad Pandit Subject: Re: [PATCH v3] staging: bcm2835-audio: add terminating new line to Kconfig Message-ID: <201b6c82-1ebf-4dc2-9221-4fc87d1dd565@moroto.mountain> References: <20240313114126.1418453-1-ppandit@redhat.com> <2024032540-scrubbed-reluctant-8860@gregkh> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <2024032540-scrubbed-reluctant-8860@gregkh> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240325_124242_171327_F889DB15 X-CRM114-Status: GOOD ( 17.74 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Mar 25, 2024 at 07:04:15PM +0100, Greg KH wrote: > On Wed, Mar 13, 2024 at 05:11:26PM +0530, Prasad Pandit wrote: > > From: Prasad Pandit > > > > Add terminating new line to the Kconfig file. It helps > > Kconfig parsers to read file without error. > > What in-tree parser has a problem with this file as-is? If it's an > out-of-tree parser, that's different, and the tool should be fixed, no > need to touch the kernel files for no good reason. It's annoying to cat a file when it doesn't have a newline on the end... dcarpenter@moroto:~/progs/kernel/trees$ cat -n drivers/staging/vc04_services/bcm2835-audio/Kconfig 1 # SPDX-License-Identifier: GPL-2.0 2 config SND_BCM2835 3 tristate "BCM2835 Audio" 4 depends on (ARCH_BCM2835 || COMPILE_TEST) && SND 5 select SND_PCM 6 select BCM2835_VCHIQ if HAS_DMA 7 help 8 Say Y or M if you want to support BCM2835 built in audio. 9 This driver handles both 3.5mm and HDMI audio, by leveraging 10 the VCHIQ messaging interface between the kernel and the firmware 11 running on VideoCore.dcarpenter@moroto:~/progs/kernel/trees$ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ So you could resend with that as a justification. But, yeah, it's a good idea to fix the tool as well. regards, dan carpenter _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel