From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3ABF0C00523 for ; Fri, 3 Jan 2020 09:07:26 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0C46C22314 for ; Fri, 3 Jan 2020 09:07:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="OyOavdJ3" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0C46C22314 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=bK2ekY82fdlVVRgJ/GBnbjm31DiPhXXyrbk7WV+lThI=; b=OyOavdJ3+968jh MY864HAZFWeb2CZI7I+nNGYbt3vz7nE33B/UbqOdIox6r4iwEsGRw+11g8rF36LCrH8i9TZ1aGm1l FIN1b2OhjX22nU8mmKyoDAn0Lqfrz6tSXIBkn0aLrHO0nvOirRohSXVgA5D5YIRtjW+kXoIfTtgH2 t05e1zkgBER5yt2d4Lc5vUDBi91oHtfXQGk2G3vppxqW6Skv+PJ6hyoTkhem6VeQjeSkkhqHsk976 GMur0dkPgLhbajzXxts25Y9pACcOF4lLUoo70vo2z0sFfIpcrYamZFfpvAIISfQAf82FWmn7QWX0G 6mxQW+xW/WF2J0T8RwTg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1inIvV-0002EV-Hw; Fri, 03 Jan 2020 09:07:25 +0000 Received: from relay4-d.mail.gandi.net ([217.70.183.196]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1inIvR-0002Dm-4D; Fri, 03 Jan 2020 09:07:23 +0000 X-Originating-IP: 90.65.102.129 Received: from localhost (lfbn-lyo-1-1670-129.w90-65.abo.wanadoo.fr [90.65.102.129]) (Authenticated sender: alexandre.belloni@bootlin.com) by relay4-d.mail.gandi.net (Postfix) with ESMTPSA id 89633E000C; Fri, 3 Jan 2020 09:07:04 +0000 (UTC) Date: Fri, 3 Jan 2020 10:07:04 +0100 From: Alexandre Belloni To: Dmitry Torokhov Subject: Re: [PATCH] mtd: rawnand: atmel: switch to using devm_fwnode_gpiod_get() Message-ID: <20200103090704.GG3040@piout.net> References: <20200103012238.GA3648@dtor-ws> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200103012238.GA3648@dtor-ws> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200103_010721_303960_87A96CC6 X-CRM114-Status: GOOD ( 14.88 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Vignesh Raghavendra , Tudor Ambarus , Richard Weinberger , Boris Brezillon , linux-kernel@vger.kernel.org, Ludovic Desroches , linux-mtd@lists.infradead.org, Miquel Raynal , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, On 02/01/2020 17:22:38-0800, Dmitry Torokhov wrote: > devm_fwnode_get_index_gpiod_from_child() is going away as the name is > too unwieldy, let's switch to using the new devm_fwnode_gpiod_get(). > > Signed-off-by: Dmitry Torokhov > --- > drivers/mtd/nand/raw/atmel/nand-controller.c | 20 ++++++++++---------- > 1 file changed, 10 insertions(+), 10 deletions(-) > > diff --git a/drivers/mtd/nand/raw/atmel/nand-controller.c b/drivers/mtd/nand/raw/atmel/nand-controller.c > index 8d6be90a6fe8a..849bd5f16492d 100644 > --- a/drivers/mtd/nand/raw/atmel/nand-controller.c > +++ b/drivers/mtd/nand/raw/atmel/nand-controller.c > @@ -1578,9 +1578,8 @@ static struct atmel_nand *atmel_nand_create(struct atmel_nand_controller *nc, > > nand->numcs = numcs; > > - gpio = devm_fwnode_get_index_gpiod_from_child(nc->dev, "det", 0, > - &np->fwnode, GPIOD_IN, > - "nand-det"); > + gpio = devm_fwnode_gpiod_get(nc->dev, of_fwnode_hanlde(np), Shouldn't that be of_fwnode_handle(np)? > + "det", GPIOD_IN, "nand-det"); > if (IS_ERR(gpio) && PTR_ERR(gpio) != -ENOENT) { > dev_err(nc->dev, > "Failed to get detect gpio (err = %ld)\n", > @@ -1624,9 +1623,10 @@ static struct atmel_nand *atmel_nand_create(struct atmel_nand_controller *nc, > nand->cs[i].rb.type = ATMEL_NAND_NATIVE_RB; > nand->cs[i].rb.id = val; > } else { > - gpio = devm_fwnode_get_index_gpiod_from_child(nc->dev, > - "rb", i, &np->fwnode, > - GPIOD_IN, "nand-rb"); > + gpio = devm_fwnode_gpiod_get_index(nc->dev, > + of_fwnode_handle(np), > + "rb", i, GPIOD_IN, > + "nand-rb"); > if (IS_ERR(gpio) && PTR_ERR(gpio) != -ENOENT) { > dev_err(nc->dev, > "Failed to get R/B gpio (err = %ld)\n", > @@ -1640,10 +1640,10 @@ static struct atmel_nand *atmel_nand_create(struct atmel_nand_controller *nc, > } > } > > - gpio = devm_fwnode_get_index_gpiod_from_child(nc->dev, "cs", > - i, &np->fwnode, > - GPIOD_OUT_HIGH, > - "nand-cs"); > + gpio = devm_fwnode_gpiod_get_index(nc->dev, > + of_fwnode_handle(np), > + "cs", i, GPIOD_OUT_HIGH, > + "nand-cs"); > if (IS_ERR(gpio) && PTR_ERR(gpio) != -ENOENT) { > dev_err(nc->dev, > "Failed to get CS gpio (err = %ld)\n", > -- > 2.24.1.735.g03f4e72817-goog > > > -- > Dmitry -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel