From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 299D5C2D0C2 for ; Fri, 3 Jan 2020 11:17:15 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DF0562085B for ; Fri, 3 Jan 2020 11:17:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="RgoF9tud" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DF0562085B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=nr6kLfbCpYOrgiy2LDpqa5iAKoz7AegnmRuADznxEgk=; b=RgoF9tudFkw3pc +cA7tqW4QLaktnGhR/cFgD0z+941Hs51b6qN21X10i5vQf6E3oBRT+/Dd9Os+BPSbbiLDpCLJDuDO hQ8aLZ86UhaT7VG312XJz6NWJlNV1/r/OnQLDnbzoFwZque8C8wpryPTPIz+SQKQtauzPm5f/pZQO fMs9XU+3cZvqAfWrMIiwRiIkBS9Ovjg+EKJ3nGHjL7yOdjt0d41JV9GmYOQjGqn/lWtBkcdRd86df Mijd8gyFnboXFR/kxAk50ogR4sW8fetT1cmmbsMhtUkD77mwxvUdcrP+osyC5Uh6T2+QuN8UBRl9a x7p+g2CDlysEtVtT5q6w==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1inKx0-0005Kv-Gm; Fri, 03 Jan 2020 11:17:06 +0000 Received: from mail-ed1-f68.google.com ([209.85.208.68]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1inKwx-0005Jw-Qp for linux-arm-kernel@lists.infradead.org; Fri, 03 Jan 2020 11:17:05 +0000 Received: by mail-ed1-f68.google.com with SMTP id v28so41314586edw.12 for ; Fri, 03 Jan 2020 03:17:00 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=4Cz1bHF5KTHAkw4Fc68MgiqMwjrbDHHdLD3F5Ae3Ezo=; b=GRG/5RlhboPN2svVIURU0dLG89urKbDf/0bI0cD4PlHcxtRgWGKSHjEyBeQCUitV4X /T0ifdV54BX583y3XHCAmhQxwe915BIP3OxogYsldU+YFp8eaoJkXwcDKBMARVH4uYJj +frvAgNfnEIM7qcZ7oepcmRBcWottjHdSZa4CpA+Ug/FZ6NE8PhUbOCqw0mOvKLgX5PQ KPJe0aaIBFd6aXXOpejOjsS4J4OWNmzNDJngCfOnceXrAaMAGPLVfp6jPrn1Gz/dFGN7 I79J0IPT6I2rG3xCFaXX55w3yEPe3cYXA0kRTMmCmbLOJlHIlC1mVKE/taJx2JnabYlb ldmA== X-Gm-Message-State: APjAAAUXhIcPeq+fwYB3tRqi+Wth7jXOEMAoHzQY8BzknEq1G698gPQQ gpUO8pcmEfB3nv+yEJ6L6sc= X-Google-Smtp-Source: APXvYqwm0Aou1t/E4yDsF/8shNlUmMED7vothBxjbyR0PYteuXhZsEv8NzzR+qZMCInWvdpwvwuN7A== X-Received: by 2002:a17:906:a88e:: with SMTP id ha14mr91081234ejb.169.1578050218870; Fri, 03 Jan 2020 03:16:58 -0800 (PST) Received: from pi3 ([194.230.155.149]) by smtp.googlemail.com with ESMTPSA id y4sm7699793ejr.41.2020.01.03.03.16.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Jan 2020 03:16:58 -0800 (PST) Date: Fri, 3 Jan 2020 12:16:55 +0100 From: Krzysztof Kozlowski To: Benjamin GAIGNARD , "robh+dt@kernel.org" , "mark.rutland@arm.com" Subject: Re: [PATCH v2 2/2] ARM: dts: exynos: Remove unneeded "snps,dwc2" from hsotg node Message-ID: <20200103111655.GA1605@pi3> References: <20191219103536.25485-1-benjamin.gaignard@st.com> <20191219103536.25485-3-benjamin.gaignard@st.com> <20191230153758.GB4918@pi3> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200103_031703_869255_63571B61 X-CRM114-Status: GOOD ( 14.77 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "devicetree@vger.kernel.org" , Amelie DELAUNAY , "linux-samsung-soc@vger.kernel.org" , "gregkh@linuxfoundation.org" , "linux-usb@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "kgene@kernel.org" , "hminas@synopsys.com" , "linux-arm-kernel@lists.infradead.org" , "m.szyprowski@samsung.com" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Jan 02, 2020 at 08:50:39AM +0000, Benjamin GAIGNARD wrote: > > On 12/30/19 4:37 PM, Krzysztof Kozlowski wrote: > > On Thu, Dec 19, 2019 at 11:35:36AM +0100, Benjamin Gaignard wrote: > >> Remove "snps,dwc2" from hsotg@12480000 node compatible list because > >> "samsung,s3c6400-hsotg" should be enough. > > The more detailed compatible is almost always "enough". Some other nodes > > also have detailed+generic compatible. In this case there is a driver > > matching "snps,dwc2" so why removing it? > > First because, unlike the others dwc2 devices, this compatible wasn't > describe in the bindings file > > so I had to investigated how it should work and, on samsung DT files, > only "samsung,s3c6400-hsotg". > > From driver code point of view that seems coherent (we do the same for > stm32). > > With that in mind I have decided to remove "snps,dwc2" from exynos DT > file rather than add it everywhere else. > Actually fine with me, although I would be happy if Rob or Mark could confirm that it is a preferred approach. Rob, Mark, could you share your thoughts? Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel