From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B5BC1C2D0C2 for ; Sat, 4 Jan 2020 16:19:56 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8667F22B48 for ; Sat, 4 Jan 2020 16:19:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="lYgSGV9J"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="fHyNKqPI" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8667F22B48 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=hNb0oYdcvER0zlR5wN41TVraOFOVSucXMR7XxQWZFhU=; b=lYgSGV9J+Rt0Py 2eH2idrxlTI7nIArm8cruOT5lAtOSZK9q1NuQ9or852cbeTGut/em6adSicj20SQAaPsd3ascyYf7 KCU+2YyPolibM/4MSPNeeXRdRFQZND0O78raP77D22mk6g3nwPb+I2KvmDkZ4yi8e31qlBSGTZT0z u4Vo6D+SNiYgZeAxRqNkHGsVk6gxRqydue/MwOISXqKe4ILujPKLUHPDhnjl7JzRQXISemNoaPt7b sVjinZlk+576TTzrxgUvPeqSIW2g/MA+Ga3yL3eqfgkEXAJTbRRxNvabGb80pVRtHGjFelQrzdSPl pKrUW4rJOqBLlsUBXcMQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1inm9Z-0006W8-4K; Sat, 04 Jan 2020 16:19:53 +0000 Received: from mail-pj1-x1043.google.com ([2607:f8b0:4864:20::1043]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1inm9V-0006Vl-2Y for linux-arm-kernel@lists.infradead.org; Sat, 04 Jan 2020 16:19:51 +0000 Received: by mail-pj1-x1043.google.com with SMTP id s94so3465253pjc.1 for ; Sat, 04 Jan 2020 08:19:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=Hr6gRku33sKOdBDlVVDjuwq72fwx5PUhef2D4L3tjhk=; b=fHyNKqPId2hcNHM00cM3J/5Hw40VdqRg4zE09e2VypJvRMvD88lA5LCQGTcv21ap5L F1fY2eHj6girziJI6+YWCHWbQgHcD4l4NZ18VsufHnFrk13F+aYyh4J8hxVWHml0aACC bajiabLvqkRLpc6f99xuYRyemBFly+o2UwVN/N98r1JoYL2fZQlS3RjDvjgWXjV8vKqs 4PnyYwxECU8nhhVn0uYYudiVAcAzSmK/rRs6GXAOjVrLdCJn9U8GuV6KfMD2JutngGyX 8Svj9VjCibTPJ3pO5nFU2r2oNFvHFXKkFj554TcT6ANDpHGaAZkPF3XBTFyJImLVo7CQ AoHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=Hr6gRku33sKOdBDlVVDjuwq72fwx5PUhef2D4L3tjhk=; b=j8TwxCW+gruOLGx5BtnMQ0TUdufA7PuwG4Bd05YkT/Na4fRlWrVuy7ma9NVyOkpI/A 5ZFMDeyC70/CkoYutf4zeserHefuMuOShYGcSMmPWs9NGZIDE1gV9iqlEu7Iht3bJKHF DjcHm7NZgpO5AKUchFP3DTxgU7DQA7do3KPy3CEs1ww04Fa4b3+9z1B5+FL/Zy/3CZtm E2uP2kSYAB8+AIgWZ076NCElyAEmo7YiBFGaLNdZ8mQSl/Ygqyzr5qDhL2nyn/TtVwSZ F9/Zww2gMSpoyIGXfjrTypRPdzUwcSG6XHAGATTVZknq5drBhHh8dTCLwqcr03fOmNjl gtGA== X-Gm-Message-State: APjAAAWXNDl1bFs/kR1rt84uX3HDZLYk01K88V2gQxMZagMcCJ4e6q9m HgfxySLguP9TM82XsWsycUoYTlu/ X-Google-Smtp-Source: APXvYqy0JK3Q1yiH23rq1SeMoTgC8TBAei5Hnplpb4RKxhXr+8F817ZikIeiJACCMAPjwmWXOyAp+Q== X-Received: by 2002:a17:902:6b8c:: with SMTP id p12mr81709530plk.290.1578154788174; Sat, 04 Jan 2020 08:19:48 -0800 (PST) Received: from localhost ([2600:1700:e321:62f0:329c:23ff:fee3:9d7c]) by smtp.gmail.com with ESMTPSA id t65sm73026931pfd.178.2020.01.04.08.19.47 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 04 Jan 2020 08:19:47 -0800 (PST) Date: Sat, 4 Jan 2020 08:19:46 -0800 From: Guenter Roeck To: Sudeep Holla Subject: Re: [PATCH v2 10/11] hwmon: (scmi-hwmon) Match scmi device by both name and protocol id Message-ID: <20200104161946.GA2974@roeck-us.net> References: <20191218111742.29731-1-sudeep.holla@arm.com> <20191218111742.29731-11-sudeep.holla@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20191218111742.29731-11-sudeep.holla@arm.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200104_081949_118726_F8C4DB71 X-CRM114-Status: GOOD ( 21.14 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-hwmon@vger.kernel.org, Cristian Marussi , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Dec 18, 2019 at 11:17:41AM +0000, Sudeep Holla wrote: > The scmi bus now has support to match the driver with devices not only > based on their protocol id but also based on their device name if one is > available. This was added to cater the need to support multiple devices > and drivers for the same protocol. > > Let us add the name "hwmon" to scmi_device_id table in the driver so > that in matches only with device with the same name and protocol id > SCMI_PROTOCOL_SENSOR. This is just for sake of completion and must > not be used to add IIO support in parallel. Instead, if IIO support is > added ever in future, we need to drop this hwmon driver entirely and > use the iio->hwmon bridge to access the sensors as hwmon devices if > needed. > Acked-by: Guenter Roeck [ assuming the series will be pushed into the kernel together ] > Cc: Guenter Roeck > Cc: linux-hwmon@vger.kernel.org > Signed-off-by: Sudeep Holla > --- > drivers/hwmon/scmi-hwmon.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/hwmon/scmi-hwmon.c b/drivers/hwmon/scmi-hwmon.c > index 8a7732c0bef3..286d3cfda7de 100644 > --- a/drivers/hwmon/scmi-hwmon.c > +++ b/drivers/hwmon/scmi-hwmon.c > @@ -259,7 +259,7 @@ static int scmi_hwmon_probe(struct scmi_device *sdev) > } > > static const struct scmi_device_id scmi_id_table[] = { > - { SCMI_PROTOCOL_SENSOR }, > + { SCMI_PROTOCOL_SENSOR, "hwmon" }, > { }, > }; > MODULE_DEVICE_TABLE(scmi, scmi_id_table); _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel