From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B1184C33C8C for ; Sun, 5 Jan 2020 14:00:49 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 741AD207FD for ; Sun, 5 Jan 2020 14:00:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="OZkHYrC7"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b="Jz8gXJFX" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 741AD207FD Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=armlinux.org.uk Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=5q2+k0Rd2FEs5p/MIOEQ++d7kBVPfHC3G64R8XVqLd4=; b=OZkHYrC76Td9re 6kgZKMqTXHoJ+9pu80uzX4agZ9iKWfOA8Agjs3E+w3wdfaZ0vr1ydkpJ30EgJpMMVvlXtnu2GlZNw rGX7ZPaYvt1qRAZBHGGmL0t2ZLS7sx7Vh4mZaRNeh/DiyQmFSNXQXGyZy7eFXNuAeH3RNeJQ2ZUtm bjC2CMVfFHsroKJyruZAAVFy7wyaSSmC/WwLIWjmKyHJQ81eHbqUEHRIPcyH/SuEFmaEn17w0QuwR 72VQGIw8hbyXBR/wecpMby9Q0cdy10wOmbznkXmFj/ZcyQvoTZLA2Hd7bCbg5gznzqsdky4u++FSq VCiFNEguJ2qupiSH7Sag==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1io6SS-0008Sj-3G; Sun, 05 Jan 2020 14:00:44 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:3201:214:fdff:fe10:1be6]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1io6SO-0008Rv-K1 for linux-arm-kernel@lists.infradead.org; Sun, 05 Jan 2020 14:00:42 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=9/Ss68klY4YyT5Edf8xRawChy/z8+Io+mzqZfbggB1g=; b=Jz8gXJFXGS0RRZWop5wytUHcw 7F6A18F+QElbmdVrpPFeigxyFdEV43ijJy7hJnZuuVekyWiqwIlSJueWrL4lCHVbGtflxKLJSGWU/ YtrTNhh0lN5kFcYUFUz5+kcA65GxIGqtHR5RC2WYF6wwzfrMdwj25mk7cIOUx80YE6BlFwuk9RYQu MrK/rZsIJv5mywui6rvvWA2nGBE0LT5SSklmVGH5Uwveu1HnXR82bGtXQKB4TywwUCaGeXBc2K5nJ e/ZYMLcn09ejAqAdNPh1apAtRuzVd20kKwNoZLz/AgdwGAXL0zOzrsCuYSV8s2MuTIrn0vW2yyCWq MOAaJRRpQ==; Received: from shell.armlinux.org.uk ([2002:4e20:1eda:1:5054:ff:fe00:4ec]:58440) by pandora.armlinux.org.uk with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1io6S7-00069d-EX; Sun, 05 Jan 2020 14:00:23 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.92) (envelope-from ) id 1io6Ry-00057m-AP; Sun, 05 Jan 2020 14:00:14 +0000 Date: Sun, 5 Jan 2020 14:00:14 +0000 From: Russell King - ARM Linux admin To: hanterliu@gmail.com Subject: Re: [PATCH] ARM:alignment:correct variable type of nr_regs Message-ID: <20200105140014.GJ25745@shell.armlinux.org.uk> References: <1578190656-19270-1-git-send-email-hanterliu@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1578190656-19270-1-git-send-email-hanterliu@gmail.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200105_060040_806624_D85812D1 X-CRM114-Status: GOOD ( 14.56 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: hanter Liu , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sun, Jan 05, 2020 at 10:17:36AM +0800, hanterliu@gmail.com wrote: > From: hanter Liu > > if ldmstm instruction U bit is unset, nr_regs > should be negative value, so change variable > type of nr_regs from unsigned int to int. > > Signed-off-by: hanter Liu Hi, What observable bug is this fixing, or is this just a clean up? Please clarify. Thanks. > --- > arch/arm/mm/alignment.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/arch/arm/mm/alignment.c b/arch/arm/mm/alignment.c > index 788c5cf..d8e3bd9 100644 > --- a/arch/arm/mm/alignment.c > +++ b/arch/arm/mm/alignment.c > @@ -499,7 +499,8 @@ do_alignment_ldrstr(unsigned long addr, u32 instr, struct pt_regs *regs) > static int > do_alignment_ldmstm(unsigned long addr, u32 instr, struct pt_regs *regs) > { > - unsigned int rd, rn, correction, nr_regs, regbits; > + int nr_regs; > + unsigned int rd, rn, correction, regbits; > unsigned long eaddr, newaddr; > > if (LDM_S_BIT(instr)) > -- > 2.7.4 > > -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up According to speedtest.net: 11.9Mbps down 500kbps up _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel