From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 22499C00523 for ; Mon, 6 Jan 2020 03:00:52 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EE47621734 for ; Mon, 6 Jan 2020 03:00:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="guuA19RV"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="oJZCOjtC" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EE47621734 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Message-Id:Date:From:Subject:To: References:In-Reply-To:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=9yPHgvy8N7jg4KpqxuWWc/XAfd3xQz7jlMGH4/KdYNc=; b=guuA19RV7UU0fB 3uFTflQxKPUnwTKVEH8lo+SYOyPtf5X4LG2f9DVqbc339x6wucaXF+k5S/a0CPZUWPW8WnX0uEWmj eSYvoDn/ztz7JcsYQRv/uUrQs7mJ7T7D1oMcVeDRPJDj3wycTEkw+wU1qVwxphscpe50I/dKuzvcV H0+0PchqdQxiNksRTEitdghuUIp6rxUrRs4kYrIThNlf9wT8SEKic0D7UbuxJwqlQO0eecyXAELgH UiddeBbwzi7QaTd2R8QTyQyaVN4PUqeXisCxSB04Ihte7mu316+ysSZIJp4IKc5dIZRWFU7QPCzkS mr4zJRSzRrFDkc1bEIGg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1ioIdL-0005G3-O3; Mon, 06 Jan 2020 03:00:47 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1ioIdG-0005BV-TD for linux-arm-kernel@lists.infradead.org; Mon, 06 Jan 2020 03:00:44 +0000 Received: from kernel.org (unknown [104.132.0.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 774D8206F0; Mon, 6 Jan 2020 03:00:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1578279642; bh=8YANkl89iwxe3dndcojVuSNVMnw/MSIeyN/ppnKf2jk=; h=In-Reply-To:References:Cc:To:Subject:From:Date:From; b=oJZCOjtCELktDjSt6kYgGQPI3DEltjOBAg1lnsZdVUGN1I/FOOROK4fxBkX8dQx4j VkdfHRuvyP/HcLc+meedc2mcaYGW34OKvRwOpQlf+Efkl1CB6ZQrEgNCiSBXWwVfYJ Mr8dQBOTBJZZhTPijB9n4s5PDzg0Xz5VH68ONw9U= MIME-Version: 1.0 In-Reply-To: <1577412748-28213-1-git-send-email-Anson.Huang@nxp.com> References: <1577412748-28213-1-git-send-email-Anson.Huang@nxp.com> To: Anson Huang , abel.vesa@nxp.com, bjorn.andersson@linaro.org, catalin.marinas@arm.com, devicetree@vger.kernel.org, dinguyen@kernel.org, festevam@gmail.com, kernel@pengutronix.de, leonard.crestez@nxp.com, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, marcin.juszkiewicz@linaro.org, mark.rutland@arm.com, maxime@cerno.tech, mturquette@baylibre.com, olof@lixom.net, ping.bai@nxp.com, robh+dt@kernel.org, s.hauer@pengutronix.de, shawnguo@kernel.org, will@kernel.org Subject: Re: [PATCH 1/3] dt-bindings: imx: Add clock binding doc for i.MX8MP From: Stephen Boyd User-Agent: alot/0.8.1 Date: Sun, 05 Jan 2020 19:00:41 -0800 Message-Id: <20200106030042.774D8206F0@mail.kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200105_190042_994916_B706C56D X-CRM114-Status: GOOD ( 11.38 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Linux-imx@nxp.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Quoting Anson Huang (2019-12-26 18:12:26) > diff --git a/Documentation/devicetree/bindings/clock/imx8mp-clock.yaml b/Documentation/devicetree/bindings/clock/imx8mp-clock.yaml > new file mode 100644 > index 0000000..5e01995 > --- /dev/null > +++ b/Documentation/devicetree/bindings/clock/imx8mp-clock.yaml > @@ -0,0 +1,112 @@ > +# SPDX-License-Identifier: GPL-2.0 > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/bindings/clock/imx8mp-clock.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: NXP i.MX8M Plus Clock Control Module Binding > + > +maintainers: > + - Anson Huang > + > +description: | > + NXP i.MX8M Plus clock control module is an integrated clock controller, which > + generates and supplies to all modules. > + > +properties: > + compatible: > + const: fsl,imx8mp-ccm > + > + reg: > + maxItems: 1 > + > + clocks: > + items: > + - description: 32k osc > + - description: 24m osc > + - description: ext1 clock input > + - description: ext2 clock input > + - description: ext3 clock input > + - description: ext4 clock input > + > + clock-names: > + items: > + - const: osc_32k > + - const: osc_24m > + - const: clk_ext1 > + - const: clk_ext2 > + - const: clk_ext3 > + - const: clk_ext4 > + > + '#clock-cells': > + const: 1 > + description: | I think we can drop the bar here. Newlines shouldn't matter. > + The clock consumer should specify the desired clock by having the clock > + ID in its "clocks" phandle cell. See include/dt-bindings/clock/imx8mp-clock.h > + for the full list of i.MX8M Plus clock IDs. > + > +required: > + - compatible > + - reg > + - clocks > + - clock-names > + - '#clock-cells' > + > +examples: > + # Clock Control Module node: > + - | > + clk: clock-controller@30380000 { > + compatible = "fsl,imx8mp-ccm"; > + reg = <0x30380000 0x10000>; > + #clock-cells = <1>; > + clocks = <&osc_32k>, <&osc_24m>, <&clk_ext1>, > + <&clk_ext2>, <&clk_ext3>, <&clk_ext4>; > + clock-names = "osc_32k", "osc_24m", "clk_ext1", > + "clk_ext2", "clk_ext3", "clk_ext4"; > + }; > + > + # Required external clocks for Clock Control Module node: > + - | > + osc_32k: clock-osc-32k { > + compatible = "fixed-clock"; > + #clock-cells = <0>; > + clock-frequency = <32768>; > + clock-output-names = "osc_32k"; > + }; Do we need these in the example? They don't seem too useful. > + > + osc_24m: clock-osc-24m { > + compatible = "fixed-clock"; > + #clock-cells = <0>; > + clock-frequency = <24000000>; > + clock-output-names = "osc_24m"; > + }; > + > + clk_ext1: clock-ext1 { > + compatible = "fixed-clock"; > + #clock-cells = <0>; > + clock-frequency = <133000000>; _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel