From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CB8D7C33C8C for ; Mon, 6 Jan 2020 22:39:02 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9A189207FF for ; Mon, 6 Jan 2020 22:39:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="GQ6mbrw8"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="sP0b+kqI" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9A189207FF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=RU/DYQhepdwDd7IFBvjI1WZ5bX6igmJrM6WhL1kSpzQ=; b=GQ6mbrw84qyaZl bWGxj19UKz+xaPGBNqD1a0AKqngjxySUZ5BOdCXoRahqNBq2/QBQ6cPNQsnYekUKD/foTo0GaNHlk Ss9L4GgKdKhsAiw+4tMPcu5JaWA8o2Luu+Lsq+d2D1v1fwibeL7i8vxEQ4ExABFe6dKCOoCeXOlPF a/RG9Rfl2HDau/Gf/5QlzZ8za0ytInFSs06bxx8VojoUmeSuGhaq70s9SlS3i6qJFzP23QyhrfO70 6Ms4sX1RqGVbrgFJiCsj8OKDfbwRDSvJEkKPqMiCX7N/DDV1LXtV+Hiv4qyr9JoMKLoH/u14WX1hf B7NGEyqD7S8xinSZulCg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iob1R-0006Wd-Ty; Mon, 06 Jan 2020 22:38:53 +0000 Received: from mail-pf1-x444.google.com ([2607:f8b0:4864:20::444]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iob1P-0006Vr-GI for linux-arm-kernel@lists.infradead.org; Mon, 06 Jan 2020 22:38:52 +0000 Received: by mail-pf1-x444.google.com with SMTP id x184so27604124pfb.3 for ; Mon, 06 Jan 2020 14:38:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=S1FEEE6cCiUhglrJpwPJZH4zxshLjsGK5hYscNFBnAI=; b=sP0b+kqIgs0Wa01Ipe9vAxhjDci+QsIELt4Jxx3GKyj3kkoogjMroLTcTLoZGuzM06 mcW7i8waLEOVEIet/Ye76nn5octXd9nntk0g25HRxSNdHGDW1tnZ81JNY415TaFdos2D MCOZQJikcAznKooB1G+TpbIcS9Z3ly1lH8XjbpetKzLOxgmrQUxlJvp3oeKbRkD2mvmW oxQH7yi7x+Hs254uljZlC1GiLQ7ZmgeChjbceYlBRG2BP+qdI7p8836mThhJT3yqS0Vu Q4MZ1yyewwbfkq37wEuYjld1cm824RztHw9m3lh+uwzu7tFa8g0DYsDV397O4TmdAs/k 5CbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=S1FEEE6cCiUhglrJpwPJZH4zxshLjsGK5hYscNFBnAI=; b=QR+JUuiSZkTU8e2UQcjNcICnZnNny9wFMT7Ix/bNpBn99hdP7GaOj9s2IhmvXFK6g1 KM6wES8g69e5w6Qona0wpsaTjumPeo1K9lzPFz3sm0BxZw8a1V1o42e4+c1GwXD1Ijt5 Bq4pvtIGh3mKNHXlx7QQB2ABMytiRo7kKAsHty/Th526GfaiOgH7i+7jFQRYAO2KVnRC DRj3mTi7JMRSM4ZABnuDSVLHUFHhO4/aKNUNsJt9Sq2N+izsaW217i3foZmw+bq7bAH9 h5t9p0TMs/3psplNcmKv7LxWkHNejxNCu1cFCviWMKIZITWhl0Nwqyat1uvEP13gWzfO FM6w== X-Gm-Message-State: APjAAAWWUVQA7zi/WKHaQor4mhMNvs/JKbPglxVoo5/7iJIlsMsr7bWD x0NpZHhVZ4lt/PU5G4j8HOw= X-Google-Smtp-Source: APXvYqyYMmJhcA1k5o0TuMxSxjZ9wt+SVCos6N/y/ApdDFDvdAdsTi6M/W6N+SOmLCd5twlY4rfB9Q== X-Received: by 2002:a63:a508:: with SMTP id n8mr109588547pgf.278.1578350328970; Mon, 06 Jan 2020 14:38:48 -0800 (PST) Received: from dtor-ws ([2620:15c:202:201:3adc:b08c:7acc:b325]) by smtp.gmail.com with ESMTPSA id v8sm77416353pff.151.2020.01.06.14.38.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Jan 2020 14:38:48 -0800 (PST) Date: Mon, 6 Jan 2020 14:38:46 -0800 From: Dmitry Torokhov To: Greg Kroah-Hartman Subject: Re: [PATCH] tty: st-asc: switch to using devm_gpiod_get() Message-ID: <20200106223846.GH8314@dtor-ws> References: <20200104202314.GA13591@dtor-ws> <20200106185816.GA597279@kroah.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200106185816.GA597279@kroah.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200106_143851_572619_9AAC6AD2 X-CRM114-Status: GOOD ( 17.26 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, Patrice Chotard , linux-arm-kernel@lists.infradead.org, Jiri Slaby Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Jan 06, 2020 at 07:58:16PM +0100, Greg Kroah-Hartman wrote: > On Sat, Jan 04, 2020 at 12:23:14PM -0800, Dmitry Torokhov wrote: > > The node pointer in question is not a child node, but the node assigned > > to the port device itself, so we should not be using > > devm_fwnode_get_gpiod_from_child() [that is going away], but standard > > devm_gpiod_get(). > > > > To maintain the previous labeling we use gpiod_set_consumer_name() after > > we acquire the GPIO. > > > > Signed-off-by: Dmitry Torokhov > > --- > > drivers/tty/serial/st-asc.c | 12 +++++------- > > 1 file changed, 5 insertions(+), 7 deletions(-) > > What changed from v1 of this patch? Please put that below the --- line > and versino your patches. I did not add a version or changelog because I believe this is essentially a different patch, with different justification and different API that is being used. The first one was a simple switch to devm_fwnode_gpiod_get(), the new one is abandoning the use of explicit node reference, and instead uses standard devm_gpiod_get() to get a GPIO assigned to a device + gpiod_set_consumer_name() to maintain the naming. Thanks. -- Dmitry _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel