From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D08C6C00523 for ; Wed, 8 Jan 2020 07:59:43 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A2C2620678 for ; Wed, 8 Jan 2020 07:59:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="XmPC0v8S" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A2C2620678 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=iZY7reA+Rmy+wW60zkQeo4ZvEd1eFdQsgkSusmLkg2I=; b=XmPC0v8Sbrpq5d 7izCoEQYF4DSB9qs9RV/HHISZPgSEoWi7rX1p6stI6dOWrPuJhNFugqFYp1W9/Q2cjkaEaTlDg0/o pIPzqnutuz+QK+jkjhpeoxexF85SH/jyCdZ6VaOOnm9uNXOja44F3u5+Qvlre91vcHDA+Kj4rV86y Bzj/juXrtiRjYh7TtjW3dl1oKYjWOKFvXxE2fkqDfkC8PxslXQiyTI63tREDc+47TVQe/0RL6uU9c FpFb1xGs2Q1dm3SJJiZ8P3mJ6RBICg1EzAdHoSbhBQ/mBAJ/xAb6vvP/r6nYDECJPLR2Iv0cIq9+F 1NYpll8XelWw9ALtoYYw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1ip6Fe-0001Mc-3s; Wed, 08 Jan 2020 07:59:38 +0000 Received: from mail-ed1-f68.google.com ([209.85.208.68]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1ip6Fa-0001LP-PM for linux-arm-kernel@lists.infradead.org; Wed, 08 Jan 2020 07:59:36 +0000 Received: by mail-ed1-f68.google.com with SMTP id f8so1825923edv.2 for ; Tue, 07 Jan 2020 23:59:32 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=cMtj+4fElMhagL+EzReN9239oHGv4iNUyK/a8PqjjnQ=; b=Md+uAx/QYlMoM3LtWF1mk4cTlLep8uja7spOiyif+9lZSgDibYzoyzPnECz2HmDVph JttHsGh+xf69m3wc1vZTAHD0IJQ3dE5OPhT+9ZZRZAy2yo3uPeZmKHzVE6BIzr0jxTWM e7zsQ9qaseq7qgpFYywwrzUEPlIyMdrqGzCI/IcbSNoSoQKg5Pc0H134UkCvu5R2VUop hWkusPuTqCNrvYaKaEJ1epLUcJc6IwdUSrlMB98otzy97LDCwDuLTdNL1pn/NTurmnex EIoJGVRscMW8d7IXEk6xrh0ZJJ+fiMA89ZQuEM2Aec/8BRuQ3cSpv4Fht7hS+r4tlksx 7Duw== X-Gm-Message-State: APjAAAWEfx2ISo3Pc8fVooZyYskttej6B/PIH4PKs/wgEb3iZ2cIZN+w nvN8ThuBswZWd7dMImAr7Jc= X-Google-Smtp-Source: APXvYqx1oeIDihha1MbvAq15cZlBUGgIhGRDf0dk1K6ypd+mZhyiUjjB1ZsQjTlzbZgvEOTKZctg/A== X-Received: by 2002:a17:906:1d50:: with SMTP id o16mr3510203ejh.111.1578470371251; Tue, 07 Jan 2020 23:59:31 -0800 (PST) Received: from pi3 ([194.230.155.149]) by smtp.googlemail.com with ESMTPSA id bm18sm58278edb.97.2020.01.07.23.59.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Jan 2020 23:59:30 -0800 (PST) Date: Wed, 8 Jan 2020 08:59:28 +0100 From: Krzysztof Kozlowski To: Frank Lee Subject: Re: [PATCH 2/2] ARM: dts: exynos: tiny4412: add proper panel node Message-ID: <20200108075928.GA9911@pi3> References: <20200106191003.21584-1-tiny.windzz@gmail.com> <20200106191003.21584-2-tiny.windzz@gmail.com> <20200107090449.GA32007@pi3> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200107_235935_335310_42ED4E8A X-CRM114-Status: GOOD ( 20.95 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree , linux-samsung-soc , Linux Kernel Mailing List , Rob Herring , Kukjin Kim , Linux ARM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Jan 08, 2020 at 03:07:25AM +0800, Frank Lee wrote: > On Tue, Jan 7, 2020 at 5:04 PM Krzysztof Kozlowski wrote: > > > > On Mon, Jan 06, 2020 at 07:10:03PM +0000, Yangtao Li wrote: > > > This patch add at070tn92 panel for tiny4412 board. > > > > Please fix description as in patch 1. > > > > > > > > Signed-off-by: Yangtao Li > > > --- > > > arch/arm/boot/dts/exynos4412-tiny4412.dts | 16 ++++++++++++++++ > > > 1 file changed, 16 insertions(+) > > > > > > diff --git a/arch/arm/boot/dts/exynos4412-tiny4412.dts b/arch/arm/boot/dts/exynos4412-tiny4412.dts > > > index 2b62cb27420c..57f9d09233ad 100644 > > > --- a/arch/arm/boot/dts/exynos4412-tiny4412.dts > > > +++ b/arch/arm/boot/dts/exynos4412-tiny4412.dts > > > @@ -66,6 +66,16 @@ > > > clock-frequency = <24000000>; > > > }; > > > }; > > > + > > > + panel { > > > + compatible = "innolux,at070tn92"; > > > + > > > + port { > > > + panel_input: endpoint { > > > + remote-endpoint = <&lcdc_output>; > > > + }; > > > + }; > > > + }; > > > }; > > > > > > &fimd { > > > @@ -74,6 +84,12 @@ > > > #address-cells = <1>; > > > #size-cells = <0>; > > > status = "okay"; > > > > One empty space here. > > > > > + port@3 { > > > + reg = <3>; > > > > Why starting from "3"? Why this is port@3, not just "port"? > > From samsung-fimd.txt: > --- > The device node can contain 'port' child nodes according to the bindings defined > in [2]. The following are properties specific to those nodes: > - reg: (required) port index, can be: > 0 - for CAMIF0 input, > 1 - for CAMIF1 input, > 2 - for CAMIF2 input, > 3 - for parallel output, > 4 - for write-back interface > --- > > I guess it is influenced here. > https://elixir.bootlin.com/linux/v5.5-rc5/source/drivers/gpu/drm/exynos/exynos_drm_dpi.c#L170 > Without it, lcd is completely black. Thanks for explanation. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel