From: Mark Brown <broonie@kernel.org>
To: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: Mark Rutland <mark.rutland@arm.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Richard Henderson <richard.henderson@linaro.org>,
Will Deacon <will@kernel.org>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v8 3/3] arm64: Use v8.5-RNG entropy for KASLR seed
Date: Wed, 8 Jan 2020 17:44:21 +0000 [thread overview]
Message-ID: <20200108174421.GD4036@sirena.org.uk> (raw)
In-Reply-To: <CAKv+Gu9265OuGrkdH=Mp_Ef+6h5Y8mdvATd-TrTXN_wUawsUBA@mail.gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 485 bytes --]
On Wed, Jan 08, 2020 at 06:38:48PM +0100, Ard Biesheuvel wrote:
> On Tue, 7 Jan 2020 at 19:38, Mark Brown <broonie@kernel.org> wrote:
> > + if ((ftr >> ID_AA64ISAR0_RNDR_SHIFT) & 0xf) {
> > + if (__arm64_rndr(&raw))
> > + seed += raw;
> Using addition rather than xor to combine seeds is slightly
> unidiomatic, so if you are doing this for a specific reason, it would
> be good to mention it.
No particular reason.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2020-01-08 17:44 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-07 18:35 [PATCH v8 0/3] ARMv8.5-RNG support Mark Brown
2020-01-07 18:35 ` [PATCH v8 1/3] arm64: Implement archrandom.h for ARMv8.5-RNG Mark Brown
2020-01-08 17:18 ` Mark Rutland
2020-01-07 18:35 ` [PATCH v8 2/3] arm64: random: Add data to pool from setup_arch() Mark Brown
2020-01-08 17:20 ` Mark Rutland
2020-01-08 17:36 ` Mark Brown
2020-01-07 18:35 ` [PATCH v8 3/3] arm64: Use v8.5-RNG entropy for KASLR seed Mark Brown
2020-01-08 17:21 ` Mark Rutland
2020-01-08 17:38 ` Ard Biesheuvel
2020-01-08 17:44 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200108174421.GD4036@sirena.org.uk \
--to=broonie@kernel.org \
--cc=ard.biesheuvel@linaro.org \
--cc=catalin.marinas@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=richard.henderson@linaro.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox