From: Bjorn Helgaas <helgaas@kernel.org>
To: Gustavo Pimentel <Gustavo.Pimentel@synopsys.com>
Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
Zaihai Yu <yuzaihai@hisilicon.com>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
Pratyush Anand <pratyush.anand@gmail.com>,
Jingoo Han <jingoohan1@gmail.com>,
Shawn Guo <shawn.guo@linaro.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] PCI: dwc: Separate CFG0 and CFG1 into different ATU regions
Date: Thu, 9 Jan 2020 12:29:57 -0600 [thread overview]
Message-ID: <20200109182957.GA252973@google.com> (raw)
In-Reply-To: <CH2PR12MB4007CC62E0939BAAABA0E64FDA390@CH2PR12MB4007.namprd12.prod.outlook.com>
On Thu, Jan 09, 2020 at 12:24:17PM +0000, Gustavo Pimentel wrote:
> On Thu, Jan 9, 2020 at 11:14:58, Shawn Guo <shawn.guo@linaro.org> wrote:
>
> > Hi Gustavo,
> >
> > Thanks for taking a look.
> >
> > On Thu, Jan 09, 2020 at 10:37:14AM +0000, Gustavo Pimentel wrote:
> > > Hi Shawn,
> > >
> > > On Thu, Jan 9, 2020 at 6:6:57, Shawn Guo <shawn.guo@linaro.org> wrote:
> > >
> > > > Some platform has 4 (or more) viewports. In that case, CFG0 and CFG1
> > >
> > > Remove double space before "In that..."
> >
> > Hmm, that was intentional. My writing practice is using two spaces
> > after a period and single space after a comma. Is it a bad habit?
>
> I thought it was a typo. I personally don't have anything against it, but
> I didn't see this style on the comments till now. To keep the coherence
> between all patches, I know that Bjorn and Lorenzo like to have it the
> most standardized possible. It is OK by Lorenzo and Bjorn, it's fine for
> me too.
Eagle eyes! I was taught in the dark ages of typewriters to use two
spaces after a period, but I don't really care either way. If I
rework a commit log for other reasons I might use two spaces, and I
frequently use vim 'gq' to reformat paragraphs to use the whole line
width, and I think that inserts two spaces (by default), so I try to
be consistent at least within each commit log. But either is really
fine with me.
Thanks for taking the time to read and pay attention to commit logs!
Bjorn
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-01-09 18:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-09 6:06 [PATCH] PCI: dwc: Separate CFG0 and CFG1 into different ATU regions Shawn Guo
2020-01-09 10:37 ` Gustavo Pimentel
2020-01-09 11:14 ` Shawn Guo
2020-01-09 11:28 ` Russell King - ARM Linux admin
2020-01-09 12:24 ` Gustavo Pimentel
2020-01-09 18:29 ` Bjorn Helgaas [this message]
2020-01-09 17:34 ` Vidya Sagar
2020-01-10 8:56 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200109182957.GA252973@google.com \
--to=helgaas@kernel.org \
--cc=Gustavo.Pimentel@synopsys.com \
--cc=jingoohan1@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=pratyush.anand@gmail.com \
--cc=shawn.guo@linaro.org \
--cc=yuzaihai@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).