From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 263D9C282DD for ; Fri, 10 Jan 2020 16:06:07 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EF0BB206ED for ; Fri, 10 Jan 2020 16:06:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="l5RztTdR"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="rSq1lc5q" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EF0BB206ED Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Cc:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=2Ql7VXohKfzVYcSZOebF60a0ELkA5oNaQ216xGDX424=; b=l5RztTdRRWQV6i fGNyCRG4l/Ys1YU4KWOCKOjtzBd31hvOQmG2zpNnKlCJAE0n88lOYYv+0EnTnKfP9a8GKF7l6PySa uLKKjolcQt/p8YTXH0wj3eRFYzW1OsB5/ZYDuhhTEvbxaquSqKEnxRwLtFmKG8ihADZZg+/j2uPEj 8Tcca4eBQoTN7bZxj4pEBL8hdjRk75onP8RLkjW+AskX2xJzlr2E/UYwtoAghkChD5XEmxSO1/5nx S0eXd6hlhQUJ3Guitou4TKLgJXnLcC+7Q8cs54XgkMC7kramyjlIrro5huYQ2VrZIzFODKDRQN+pB 9xdQvFqG+g5Ej4hhYTzQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1ipwnQ-0006kj-FW; Fri, 10 Jan 2020 16:06:00 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1ipwnL-0006hp-RH; Fri, 10 Jan 2020 16:05:57 +0000 Received: from willie-the-truck (236.31.169.217.in-addr.arpa [217.169.31.236]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 0C952206ED; Fri, 10 Jan 2020 16:05:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1578672354; bh=BwQ3hgNytp3Vhhb3/aGu1TWkWmHNJvFCwz8FcQOU1d0=; h=Date:From:To:Subject:References:In-Reply-To:From; b=rSq1lc5qyWCWzqge30byPL+X5/xbXoMRsnWfIUMmQR1q9Z06hbsvq1xoudf0xEpIW 8YYCWxOchNcLb3Ku5DnU0NPIDBLmlEidbgUOgW13cxDYpAbc4qv4ngDxdZeg6ir/RQ SYSZjLSqwZmMyGUmD3Cenz7LakTi8lItKQmOsRpU= Date: Fri, 10 Jan 2020 16:05:49 +0000 From: Will Deacon To: AKASHI Takahiro , pasha.tatashin@soleen.com, catalin.marinas@arm.com, will.deacon@arm.com, robh+dt@kernel.org, frowand.list@gmail.com, bhsharma@redhat.com, kexec@lists.infradead.org, linux-kernel@vger.kernel.org, james.morse@arm.com, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v4 2/2] arm64: kexec_file: add crash dump support Message-ID: <20200110160549.GA25437@willie-the-truck> References: <20191216021247.24950-1-takahiro.akashi@linaro.org> <20191216021247.24950-3-takahiro.akashi@linaro.org> <20200108174839.GB21242@willie-the-truck> <20200109004654.GA28530@linaro.org> <20200109083254.GA7280@willie-the-truck> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200109083254.GA7280@willie-the-truck> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200110_080555_906813_C0B26E94 X-CRM114-Status: GOOD ( 15.86 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Jan 09, 2020 at 08:32:54AM +0000, Will Deacon wrote: > On Thu, Jan 09, 2020 at 09:46:55AM +0900, AKASHI Takahiro wrote: > > On Wed, Jan 08, 2020 at 05:48:39PM +0000, Will Deacon wrote: > > > On Mon, Dec 16, 2019 at 11:12:47AM +0900, AKASHI Takahiro wrote: > > > > diff --git a/arch/arm64/include/asm/kexec.h b/arch/arm64/include/asm/kexec.h > > > > index 12a561a54128..d24b527e8c00 100644 > > > > --- a/arch/arm64/include/asm/kexec.h > > > > +++ b/arch/arm64/include/asm/kexec.h > > > > @@ -96,6 +96,10 @@ static inline void crash_post_resume(void) {} > > > > struct kimage_arch { > > > > void *dtb; > > > > unsigned long dtb_mem; > > > > + /* Core ELF header buffer */ > > > > + void *elf_headers; > > > > + unsigned long elf_headers_mem; > > > > + unsigned long elf_headers_sz; > > > > }; > > > > > > This conflicts with the cleanup work from Pavel. Please can you check my > > > resolution? [1] > > > > I don't know why we need to change a type of dtb_mem, > > otherwise it looks good. > > > > (I also assume that you notice that kimage_arch is of no use for kexec.) > > Yes, that's why I'd like the resolution checked. If you reckon it's cleaner > to drop Pavel's patch altogether in light of your changes, we can do that > instead. > > Thoughts? Well, I've reverted the cleanup patch so please shout if you'd prefer something else. Will _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel