From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 03326C282DD for ; Fri, 10 Jan 2020 18:30:47 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CE0032080D for ; Fri, 10 Jan 2020 18:30:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="K0PEiiBD"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="IO9T0yg4" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CE0032080D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=z6vW/zkh7rAa1+EYSeFP1DCTGDpxHWhrdQNOKieUczg=; b=K0PEiiBDEzaL3u S/VRHTyRXugSSJzoVsYxKokILJufvD9aWGmQC/E4W1K91/RYL2Z+dsC1HEP/YJV4lP6Jg2bSSqSaw ZhAA7MhMdx1bKj+5paHR6BnVpY3AFW8/hNq6Wn0yXIUVE3zdhQNvemaPTEJrnJGNrw4CBCRNrL9Xs WzLH9u6KrcOA24TMQYmsD158XyTtH8nR5TQIUyBD7ucApqOqCRC16G5CPhFK8LqiX0fSn/sup4ma1 MerY4Hl4cVTtC2uIIFEfSS7FhcjwVIyig1iemiYzkUaABCaJuqy6MbWwBi50GfTT5iudFH9MTYJFK 7ss3HPl/RWcaPm1YZL4w==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1ipz3V-0001S5-TI; Fri, 10 Jan 2020 18:30:45 +0000 Received: from mail-pl1-x644.google.com ([2607:f8b0:4864:20::644]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1ipz3T-0001RH-4X for linux-arm-kernel@lists.infradead.org; Fri, 10 Jan 2020 18:30:44 +0000 Received: by mail-pl1-x644.google.com with SMTP id az3so1146248plb.11 for ; Fri, 10 Jan 2020 10:30:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=2MLWB+VELLlq0wMcKq+XkHGiD3q/IxvQaVGfRiGmonk=; b=IO9T0yg4ydrb35q0ooBVnp0n7unfx9Y9Fy9zTrdT5tabhRFK8WlrTVSEPyDorq3FFa c6ovMoBrHzlbnGWGiGzI/TiYat0sNQAWrEbDyqXiNLyICk8mIklTlsj3Z9c2cUy6ZGNc 3L+3vN/lDlX3iX0XhnFeZ04LFjVsZgEQpgdWWBdU5iDkJ+/MOIrtsGwB9PpQROFUU85V vdgfDijTDnYULmvgco5+nEfO06tZMvJkH5vDHJ/aOJfUFL/8c5ePno9s0PeJtlKEmzvh tcWJhuhP+LqCsVaAaI0EsFZX5cwFr6vKFCGJoUm7t8WTC2HzIxxO2cCZ+kkKbJ7m33Wt lEhA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=2MLWB+VELLlq0wMcKq+XkHGiD3q/IxvQaVGfRiGmonk=; b=EaFo+6veLWGDlu4jqf4LSJNfkyNaJ6+b9puIx7H5zQJIYcPTfrs+EsIfOdS62JxiLq Xs2zpnr0gWkFtVkX0AuczVkJMm0eC0NgzNvtcLB+aIGFDWjAP7nxC2upir0dsdRc+d+i H8h/53KMMBsYtShIPzTqRqx1pCwoDNaLJ6z9IQaRiZfiK/MEDQ7l0aH/JXcFMp1mTimV hq9N0w69/ZVrBYRqV4LFDF1Cs68/yftEofMRVbZ/Kz5oVSpMeJa2DTcs6XXcRDpl4AR7 i/hA4UD6gclJjNJHk+DsxCntkp9ParxdmVYg2/QBwo4BgvWMBOO8NRq3m6kLWiLTc8cy MISQ== X-Gm-Message-State: APjAAAX4I1vVXNbMXwGFkbOE4RJ3HQX8nWkVMYb7CuN67VX22cwzJBBB cWDnnuDgSAmT6tmqGK3akiw= X-Google-Smtp-Source: APXvYqzqeW7byawmap6bSb/B/RJacb9Z8R9ZQUQyQ5r0w7sQ9QIStqmWbjRGnG1bFtk1ZGkGfknskQ== X-Received: by 2002:a17:902:820b:: with SMTP id x11mr5880582pln.196.1578681042024; Fri, 10 Jan 2020 10:30:42 -0800 (PST) Received: from dtor-ws ([2620:15c:202:201:3adc:b08c:7acc:b325]) by smtp.gmail.com with ESMTPSA id b12sm3693774pfi.157.2020.01.10.10.30.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Jan 2020 10:30:41 -0800 (PST) Date: Fri, 10 Jan 2020 10:30:39 -0800 From: Dmitry Torokhov To: Chuhong Yuan Subject: Re: [PATCH] Input: sun4i-ts - add a check for devm_thermal_zone_of_sensor_register Message-ID: <20200110183039.GU8314@dtor-ws> References: <20191210091401.23388-1-hslester96@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20191210091401.23388-1-hslester96@gmail.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200110_103043_179384_856DE045 X-CRM114-Status: GOOD ( 16.67 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-kernel@vger.kernel.org, Maxime Ripard , Eduardo Valentin , Hans de Goede , Chen-Yu Tsai , linux-input@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Dec 10, 2019 at 05:14:01PM +0800, Chuhong Yuan wrote: > The driver misses a check for devm_thermal_zone_of_sensor_register(). > Add a check to fix it. > > Fixes: e28d0c9cd381 ("input: convert sun4i-ts to use devm_thermal_zone_of_sensor_register") > Signed-off-by: Chuhong Yuan Applied, thank you. > --- > drivers/input/touchscreen/sun4i-ts.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/drivers/input/touchscreen/sun4i-ts.c b/drivers/input/touchscreen/sun4i-ts.c > index 0af0fe8c40d7..742a7e96c1b5 100644 > --- a/drivers/input/touchscreen/sun4i-ts.c > +++ b/drivers/input/touchscreen/sun4i-ts.c > @@ -237,6 +237,7 @@ static int sun4i_ts_probe(struct platform_device *pdev) > struct device *dev = &pdev->dev; > struct device_node *np = dev->of_node; > struct device *hwmon; > + struct thermal_zone_device *thermal; > int error; > u32 reg; > bool ts_attached; > @@ -355,7 +356,10 @@ static int sun4i_ts_probe(struct platform_device *pdev) > if (IS_ERR(hwmon)) > return PTR_ERR(hwmon); > > - devm_thermal_zone_of_sensor_register(ts->dev, 0, ts, &sun4i_ts_tz_ops); > + thermal = devm_thermal_zone_of_sensor_register(ts->dev, 0, ts, > + &sun4i_ts_tz_ops); > + if (IS_ERR(thermal)) > + return PTR_ERR(thermal); > > writel(TEMP_IRQ_EN(1), ts->base + TP_INT_FIFOC); > > -- > 2.24.0 > -- Dmitry _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel