From: Moritz Fischer <mdf@kernel.org>
To: Nava kishore Manne <nava.manne@xilinx.com>
Cc: linux-fpga@vger.kernel.org,
Shubhrajyoti Datta <shubhrajyoti.datta@xilinx.com>,
michal.simek@xilinx.com, linux-kernel@vger.kernel.org,
mdf@kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] fpga: xilinx-pr-decoupler: Remove clk_get error message for probe defer
Date: Fri, 10 Jan 2020 12:53:07 -0800 [thread overview]
Message-ID: <20200110205307.GA3246@epycbox.lan> (raw)
In-Reply-To: <20200110063113.3064-1-nava.manne@xilinx.com>
On Fri, Jan 10, 2020 at 12:01:13PM +0530, Nava kishore Manne wrote:
> From: Shubhrajyoti Datta <shubhrajyoti.datta@xilinx.com>
>
> In probe, the driver checks for devm_clk_get return and print error
> message in the failing case. However for -EPROBE_DEFER this message
> is confusing so avoid it.
>
> Signed-off-by: Shubhrajyoti Datta <shubhrajyoti.datta@xilinx.com>
> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
> ---
> drivers/fpga/xilinx-pr-decoupler.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/fpga/xilinx-pr-decoupler.c b/drivers/fpga/xilinx-pr-decoupler.c
> index af9b387c56d3..7d69af230567 100644
> --- a/drivers/fpga/xilinx-pr-decoupler.c
> +++ b/drivers/fpga/xilinx-pr-decoupler.c
> @@ -101,7 +101,8 @@ static int xlnx_pr_decoupler_probe(struct platform_device *pdev)
>
> priv->clk = devm_clk_get(&pdev->dev, "aclk");
> if (IS_ERR(priv->clk)) {
> - dev_err(&pdev->dev, "input clock not found\n");
> + if (PTR_ERR(priv->clk) != -EPROBE_DEFER)
> + dev_err(&pdev->dev, "input clock not found\n");
> return PTR_ERR(priv->clk);
> }
>
> --
> 2.18.0
>
Applied to for-next,
Thanks
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2020-01-10 20:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-10 6:31 [PATCH] fpga: xilinx-pr-decoupler: Remove clk_get error message for probe defer Nava kishore Manne
2020-01-10 20:53 ` Moritz Fischer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200110205307.GA3246@epycbox.lan \
--to=mdf@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-fpga@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.simek@xilinx.com \
--cc=nava.manne@xilinx.com \
--cc=shubhrajyoti.datta@xilinx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).