From: Jonathan Cameron <jic23@kernel.org>
To: Peter Ujfalusi <peter.ujfalusi@ti.com>
Cc: linux-iio@vger.kernel.org, ludovic.desroches@microchip.com,
linux-kernel@vger.kernel.org, vkoul@kernel.org,
eugen.hristev@microchip.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3] iio: adc: at91-sama5d2_adc: Use dma_request_chan() instead dma_request_slave_channel()
Date: Sat, 11 Jan 2020 11:15:01 +0000 [thread overview]
Message-ID: <20200111111501.77d19476@archlinux> (raw)
In-Reply-To: <20200107113729.5505-1-peter.ujfalusi@ti.com>
On Tue, 7 Jan 2020 13:37:29 +0200
Peter Ujfalusi <peter.ujfalusi@ti.com> wrote:
> dma_request_slave_channel() is a wrapper on top of dma_request_chan()
> eating up the error code.
>
> The dma_request_chan() is the standard API to request slave channel,
> clients should be moved away from the legacy API to allow us to retire
> them.
>
> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
Applied to the togreg branch of iio.git and pushed out as testing.
Note that tree will get rebased shortly to catch up with upstream.
(testing can in theory be rebased at any time even if I don't do it
that often).
Thanks,
Jonathan
> ---
> Hi,
>
> Changes since v2:
> - Commit message updated
>
> Changes since v1:
> - Subject prefix is corrected to "iio: adc: at91-sama5d2_adc:"
>
> Regards,
> Peter
>
> drivers/iio/adc/at91-sama5d2_adc.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/iio/adc/at91-sama5d2_adc.c b/drivers/iio/adc/at91-sama5d2_adc.c
> index e1850f3d5cf3..a5c7771227d5 100644
> --- a/drivers/iio/adc/at91-sama5d2_adc.c
> +++ b/drivers/iio/adc/at91-sama5d2_adc.c
> @@ -1444,10 +1444,10 @@ static void at91_adc_dma_init(struct platform_device *pdev)
> if (st->dma_st.dma_chan)
> return;
>
> - st->dma_st.dma_chan = dma_request_slave_channel(&pdev->dev, "rx");
> -
> - if (!st->dma_st.dma_chan) {
> + st->dma_st.dma_chan = dma_request_chan(&pdev->dev, "rx");
> + if (IS_ERR(st->dma_st.dma_chan)) {
> dev_info(&pdev->dev, "can't get DMA channel\n");
> + st->dma_st.dma_chan = NULL;
> goto dma_exit;
> }
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2020-01-11 11:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-07 11:37 [PATCH v3] iio: adc: at91-sama5d2_adc: Use dma_request_chan() instead dma_request_slave_channel() Peter Ujfalusi
2020-01-11 11:15 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200111111501.77d19476@archlinux \
--to=jic23@kernel.org \
--cc=eugen.hristev@microchip.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ludovic.desroches@microchip.com \
--cc=peter.ujfalusi@ti.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).