From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BC82CC33CAD for ; Mon, 13 Jan 2020 13:17:37 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 798062081E for ; Mon, 13 Jan 2020 13:17:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="P+9e0eJn"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=wp.pl header.i=@wp.pl header.b="qzBDUTyY" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 798062081E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=wp.pl Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=7FrgRNe944jOUhyLR6S6HsSqzwgxJLm/dTgvNBLHKVM=; b=P+9e0eJnTlbgTQ 26XOyNml4pxvuC2DbL2T+NKeqjoNE3bj1ecjuAoX4jGLrTJRRqOn3OGDBUbG3Mm2DJvuSix+hbkdE AgRuTR178NhqNnL/7N/D/4LHq5RwPzk7oGWwBzDRnrABOfMT7Hl3RaYPDt/imH2cegw5wj2pKfrWH k7YAvjrCPfZdQasZFz66pkXcvEwSP7U4ZLFkof3YCOudeoHNkm1P1i+TBO9b6yBcW0W9+zrs0BQg0 GMVc5UpLvc4sSqRFvD1gEZDVhFP+XtiV9V5BSimHrKlhBLMTXzodreLEMH61mVV6X4yGqEOh5hjZ6 Pwv2O9NYdJ/8ExmrFEyg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iqzb4-0001TR-IT; Mon, 13 Jan 2020 13:17:34 +0000 Received: from mx3.wp.pl ([212.77.101.9]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iqzb1-0001Rw-MM for linux-arm-kernel@lists.infradead.org; Mon, 13 Jan 2020 13:17:33 +0000 Received: (wp-smtpd smtp.wp.pl 467 invoked from network); 13 Jan 2020 14:17:26 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=wp.pl; s=1024a; t=1578921446; bh=fiL5feLAQg1wnn446GC+3zMpF7346AQGDCS3XeChSTA=; h=From:To:Cc:Subject; b=qzBDUTyY3N87LSG2hKt7ZSXgIJ4yQdIF3Os+2js59ftWgJBrd/cPmAI/+Hdwlnkg6 Fyed6NcUYyiy55TmsPGH5Wenjb7lct8Nj6qQX3SY6YaR/ETLhN91iUyNG/C0oGr5Hi kCBZomcIlnMvzE7EYGBk9nRfqXBXXMu5T905jGjM= Received: from c-73-93-4-247.hsd1.ca.comcast.net (HELO cakuba) (kubakici@wp.pl@[73.93.4.247]) (envelope-sender ) by smtp.wp.pl (WP-SMTPD) with ECDHE-RSA-AES256-GCM-SHA384 encrypted SMTP for ; 13 Jan 2020 14:17:26 +0100 Date: Mon, 13 Jan 2020 05:17:12 -0800 From: Jakub Kicinski To: Ong Boon Leong Subject: Re: [PATCH net 3/7] net: stmmac: fix missing netdev->features in stmmac_set_features Message-ID: <20200113051712.73442991@cakuba> In-Reply-To: <1578967276-55956-4-git-send-email-boon.leong.ong@intel.com> References: <1578967276-55956-1-git-send-email-boon.leong.ong@intel.com> <1578967276-55956-4-git-send-email-boon.leong.ong@intel.com> MIME-Version: 1.0 X-WP-MailID: 9114ca6d95137af99c81d33196a332a9 X-WP-AV: skaner antywirusowy Poczty Wirtualnej Polski X-WP-SPAM: NO 0000000 [YVNE] X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200113_051731_913500_3A38C0C4 X-CRM114-Status: GOOD ( 11.71 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jose Abreu , Alexandre Torgue , Voon Weifeng , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, Maxime Coquelin , Tan Tee Min , Giuseppe Cavallaro , "David S . Miller" , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, 14 Jan 2020 10:01:12 +0800, Ong Boon Leong wrote: Please fix the date on your system. Please always provide a patch description. For bug fixes description of how the bug manifest to the users is important to have. > Fixes: d2afb5bdffde ("stmmac: fix the rx csum feature") > Please remove the empty lines between the Fixes tag and the other tags on all patches. > Signed-off-by: Ong Boon Leong > --- > drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c > index cd55d16..dc739cd 100644 > --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c > +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c > @@ -3911,6 +3911,8 @@ static int stmmac_set_features(struct net_device *netdev, > for (chan = 0; chan < priv->plat->rx_queues_to_use; chan++) > stmmac_enable_sph(priv, priv->ioaddr, sph_en, chan); > > + netdev->features = features; > + > return 0; > } > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel