From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 556D0C33CAD for ; Mon, 13 Jan 2020 14:54:14 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 27E66207FF for ; Mon, 13 Jan 2020 14:54:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="tsGfGGi2"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="WRIzdv/D" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 27E66207FF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=oCMgIsfM/iiwi+PivhwgHf7pBVik3HE/OkDK+9n+l5s=; b=tsGfGGi2GaCndg YRbiQdKHd6vJa5PFXfVJ53VozdigTy2Kh/1laqFLrh/0aMzwFZRS+qxEaRgEELn/numu5dWAuDXoM 99NeLLhEjRTHYMTYk5H0nHekg35/hC9yVVCBmQi2pQ7e4y28jjBsVtcMxp664LdcMtaIUu+pJ+v9T VcN2B+W1u2C887frFMJ++UKJZu0+clC/mSBxK/WfTXMzdkF0GMnx9Ql4MIJHbxATYzFUJyTyexa7A t4h+JZCC8c6Qd9VBGQG9H8xNCAB8UgHQnfU+EgCKYQXwBN3Cx/x0rHSx7k95P057/75faFdjSRHdR UQJLrM9o4YYHT1p1E5BA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1ir16b-0000va-HZ; Mon, 13 Jan 2020 14:54:13 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1ir16Y-0000uA-CZ for linux-arm-kernel@lists.infradead.org; Mon, 13 Jan 2020 14:54:12 +0000 Received: from cakuba (c-73-93-4-247.hsd1.ca.comcast.net [73.93.4.247]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 72A4C20661; Mon, 13 Jan 2020 14:54:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1578927247; bh=+tBhl1sLCJP/p0MoLb8K4ZlbC7vCLCmh0VyIotWkp3U=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=WRIzdv/Dl2lNzNKusUFmrd+8Xdbd63fCKtbgASuIZNtRMvEQOcDutfNEM0lmCBuZu lg0LvogSkI8beX9SKvJYbiPjfdMjyGy+9eL7me5jL6j6JdWSWFq4hzI7+rF/q5nlF8 StJLauWncJk2m+xvT+qcvjseBPj6q6hAooY/qju8= Date: Mon, 13 Jan 2020 06:54:06 -0800 From: Jakub Kicinski To: Jose Abreu Subject: Re: [PATCH net-next v2 1/8] net: stmmac: Initial support for TBS Message-ID: <20200113065406.54bb324b@cakuba> In-Reply-To: References: MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200113_065410_446598_7C65656C X-CRM114-Status: GOOD ( 12.89 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Joao Pinto , Alexandre Torgue , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, Maxime Coquelin , Giuseppe Cavallaro , "David S. Miller" , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, 13 Jan 2020 14:02:36 +0100, Jose Abreu wrote: > Adds the initial hooks for TBS support. This needs a 32 byte descriptor > in order for it to work with current HW. Adds all the logic for Enhanced > Descriptors in main core but no HW related logic for now. > > Signed-off-by: Jose Abreu > diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac.h b/drivers/net/ethernet/stmicro/stmmac/stmmac.h > index f98c5eefb382..dceaeb72a414 100644 > --- a/drivers/net/ethernet/stmicro/stmmac/stmmac.h > +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac.h > @@ -42,10 +42,13 @@ struct stmmac_tx_info { > /* Frequently used values are kept adjacent for cache effect */ > struct stmmac_tx_queue { > u32 tx_count_frames; > + int tbs_avail; > + int tbs_en; These could be bool or a bitfield? > struct timer_list txtimer; > u32 queue_index; > struct stmmac_priv *priv_data; > struct dma_extended_desc *dma_etx ____cacheline_aligned_in_smp; > + struct dma_edesc *dma_entx ____cacheline_aligned_in_smp; Won't this create a cache line-sized hole? Is the structure member supposed to be aligned or the data its pointing to? > struct dma_desc *dma_tx; > struct sk_buff **tx_skbuff; > struct stmmac_tx_info *tx_skbuff_dma; > diff --git a/include/linux/stmmac.h b/include/linux/stmmac.h > index 0531afa9b21e..19190c609282 100644 > --- a/include/linux/stmmac.h > +++ b/include/linux/stmmac.h > @@ -139,6 +139,7 @@ struct stmmac_txq_cfg { > u32 low_credit; > bool use_prio; > u32 prio; > + int tbs_en; also bool? > }; > > struct plat_stmmacenet_data { _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel