From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E4746C33CA9 for ; Mon, 13 Jan 2020 16:15:22 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B50FD214AF for ; Mon, 13 Jan 2020 16:15:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="UzHoz1WH"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="2hwwdBpU" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B50FD214AF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=jWSB1WafzVZYQ8rDOSjtX+t4QO164sBuOcrHae+WoYs=; b=UzHoz1WHbYknUg Ano2QKle4mOO7hvF1S0t3HHyUCG9Kti39iFSmaWglt44NUJWDlTap1OTBfyxPC86Yafnmy1E03cTa xXQxzgNmSSNED8LIYGQkCwFavR9o2ZwKsdMLcnLaI/ZEexMkYs+UcMVzb/8KtwSssppODuGmDC2fU +EGsn/0pYPPL51hZYWHfKmoYcayBfs0pnebwQCj0QX5fhx3UmR7qyl7zp2IrqQKKBfnuPglr5e5Xi aerfTmURmh0lSiTv8bq7EH7KdtrPNvwG47z7MslrTHg0ETIu0aRSKIott51x4AYsJ4BGTUr/YYy4t 4mvSOh4HENZHfVNiBXzQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1ir2N8-0004ps-9e; Mon, 13 Jan 2020 16:15:22 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1ir1Pe-0003V1-Me for linux-arm-kernel@lists.infradead.org; Mon, 13 Jan 2020 15:13:57 +0000 Received: from cakuba (unknown [172.58.35.234]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6E949207E0; Mon, 13 Jan 2020 15:13:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1578928434; bh=k37G7crg/rnM1OPMgaFjdTDn+Y4irTU6HvEVxVieUjM=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=2hwwdBpUxEHlF/MjAnrClMUvpSXE0hViNfyJbeItXwrJg/UYJfNs7k4g0NTGgL4qg oB47bgNla0FdArsPtX9RFkZtKktMmYBl6EAK5tKv6DMGQWLM3whpFWy2ndFngr58H1 e/SiSW/FESxRge2qm/qM6l5ZH530SABcPO51G5uQ= Date: Mon, 13 Jan 2020 07:12:51 -0800 From: Jakub Kicinski To: Jose Abreu Subject: Re: [PATCH net-next v2 2/8] net: stmmac: tc: Add support for ETF Scheduler using TBS Message-ID: <20200113071251.1d9d51f6@cakuba> In-Reply-To: <4a4290706a9166d67d2d455dfa9d5f259699a036.1578920366.git.Jose.Abreu@synopsys.com> References: <4a4290706a9166d67d2d455dfa9d5f259699a036.1578920366.git.Jose.Abreu@synopsys.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200113_071355_617529_65B22BC5 X-CRM114-Status: UNSURE ( 7.18 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Joao Pinto , Alexandre Torgue , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, Maxime Coquelin , Giuseppe Cavallaro , "David S. Miller" , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, 13 Jan 2020 14:02:37 +0100, Jose Abreu wrote: > +static int tc_setup_etf(struct stmmac_priv *priv, > + struct tc_etf_qopt_offload *qopt) > +{ > + There's a couple places I spotted where continuation lines are not aligned to the opening parenthesis, and here we have a spurious blank line. Please run this through checkpatch --strict, I see quite a few legit errors there. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel