From: Jakub Kicinski <kubakici@wp.pl>
To: Jose Abreu <Jose.Abreu@synopsys.com>
Cc: Joao Pinto <Joao.Pinto@synopsys.com>,
Alexandre Torgue <alexandre.torgue@st.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Giuseppe Cavallaro <peppe.cavallaro@st.com>,
"David S. Miller" <davem@davemloft.net>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH net-next v2 6/8] net: stmmac: Add missing information in DebugFS capabilities file
Date: Mon, 13 Jan 2020 07:19:46 -0800 [thread overview]
Message-ID: <20200113071946.1dbdecd1@cakuba> (raw)
In-Reply-To: <faaa377a5518be7357f897d02eb0e35b57912093.1578920366.git.Jose.Abreu@synopsys.com>
On Mon, 13 Jan 2020 14:02:41 +0100, Jose Abreu wrote:
> diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
> index fcc1ffe0b11e..7c2645ee81b1 100644
> --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
> +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
> @@ -4341,6 +4341,10 @@ static int stmmac_dma_cap_show(struct seq_file *seq, void *v)
> priv->dma_cap.number_rx_queues);
> seq_printf(seq, "\tNumber of Additional TX queues: %d\n",
> priv->dma_cap.number_tx_queues);
> + seq_printf(seq, "\tCurrent number of TX queues: %d\n",
> + priv->plat->tx_queues_to_use);
> + seq_printf(seq, "\tCurrent number of RX queues: %d\n",
> + priv->plat->rx_queues_to_use);
You should probably just implement ethtool get_channels.
nack on this part.
> seq_printf(seq, "\tEnhanced descriptors: %s\n",
> (priv->dma_cap.enh_desc) ? "Y" : "N");
> seq_printf(seq, "\tTX Fifo Size: %d\n", priv->dma_cap.tx_fifo_size);
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-01-13 15:20 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-13 13:02 [PATCH net-next v2 0/8] net: stmmac: ETF support Jose Abreu
2020-01-13 13:02 ` [PATCH net-next v2 1/8] net: stmmac: Initial support for TBS Jose Abreu
2020-01-13 14:54 ` Jakub Kicinski
2020-01-13 15:10 ` Jose Abreu
2020-01-13 13:02 ` [PATCH net-next v2 2/8] net: stmmac: tc: Add support for ETF Scheduler using TBS Jose Abreu
2020-01-13 15:12 ` Jakub Kicinski
2020-01-13 15:17 ` Jose Abreu
2020-01-13 13:02 ` [PATCH net-next v2 3/8] net: stmmac: xgmac: Add TBS support Jose Abreu
2020-01-13 13:02 ` [PATCH net-next v2 4/8] net: stmmac: gmac4+: " Jose Abreu
2020-01-13 13:02 ` [PATCH net-next v2 5/8] net: stmmac: pci: Enable TBS on GMAC5 IPK PCI entry Jose Abreu
2020-01-13 13:02 ` [PATCH net-next v2 6/8] net: stmmac: Add missing information in DebugFS capabilities file Jose Abreu
2020-01-13 15:19 ` Jakub Kicinski [this message]
2020-01-13 13:02 ` [PATCH net-next v2 7/8] net: stmmac: selftests: Switch to dev_direct_xmit() Jose Abreu
2020-01-13 13:02 ` [PATCH net-next v2 8/8] net: stmmac: selftests: Add a test for TBS feature Jose Abreu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200113071946.1dbdecd1@cakuba \
--to=kubakici@wp.pl \
--cc=Joao.Pinto@synopsys.com \
--cc=Jose.Abreu@synopsys.com \
--cc=alexandre.torgue@st.com \
--cc=davem@davemloft.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).