From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6A44CC33CAD for ; Mon, 13 Jan 2020 11:21:20 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3F5E120CC7 for ; Mon, 13 Jan 2020 11:21:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="F//CFZIl"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="aWZiWF2V" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3F5E120CC7 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=VX2vWtx3+erutQhbwkIHj7t974audYPkZ5bX1GRd34c=; b=F//CFZIleSvgG/ S3VaHwpMvsb+qa9mjBqr+ruurqHjNzTvGZvA6Ei1YclyMUCNcpDKTqNEAWt/y7W2wGCbnVk2M2BGI mwJdSUPeG85SAhNWqK05XEw4x5MHs60KXVl8naVZruDGqiyTLBxrhZxCiTjoTgWXED0knb6L+2Fw+ Mn3FuyhWKFkZ/PPS1+iBD2Ai8+U1n5LTQz3q0+fV8aGXiucWrApDpmd+IsCjVH8LYfB1M1UND4dO7 TVytVBrPnJD4H/Gu22eaq1XpfMKYjC1w5fdg+8B7vz26fw+LwNHUGtZgXUlhcItuX71KxrYB+NtLX XJb+zmbb9POv0Le4h66A==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iqxmV-0007CB-AP; Mon, 13 Jan 2020 11:21:15 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iqxmR-0007AJ-LO; Mon, 13 Jan 2020 11:21:13 +0000 Received: from willie-the-truck (236.31.169.217.in-addr.arpa [217.169.31.236]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 34D7B207FF; Mon, 13 Jan 2020 11:21:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1578914471; bh=OuK+LaRV/ZHDJhzQECD6orhexsBuPcHYw40Uzm4U2Tw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=aWZiWF2VQAg1WiXK48ln/JbWSNhePOZDL9OZmpqs6ZtMuwXPhoh/s/yiG1rxPcjan AhAgqPwtbTaiAxgMUzok61pjSz/yD6JY29wiaD4yziTDV18jQOdA3mtdTR/tPOho53 eQ0L2nzc33gVv4Sa8MX30ecHqH6a1jTFialbbA6Q= Date: Mon, 13 Jan 2020 11:21:06 +0000 From: Will Deacon To: Pavel Tatashin Subject: Re: [PATCH v4 2/2] arm64: kexec_file: add crash dump support Message-ID: <20200113112105.GB2337@willie-the-truck> References: <20191216021247.24950-1-takahiro.akashi@linaro.org> <20191216021247.24950-3-takahiro.akashi@linaro.org> <20200108174839.GB21242@willie-the-truck> <20200109004654.GA28530@linaro.org> <20200109083254.GA7280@willie-the-truck> <20200110160549.GA25437@willie-the-truck> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200113_032111_739126_CB8A549B X-CRM114-Status: GOOD ( 19.97 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Catalin Marinas , Bhupesh Sharma , Will Deacon , LKML , AKASHI Takahiro , robh+dt@kernel.org, James Morse , frowand.list@gmail.com, kexec mailing list , Linux ARM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Jan 10, 2020 at 11:19:16AM -0500, Pavel Tatashin wrote: > On Fri, Jan 10, 2020 at 11:05 AM Will Deacon wrote: > > > > On Thu, Jan 09, 2020 at 08:32:54AM +0000, Will Deacon wrote: > > > On Thu, Jan 09, 2020 at 09:46:55AM +0900, AKASHI Takahiro wrote: > > > > On Wed, Jan 08, 2020 at 05:48:39PM +0000, Will Deacon wrote: > > > > > On Mon, Dec 16, 2019 at 11:12:47AM +0900, AKASHI Takahiro wrote: > > > > > > diff --git a/arch/arm64/include/asm/kexec.h b/arch/arm64/include/asm/kexec.h > > > > > > index 12a561a54128..d24b527e8c00 100644 > > > > > > --- a/arch/arm64/include/asm/kexec.h > > > > > > +++ b/arch/arm64/include/asm/kexec.h > > > > > > @@ -96,6 +96,10 @@ static inline void crash_post_resume(void) {} > > > > > > struct kimage_arch { > > > > > > void *dtb; > > > > > > unsigned long dtb_mem; > > > > > > + /* Core ELF header buffer */ > > > > > > + void *elf_headers; > > > > > > + unsigned long elf_headers_mem; > > > > > > + unsigned long elf_headers_sz; > > > > > > }; > > > > > > > > > > This conflicts with the cleanup work from Pavel. Please can you check my > > > > > resolution? [1] > > > > > > > > I don't know why we need to change a type of dtb_mem, > > > > otherwise it looks good. > > > > > > > > (I also assume that you notice that kimage_arch is of no use for kexec.) > > > > > > Yes, that's why I'd like the resolution checked. If you reckon it's cleaner > > > to drop Pavel's patch altogether in light of your changes, we can do that > > > instead. > > > > > > Thoughts? > > > > Well, I've reverted the cleanup patch so please shout if you'd prefer > > something else. > > As I understand, the only concern was the type change for dtb_mem. > This was one of the review comments for my patch > https://lore.kernel.org/lkml/20191204155938.2279686-21-pasha.tatashin@soleen.com/ > > (I believe it was from Marc Zyngier), I add a number of new fields, > and they all should be phys_addr_t, this is why I change dtb_mem to > phys_addr_t to be consistent. Sure, but I've only queued the first part of your series and that cleanup patch doesn't make a lot of sense when applied against Akashi's work. I'm happy to take stuff on top if you both agree to it, but having half of the struct use unsigned long and the other half use phys_addr_t is messy. Will _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel