From: Will Deacon <will@kernel.org>
To: Leonard Crestez <leonard.crestez@nxp.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
Dong Aisheng <aisheng.dong@nxp.com>, Frank Li <frank.li@nxp.com>,
Joakim Zhang <qiangqing.zhang@nxp.com>,
linux-imx@nxp.com, kernel@pengutronix.de,
Fabio Estevam <fabio.estevam@nxp.com>,
Shawn Guo <shawnguo@kernel.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] perf/imx_ddr: Fix leaking cpuhp_state
Date: Tue, 14 Jan 2020 16:51:48 +0000 [thread overview]
Message-ID: <20200114165142.GE2579@willie-the-truck> (raw)
In-Reply-To: <3cff630697d76d24d4ab93dfcddc978d84b8f2d8.1576711200.git.leonard.crestez@nxp.com>
On Thu, Dec 19, 2019 at 01:20:19AM +0200, Leonard Crestez wrote:
> This driver allocates a dynamic cpu hotplug state but never releases it.
> If reloaded in a loop it will quickly trigger a WARN message:
>
> "No more dynamic states available for CPU hotplug"
>
> Fix by calling cpuhp_remove_multi_state like several other perf pmu
> drivers.
>
> Fixes: 8f4c58ae59f5 ("perf/imx_ddr: Fix leaking cpuhp_state")
> Signed-off-by: Leonard Crestez <leonard.crestez@nxp.com>
> ---
> drivers/perf/fsl_imx8_ddr_perf.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/perf/fsl_imx8_ddr_perf.c b/drivers/perf/fsl_imx8_ddr_perf.c
> index 3be61be1ba91..aa30ca5f6b29 100644
> --- a/drivers/perf/fsl_imx8_ddr_perf.c
> +++ b/drivers/perf/fsl_imx8_ddr_perf.c
> @@ -672,12 +672,14 @@ static int ddr_perf_probe(struct platform_device *pdev)
> goto ddr_perf_err;
>
> return 0;
>
> ddr_perf_err:
> - if (pmu->cpuhp_state)
> + if (pmu->cpuhp_state) {
> cpuhp_state_remove_instance_nocalls(pmu->cpuhp_state, &pmu->node);
> + cpuhp_remove_multi_state(pmu->cpuhp_state);
> + }
Shouldn't we also be checking the return value of the earlier call to
cpuhp_state_add_instant_nocalls() and then calling only
cpuhp_remove_multi_state() if it fails?
Thanks,
Will
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2020-01-14 16:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-18 23:20 [PATCH] perf/imx_ddr: Fix leaking cpuhp_state Leonard Crestez
2020-01-13 20:00 ` Leonard Crestez
2020-01-14 16:51 ` Will Deacon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200114165142.GE2579@willie-the-truck \
--to=will@kernel.org \
--cc=aisheng.dong@nxp.com \
--cc=fabio.estevam@nxp.com \
--cc=frank.li@nxp.com \
--cc=kernel@pengutronix.de \
--cc=leonard.crestez@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=mark.rutland@arm.com \
--cc=qiangqing.zhang@nxp.com \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox