From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B592DC33CB1 for ; Wed, 15 Jan 2020 14:34:28 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8846B2073A for ; Wed, 15 Jan 2020 14:34:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Ai9M9R4b" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8846B2073A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=nk1Q4ciIoBKv1eMFvQ8xsekZlbmuApbFPGXzRtITOdg=; b=Ai9M9R4bDc4ERb e/sogm94Xxdxda1q+zZyVpjuvSOQaltH508Dr+gAdTuBDJ8Xi+bmwWXKfljn/DJ6LIQZ4uJZUGqzm E0qxmmywVs7GN2GHs+hFfgPPpMMaU5PthBMcoW/YS8RQBNXkuDqkYVGsoxTNddoBqCXc8ylpbrcj2 w8cjxmeNZIsvcmHBYsT1Sx5k0A/saYF79T2gcAQweqosNtHbAvoNgI4fmlrzwONdgL9FxLNdZx8tG hvukTyRhACzRk1mmvGnMJt7KwVlPmXiLEt6tLNE1ByLf4FpWmwBdrI5rLNABS3rj2sWUUlZWgaCoj JhMSmQDbBl7V9lYAN2zQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1irjkZ-0002JR-Bv; Wed, 15 Jan 2020 14:34:27 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1irjjr-0001WQ-JE for linux-arm-kernel@lists.infradead.org; Wed, 15 Jan 2020 14:33:45 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id BF44A31B; Wed, 15 Jan 2020 06:33:42 -0800 (PST) Received: from bogus (e103737-lin.cambridge.arm.com [10.1.197.49]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id A16FB3F68E; Wed, 15 Jan 2020 06:33:41 -0800 (PST) Date: Wed, 15 Jan 2020 14:33:25 +0000 From: Sudeep Holla To: Peng Fan Subject: Re: [PATCH V2] firmware: arm_scmi: Make scmi core independent of transport type Message-ID: <20200115143325.GA12340@bogus> References: <3f5567ec928e20963d729350e6d674c4acb0c7a0.1578648530.git.viresh.kumar@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200115_063343_738607_FC1F15D7 X-CRM114-Status: GOOD ( 18.12 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "arnd@arndb.de" , Viresh Kumar , "jassisinghbrar@gmail.com" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , Sudeep Holla , "cristian.marussi@arm.com" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Jan 15, 2020 at 08:53:51AM +0000, Peng Fan wrote: > > > Subject: [PATCH V2] firmware: arm_scmi: Make scmi core independent of > > transport type > > > > The SCMI specification is fairly independent of the transport protocol, which > > can be a simple mailbox (already implemented) or anything else. > > The current Linux implementation however is very much dependent of the > > mailbox transport layer. > > > > This patch makes the SCMI core code (driver.c) independent of the mailbox > > transport layer and moves all mailbox related code to a new > > file: mailbox.c. > > > > We can now implement more transport protocols to transport SCMI messages, > > some of the transport protocols getting discussed currently are SMC/HVC, > > SPCI (built on top of SMC/HVC), OPTEE based mailbox (similar to SPCI), and > > vitio based transport as alternative to mailbox. > > > > The transport protocols just need to provide struct scmi_desc, which also > > implements the struct scmi_transport_ops. > > I need put shmem for each protocol, is this expected? No, it's optional. If some/all protocols need dedicated channel for whatever reasons(like DVFS/Perf for polling based transfers), they can specify. Absence of dedicated channel infers all protocols share the channel(s). > Sudeep, > I am able to use smc to directly transport data, > with adding a new file, just named smc.c including a scmi_smc_desc, Good. > But I not find a good way to pass smc id to smc transport file. > IMO, we have to deal this in transport specific init. I am thinking of chan_setup in context of this patch. Does that make sense ? [...] > + > + scmi_clk: protocol@14 { > + reg = <0x14>; > + shmem = <&cpu_scp_lpri>; > + #clock-cells = <1>; > + clocks = <&osc_32k>, <&osc_24m>, <&clk_ext1>, <&clk_ext2>, > + <&clk_ext3>, <&clk_ext4>; > + clock-names = "osc_32k", "osc_24m", "clk_ext1", "clk_ext2", > + "clk_ext3", "clk_ext4"; This caught my attention, why do we need these clocks phandle list and clock names above ? Ideally just need scmi_clk phandle and the index to refer and names need to be provided by the firmware. -- Regards, Sudeep _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel