From: Greg KH <gregkh@linuxfoundation.org>
To: Suzuki Kuruppassery Poulose <suzuki.poulose@arm.com>
Cc: Sasha Levin <sashal@kernel.org>,
mathieu.poirier@linaro.org, linux-arm-kernel@lists.infradead.org,
stable@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [stable] [PATCH 1/2] coresight: etb10: Do not call smp_processor_id from preemptible
Date: Wed, 15 Jan 2020 16:11:18 +0100 [thread overview]
Message-ID: <20200115151118.GC3740793@kroah.com> (raw)
In-Reply-To: <a183da32-b933-6ed0-f8b8-703e27d3f15e@arm.com>
On Thu, Jan 09, 2020 at 02:36:17PM +0000, Suzuki Kuruppassery Poulose wrote:
> On 09/01/2020 14:35, Sasha Levin wrote:
> > On Wed, Jan 08, 2020 at 11:05:40AM +0000, Suzuki K Poulose wrote:
> > > [ Upstream commit 730766bae3280a25d40ea76a53dc6342e84e6513 ]
> > >
> > > During a perf session we try to allocate buffers on the "node" associated
> > > with the CPU the event is bound to. If it is not bound to a CPU, we
> > > use the current CPU node, using smp_processor_id(). However this is
> > > unsafe
> > > in a pre-emptible context and could generate the splats as below :
> > >
> > > BUG: using smp_processor_id() in preemptible [00000000] code: perf/2544
> > >
> > > Use NUMA_NO_NODE hint instead of using the current node for events
> > > not bound to CPUs.
> > >
> > > Fixes: 2997aa4063d97fdb39 ("coresight: etb10: implementing AUX API")
> > > Cc: Mathieu Poirier <mathieu.poirier@linaro.org>
> > > Signed-off-by: Suzuki K Poulose <suzuki.poulose@arm.com>
> > > Cc: stable <stable@vger.kernel.org> # v4.9 to v4.19
> > > Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org>
> > > Link: https://lore.kernel.org/r/20190620221237.3536-5-mathieu.poirier@linaro.org
> > >
> >
> > I've queued this for 4.9-4.19. There was a simple conflict on 4.9 which
> > also had to be resolved.
> >
>
>
> Thanks Sasha !
Note, these had to all be dropped as they broke the build :(
So can you please send us patches that at least build? :)
thanks,
greg k-h
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-01-15 15:11 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-08 11:05 [stable] [PATCH 1/2] coresight: etb10: Do not call smp_processor_id from preemptible Suzuki K Poulose
2020-01-08 11:05 ` [stable] [PATCH 2/2] coresight: tmc-etf: " Suzuki K Poulose
2020-01-09 14:35 ` [stable] [PATCH 1/2] coresight: etb10: " Sasha Levin
2020-01-09 14:36 ` Suzuki Kuruppassery Poulose
2020-01-15 15:11 ` Greg KH [this message]
2020-01-15 16:44 ` Suzuki Kuruppassery Poulose
2020-01-15 17:21 ` Greg KH
2020-01-15 17:28 ` Suzuki Kuruppassery Poulose
2020-01-28 8:15 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200115151118.GC3740793@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=sashal@kernel.org \
--cc=stable@vger.kernel.org \
--cc=suzuki.poulose@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).