From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 73110C32771 for ; Wed, 15 Jan 2020 18:43:57 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4E72822522 for ; Wed, 15 Jan 2020 18:43:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="dgQQC9LN"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="wmu6omqS" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4E72822522 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Xx9QphxMrdjCh5UpAQGrmTwvhonlrsxYp79RF1r9umQ=; b=dgQQC9LNL9J1Qk V1bac7n4G9inRqCUAvEnsRVe28Q34PC8gI/ZpxAlMf3NmbR/C3hzNov32w9DDVn27fwIq4hApoguB jP+O0bU15uYOtypVEXMpLqEUtiGf+JEgiWZQLEXdoM19gzXW87aJ0pdayP9hNGnpG7if8qOs4Bn5L T1jYTrhayAk5YVVBNo9ugH9Qr06fTnJSi4BwDXUscWjLUPhWbONQTnEiSpeNtZfrp1cRCD+2MV4N2 PqKfiQP12HJP/RyoH6re6n8BqQ2riyy1CmCUUN/WZ5a4tmApEEHkWSoaE46PH5I64sP14scjJGc37 s3HV6McGmVEnCP+qR2KQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1irne0-0003GE-RM; Wed, 15 Jan 2020 18:43:56 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1irndv-0003F6-9v for linux-arm-kernel@lists.infradead.org; Wed, 15 Jan 2020 18:43:55 +0000 Received: from willie-the-truck (236.31.169.217.in-addr.arpa [217.169.31.236]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 30BEA24671; Wed, 15 Jan 2020 18:43:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579113831; bh=/eFC1/94GM/E14LrzsWyGdijl3QoD8C9TR2FDKmnYcw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=wmu6omqSUifD8yHMKfUjlm2U8XK4g8Z1dnok1u+NOuQdD8aL5ZRbGaM92SbfMnMlv O9V5C3K7z5Bzw50HUB3j7y7AZYx9QiybpTkCP8mttCRv7UUyyRuPcQIKjEmCN4opAA /zfs3XwxOLIo7jh2ipu4SfeZW37uo5/9lmZCpCzM= Date: Wed, 15 Jan 2020 18:43:47 +0000 From: Will Deacon To: Jiri Slaby Subject: Re: [PATCH 2/3] arm64: lib: Use modern annotations for assembly functions Message-ID: <20200115184346.GD31673@willie-the-truck> References: <20200106195818.56351-1-broonie@kernel.org> <20200106195818.56351-3-broonie@kernel.org> <20200107144445.GC29001@willie-the-truck> <20200107174741.GG4877@sirena.org.uk> <20200108122957.GA16658@willie-the-truck> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200115_104351_363557_00D25EF4 X-CRM114-Status: GOOD ( 16.23 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Catalin Marinas , Mark Brown , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Jan 10, 2020 at 05:56:22PM +0100, Jiri Slaby wrote: > On 08. 01. 20, 13:29, Will Deacon wrote: > > On Tue, Jan 07, 2020 at 05:47:41PM +0000, Mark Brown wrote: > >> On Tue, Jan 07, 2020 at 02:44:46PM +0000, Will Deacon wrote: > >>> Jiri -- is it ok to omit the stack frame for leaf functions annotated with > >>> SYM_FUNC_START? I'm guessing it should be, since the link register isn't > >>> going to be clobbered. Could we update the documentation to reflect that? > >> > >> Yeah, the documentation isn't great on that. I was going on the basis > >> of both trying to minimize changes to the generated output as part of > >> the bulk change and looking at it from the point of view of the caller - > >> if as in this case the caller thinks it's a regular C function it seems > >> sensible to annotate it as such. > > > > Maybe a small tweak to the documentation as per below, indicating that the > > stack stuff is just an x86-specific example? > > > > Jiri? > > Yes, the text in the documentation was too x86-specific. Could you send > the below as a proper patch? Thanks. Sorry it took so long: https://lkml.kernel.org/r/20200115184305.1187-1-will@kernel.org Will _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel