From: Krzysztof Kozlowski <krzk@kernel.org>
To: Wolfram Sang <wsa@the-dreams.de>
Cc: Arnd Bergmann <arnd@arndb.de>,
Linus Walleij <linus.walleij@linaro.org>,
linux-kernel@vger.kernel.org, Jean Delvare <jdelvare@suse.de>,
Vladimir Zapolskiy <vz@mleia.com>,
Jarkko Nikula <jarkko.nikula@linux.intel.com>,
linux-i2c@vger.kernel.org,
Sylvain Lemieux <slemieux.tyco@gmail.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 1/4] i2c: pmcmsp: Use proper printk format for resource_size_t
Date: Wed, 15 Jan 2020 20:51:57 +0100 [thread overview]
Message-ID: <20200115195157.GA8661@kozik-lap> (raw)
In-Reply-To: <20200115174553.GI1239@ninjato>
On Wed, Jan 15, 2020 at 06:45:53PM +0100, Wolfram Sang wrote:
>
> > + "Unable to get memory/io address region %pap\n",
> > + &(res->start));
>
> My first thought was "parens not needed"; not because I like being picky
> but because it doesn't look more readable to me.
>
> checkpatch agrees:
>
> CHECK: Unnecessary parentheses around res->start
> #30: FILE: drivers/i2c/busses/i2c-pmcmsp.c:278:
> + &(res->start));
Indeed... let me send v3.
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2020-01-15 19:52 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-14 9:06 [PATCH v2 1/4] i2c: pmcmsp: Use proper printk format for resource_size_t Krzysztof Kozlowski
2020-01-14 9:06 ` [PATCH v2 2/4] i2c: pnx: " Krzysztof Kozlowski
2020-01-14 9:06 ` [PATCH v2 3/4] i2c: highlander: Use proper printk format for iomem pointer Krzysztof Kozlowski
2020-01-15 17:43 ` Wolfram Sang
2020-01-15 19:57 ` Krzysztof Kozlowski
2020-01-14 9:06 ` [PATCH v2 4/4] i2c: stu300: " Krzysztof Kozlowski
2020-01-15 17:42 ` Wolfram Sang
2020-01-15 17:45 ` [PATCH v2 1/4] i2c: pmcmsp: Use proper printk format for resource_size_t Wolfram Sang
2020-01-15 19:51 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200115195157.GA8661@kozik-lap \
--to=krzk@kernel.org \
--cc=arnd@arndb.de \
--cc=jarkko.nikula@linux.intel.com \
--cc=jdelvare@suse.de \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=slemieux.tyco@gmail.com \
--cc=vz@mleia.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).