From: Thierry Reding <thierry.reding@gmail.com>
To: Jitao Shi <jitao.shi@mediatek.com>
Cc: linux-pwm@vger.kernel.org, linux-kernel@vger.kernel.org,
CK Hu <ck.hu@mediatek.com>,
sj.huang@mediatek.com, linux-mediatek@lists.infradead.org,
Uwe Kleine-Koenig <u.kleine-koenig@pengutronix.de>,
Matthias Brugger <matthias.bgg@gmail.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v4 2/2] pwm: mtk_disp: keep the trigger register after pwm setting.
Date: Mon, 20 Jan 2020 12:54:04 +0100 [thread overview]
Message-ID: <20200120115404.GB206171@ulmo> (raw)
In-Reply-To: <20191217040237.28238-3-jitao.shi@mediatek.com>
[-- Attachment #1.1: Type: text/plain, Size: 656 bytes --]
On Tue, Dec 17, 2019 at 12:02:37PM +0800, Jitao Shi wrote:
> Move the trigger after pwm setting to avoid the pwm wrong signal
> output.
>
> Remove the regist enable trigger setting in probe.
> Move the trigger to end of mtk_disp_pwm_config().
>
> Signed-off-by: Jitao Shi <jitao.shi@mediatek.com>
> ---
> drivers/pwm/pwm-mtk-disp.c | 20 +++++++-------------
> 1 file changed, 7 insertions(+), 13 deletions(-)
Same as for patch 1/2, please make the commit message more useful. Don't
say what you do (because the patch already shows that), but instead say
why you do it, what the specific problems are that you're fixing, etc.
Thierry
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2020-01-20 11:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-17 4:02 [PATCH v4 0/2] clocks aren't disable when pwm_mtk_disp suspend Jitao Shi
2019-12-17 4:02 ` [PATCH v4 1/2] pwm: mtk_disp: fix pwm clocks not poweroff when disable pwm Jitao Shi
2020-01-20 11:52 ` Thierry Reding
2020-01-20 14:31 ` Uwe Kleine-König
2019-12-17 4:02 ` [PATCH v4 2/2] pwm: mtk_disp: keep the trigger register after pwm setting Jitao Shi
2020-01-20 11:54 ` Thierry Reding [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200120115404.GB206171@ulmo \
--to=thierry.reding@gmail.com \
--cc=ck.hu@mediatek.com \
--cc=jitao.shi@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-pwm@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=sj.huang@mediatek.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).