From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E5712C2D0CE for ; Tue, 21 Jan 2020 17:05:26 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B3B1421569 for ; Tue, 21 Jan 2020 17:05:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="rUy2bry8"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b="lqWja4lT" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B3B1421569 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=armlinux.org.uk Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=dRDyAAWguB0JW4T4nLztki7vNujSoEw9z5A3FBpHF5A=; b=rUy2bry8z11FOq 4XLz/mhpLV0KMJEbLKe6q3OFu1hmEYWk8BeUcMgsBrt0pS8vAlZeLNi1mR9mgeXt6Q4V/ggOuuIBj q2gOIu5seYe4WbBL1G49btWk9wz7oDqRVOMLLuZDIu97e3fBaFwx5wEpsnl/ZoWNhLge3In55H2yz zIcNsBdIqSDVV8Y4G9HUagbj5bFdGuC7NAIpoBOUU6zvXOrkfQJuWnJ8madBv+4AB1xpMVZzfe1IK vjZxJ98jvH2LN1VjWC0yBfpcKVr62/xtE4oXctcxxguy3nAFnBdzL7I16mYebo2/f4RhXueNhu+ua hrcHwoGTKgucXYp0q1gg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1itwxy-0003wo-0H; Tue, 21 Jan 2020 17:05:26 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:3201:214:fdff:fe10:1be6]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1itwxr-0003w0-KV for linux-arm-kernel@lists.infradead.org; Tue, 21 Jan 2020 17:05:24 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=HOkuQLxE1IM33Ws1DA0iCvA3nHSpKBt03fizcakeBVI=; b=lqWja4lTgiHFf7h/oDfSYwCdn ffE1FbqEvVVa0ZyuzTEB7L+9H9DVIFJoLjBxGAXw4ry7Xhq5p1/2yEQ8XD4RiFRYDjvygjcfhzVIx FytKHCkFcdu4WuDthrdhSBR8BbUTfCXExC/rH+yigGw/Rwr4gQ4cqWDmq1AnC+PHJsyDEMyRaBUpb K4M6JwWJ6rdSQGiCGVjD00NhBrp7mCIU66sDbHl0dwGSxPeJZGXQXFZv5MKwRbi7BROmZcoMbI+rd glFn2AvJ9ISNYvF2qD7Oghf3xAJHZdEE2ptzb/++AM9fOjRTiqpAGbpv6pXA6GYrQMNTkHeTOP1uU MECN0fQgw==; Received: from shell.armlinux.org.uk ([2002:4e20:1eda:1:5054:ff:fe00:4ec]:37252) by pandora.armlinux.org.uk with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1itwxk-00062b-CI; Tue, 21 Jan 2020 17:05:12 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.92) (envelope-from ) id 1itwxj-0003zR-Nj; Tue, 21 Jan 2020 17:05:11 +0000 Date: Tue, 21 Jan 2020 17:05:11 +0000 From: Russell King - ARM Linux admin To: Qais Yousef Subject: Re: [PATCH v2 03/14] arm: arm64: Don't use disable_nonboot_cpus() Message-ID: <20200121170511.GI25745@shell.armlinux.org.uk> References: <20191125112754.25223-1-qais.yousef@arm.com> <20191125112754.25223-4-qais.yousef@arm.com> <20200121165030.xksivf6mrhsaynq2@e107158-lin.cambridge.arm.com> <20200121165321.GH25745@shell.armlinux.org.uk> <20200121165809.3kk3xauky4vjp5ni@e107158-lin.cambridge.arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200121165809.3kk3xauky4vjp5ni@e107158-lin.cambridge.arm.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200121_090519_728818_485D97EB X-CRM114-Status: GOOD ( 19.93 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Greg Kroah-Hartman , linux-kernel@vger.kernel.org, Catalin Marinas , Thomas Gleixner , Will Deacon , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Jan 21, 2020 at 04:58:09PM +0000, Qais Yousef wrote: > On 01/21/20 16:53, Russell King - ARM Linux admin wrote: > > On Tue, Jan 21, 2020 at 04:50:31PM +0000, Qais Yousef wrote: > > > On 11/25/19 11:27, Qais Yousef wrote: > > > > disable_nonboot_cpus() is not safe to use when doing machine_down(), > > > > because it relies on freeze_secondary_cpus() which in return is > > > > a suspend/resume related freeze and could abort if the logic detects any > > > > pending activities that can prevent finishing the offlining process. > > > > > > > > Beside disable_nonboot_cpus() is dependent on CONFIG_PM_SLEEP_SMP which > > > > is an othogonal config to rely on to ensure this function works > > > > correctly. > > > > > > > > Signed-off-by: Qais Yousef > > > > CC: Russell King > > > > CC: Catalin Marinas > > > > CC: Will Deacon > > > > CC: linux-arm-kernel@lists.infradead.org > > > > CC: linux-kernel@vger.kernel.org > > > > --- > > > > > > Ping :) > > > > > > I'm missing ACKs on this patch and patch 4 for arm64. Hopefully none should be > > > controversial. > > > > ARM and ARM64 are maintained separately, so you can't submit a single > > patch covering both. Sorry. > > Sure I'd be happy to split. > > It was just a single line change and I expected Thomas to pick the whole series > up, so I didn't think there'd be an issue in combining them up since they're > identical. > > Do I take it you have no objection to the code change itself and just would > like to see this split up? I do have an objection to the new function you're introducing in patch 1. See my reply to that. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up According to speedtest.net: 11.9Mbps down 500kbps up _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel