* [PATCH v2 1/3] dt-bindings: mmc: convert synopsys dw-mshc bindings to yaml
@ 2020-01-16 15:22 Johan Jonker
2020-01-16 15:22 ` [PATCH v2 2/3] dt-bindings: mmc: convert rockchip " Johan Jonker
` (3 more replies)
0 siblings, 4 replies; 9+ messages in thread
From: Johan Jonker @ 2020-01-16 15:22 UTC (permalink / raw)
To: ulf.hansson
Cc: mark.rutland, devicetree, heiko, linux-mmc, linux-kernel,
linux-rockchip, robh+dt, linux-arm-kernel
Current dts files with 'dwmmc' nodes are manually verified.
In order to automate this process synopsys-dw-mshc.txt
has to be converted to yaml. In the new setup
synopsys-dw-mshc.yaml will inherit properties from
mmc-controller.yaml and synopsys-dw-mshc-common.yaml.
'dwmmc' will no longer be a valid name for a node and
should be changed to 'mmc'.
Signed-off-by: Johan Jonker <jbx6244@gmail.com>
---
.../bindings/mmc/synopsys-dw-mshc-common.yaml | 68 ++++++++++
.../devicetree/bindings/mmc/synopsys-dw-mshc.txt | 141 ---------------------
.../devicetree/bindings/mmc/synopsys-dw-mshc.yaml | 70 ++++++++++
3 files changed, 138 insertions(+), 141 deletions(-)
create mode 100644 Documentation/devicetree/bindings/mmc/synopsys-dw-mshc-common.yaml
delete mode 100644 Documentation/devicetree/bindings/mmc/synopsys-dw-mshc.txt
create mode 100644 Documentation/devicetree/bindings/mmc/synopsys-dw-mshc.yaml
diff --git a/Documentation/devicetree/bindings/mmc/synopsys-dw-mshc-common.yaml b/Documentation/devicetree/bindings/mmc/synopsys-dw-mshc-common.yaml
new file mode 100644
index 000000000..890d47a87
--- /dev/null
+++ b/Documentation/devicetree/bindings/mmc/synopsys-dw-mshc-common.yaml
@@ -0,0 +1,68 @@
+# SPDX-License-Identifier: GPL-2.0
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/mmc/synopsys-dw-mshc-common.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Synopsys Designware Mobile Storage Host Controller Common Properties
+
+allOf:
+ - $ref: "mmc-controller.yaml#"
+
+maintainers:
+ - Ulf Hansson <ulf.hansson@linaro.org>
+
+# Everything else is described in the common file
+properties:
+ resets:
+ maxItems: 1
+
+ reset-names:
+ const: reset
+
+ clock-frequency:
+ description:
+ Should be the frequency (in Hz) of the ciu clock. If this
+ is specified and the ciu clock is specified then we'll try to set the ciu
+ clock to this at probe time.
+
+ fifo-depth:
+ allOf:
+ - $ref: /schemas/types.yaml#/definitions/uint32
+ description:
+ The maximum size of the tx/rx fifo's. If this property is not
+ specified, the default value of the fifo size is determined from the
+ controller registers.
+
+ card-detect-delay:
+ allOf:
+ - $ref: /schemas/types.yaml#/definitions/uint32
+ - default: 0
+ description:
+ Delay in milli-seconds before detecting card after card
+ insert event. The default value is 0.
+
+ data-addr:
+ allOf:
+ - $ref: /schemas/types.yaml#/definitions/uint32
+ description:
+ Override fifo address with value provided by DT. The default FIFO reg
+ offset is assumed as 0x100 (version < 0x240A) and 0x200(version >= 0x240A)
+ by driver. If the controller does not follow this rule, please use
+ this property to set fifo address in device tree.
+
+ fifo-watermark-aligned:
+ allOf:
+ - $ref: /schemas/types.yaml#/definitions/flag
+ description:
+ Data done irq is expected if data length is less than
+ watermark in PIO mode. But fifo watermark is requested to be aligned
+ with data length in some SoC so that TX/RX irq can be generated with
+ data done irq. Add this watermark quirk to mark this requirement and
+ force fifo watermark setting accordingly.
+
+ dmas:
+ maxItems: 1
+
+ dma-names:
+ const: rx-tx
diff --git a/Documentation/devicetree/bindings/mmc/synopsys-dw-mshc.txt b/Documentation/devicetree/bindings/mmc/synopsys-dw-mshc.txt
deleted file mode 100644
index 7e5e427a2..000000000
--- a/Documentation/devicetree/bindings/mmc/synopsys-dw-mshc.txt
+++ /dev/null
@@ -1,141 +0,0 @@
-* Synopsys Designware Mobile Storage Host Controller
-
-The Synopsys designware mobile storage host controller is used to interface
-a SoC with storage medium such as eMMC or SD/MMC cards. This file documents
-differences between the core mmc properties described by mmc.txt and the
-properties used by the Synopsys Designware Mobile Storage Host Controller.
-
-Required Properties:
-
-* compatible: should be
- - snps,dw-mshc: for controllers compliant with synopsys dw-mshc.
-* #address-cells: should be 1.
-* #size-cells: should be 0.
-
-# Slots (DEPRECATED): The slot specific information are contained within
- child-nodes with each child-node representing a supported slot. There should
- be atleast one child node representing a card slot. The name of the child node
- representing the slot is recommended to be slot@n where n is the unique number
- of the slot connected to the controller. The following are optional properties
- which can be included in the slot child node.
-
- * reg: specifies the physical slot number. The valid values of this
- property is 0 to (num-slots -1), where num-slots is the value
- specified by the num-slots property.
-
- * bus-width: as documented in mmc core bindings.
-
- * wp-gpios: specifies the write protect gpio line. The format of the
- gpio specifier depends on the gpio controller. If a GPIO is not used
- for write-protect, this property is optional.
-
- * disable-wp: If the wp-gpios property isn't present then (by default)
- we'd assume that the write protect is hooked up directly to the
- controller's special purpose write protect line (accessible via
- the WRTPRT register). However, it's possible that we simply don't
- want write protect. In that case specify 'disable-wp'.
- NOTE: This property is not required for slots known to always
- connect to eMMC or SDIO cards.
-
-Optional properties:
-
-* resets: phandle + reset specifier pair, intended to represent hardware
- reset signal present internally in some host controller IC designs.
- See Documentation/devicetree/bindings/reset/reset.txt for details.
-
-* reset-names: request name for using "resets" property. Must be "reset".
- (It will be used together with "resets" property.)
-
-* clocks: from common clock binding: handle to biu and ciu clocks for the
- bus interface unit clock and the card interface unit clock.
-
-* clock-names: from common clock binding: Shall be "biu" and "ciu".
- If the biu clock is missing we'll simply skip enabling it. If the
- ciu clock is missing we'll just assume that the clock is running at
- clock-frequency. It is an error to omit both the ciu clock and the
- clock-frequency.
-
-* clock-frequency: should be the frequency (in Hz) of the ciu clock. If this
- is specified and the ciu clock is specified then we'll try to set the ciu
- clock to this at probe time.
-
-* fifo-depth: The maximum size of the tx/rx fifo's. If this property is not
- specified, the default value of the fifo size is determined from the
- controller registers.
-
-* card-detect-delay: Delay in milli-seconds before detecting card after card
- insert event. The default value is 0.
-
-* data-addr: Override fifo address with value provided by DT. The default FIFO reg
- offset is assumed as 0x100 (version < 0x240A) and 0x200(version >= 0x240A) by
- driver. If the controller does not follow this rule, please use this property
- to set fifo address in device tree.
-
-* fifo-watermark-aligned: Data done irq is expected if data length is less than
- watermark in PIO mode. But fifo watermark is requested to be aligned with data
- length in some SoC so that TX/RX irq can be generated with data done irq. Add this
- watermark quirk to mark this requirement and force fifo watermark setting
- accordingly.
-
-* vmmc-supply: The phandle to the regulator to use for vmmc. If this is
- specified we'll defer probe until we can find this regulator.
-
-* dmas: List of DMA specifiers with the controller specific format as described
- in the generic DMA client binding. Refer to dma.txt for details.
-
-* dma-names: request names for generic DMA client binding. Must be "rx-tx".
- Refer to dma.txt for details.
-
-Aliases:
-
-- All the MSHC controller nodes should be represented in the aliases node using
- the following format 'mshc{n}' where n is a unique number for the alias.
-
-Example:
-
-The MSHC controller node can be split into two portions, SoC specific and
-board specific portions as listed below.
-
- dwmmc0@12200000 {
- compatible = "snps,dw-mshc";
- clocks = <&clock 351>, <&clock 132>;
- clock-names = "biu", "ciu";
- reg = <0x12200000 0x1000>;
- interrupts = <0 75 0>;
- #address-cells = <1>;
- #size-cells = <0>;
- data-addr = <0x200>;
- fifo-watermark-aligned;
- resets = <&rst 20>;
- reset-names = "reset";
- };
-
-[board specific internal DMA resources]
-
- dwmmc0@12200000 {
- clock-frequency = <400000000>;
- clock-freq-min-max = <400000 200000000>;
- broken-cd;
- fifo-depth = <0x80>;
- card-detect-delay = <200>;
- vmmc-supply = <&buck8>;
- bus-width = <8>;
- cap-mmc-highspeed;
- cap-sd-highspeed;
- };
-
-[board specific generic DMA request binding]
-
- dwmmc0@12200000 {
- clock-frequency = <400000000>;
- clock-freq-min-max = <400000 200000000>;
- broken-cd;
- fifo-depth = <0x80>;
- card-detect-delay = <200>;
- vmmc-supply = <&buck8>;
- bus-width = <8>;
- cap-mmc-highspeed;
- cap-sd-highspeed;
- dmas = <&pdma 12>;
- dma-names = "rx-tx";
- };
diff --git a/Documentation/devicetree/bindings/mmc/synopsys-dw-mshc.yaml b/Documentation/devicetree/bindings/mmc/synopsys-dw-mshc.yaml
new file mode 100644
index 000000000..05f9f36dc
--- /dev/null
+++ b/Documentation/devicetree/bindings/mmc/synopsys-dw-mshc.yaml
@@ -0,0 +1,70 @@
+# SPDX-License-Identifier: GPL-2.0
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/mmc/synopsys-dw-mshc.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Synopsys Designware Mobile Storage Host Controller Binding
+
+allOf:
+ - $ref: "synopsys-dw-mshc-common.yaml#"
+
+maintainers:
+ - Ulf Hansson <ulf.hansson@linaro.org>
+
+# Everything else is described in the common file
+properties:
+ compatible:
+ const: snps,dw-mshc
+
+ reg:
+ maxItems: 1
+
+ interrupts:
+ maxItems: 1
+
+ clocks:
+ minItems: 2
+ maxItems: 2
+ description:
+ Handle to "biu" and "ciu" clocks for the
+ bus interface unit clock and the card interface unit clock.
+
+ clock-names:
+ items:
+ - const: biu
+ - const: ciu
+
+required:
+ - compatible
+ - reg
+ - interrupts
+ - clocks
+ - clock-names
+
+examples:
+ - |
+ mmc@12200000 {
+ compatible = "snps,dw-mshc";
+ reg = <0x12200000 0x1000>;
+ interrupts = <0 75 0>;
+ clocks = <&clock 351>, <&clock 132>;
+ clock-names = "biu", "ciu";
+ dmas = <&pdma 12>;
+ dma-names = "rx-tx";
+ resets = <&rst 20>;
+ reset-names = "reset";
+ vmmc-supply = <&buck8>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+ broken-cd;
+ bus-width = <8>;
+ cap-mmc-highspeed;
+ cap-sd-highspeed;
+ card-detect-delay = <200>;
+ clock-freq-min-max = <400000 200000000>;
+ clock-frequency = <400000000>;
+ data-addr = <0x200>;
+ fifo-depth = <0x80>;
+ fifo-watermark-aligned;
+ };
--
2.11.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 9+ messages in thread* [PATCH v2 2/3] dt-bindings: mmc: convert rockchip dw-mshc bindings to yaml 2020-01-16 15:22 [PATCH v2 1/3] dt-bindings: mmc: convert synopsys dw-mshc bindings to yaml Johan Jonker @ 2020-01-16 15:22 ` Johan Jonker 2020-01-22 16:05 ` Rob Herring 2020-01-24 11:25 ` Ulf Hansson 2020-01-16 15:22 ` [PATCH v2 3/3] dt-bindings: mmc: rockchip-dw-mshc: add description for rk3308 Johan Jonker ` (2 subsequent siblings) 3 siblings, 2 replies; 9+ messages in thread From: Johan Jonker @ 2020-01-16 15:22 UTC (permalink / raw) To: ulf.hansson Cc: mark.rutland, devicetree, heiko, linux-mmc, linux-kernel, linux-rockchip, robh+dt, linux-arm-kernel Current dts files with 'dwmmc' nodes are manually verified. In order to automate this process rockchip-dw-mshc.txt has to be converted to yaml. In the new setup rockchip-dw-mshc.yaml will inherit properties from mmc-controller.yaml and synopsys-dw-mshc-common.yaml. 'dwmmc' will no longer be a valid name for a node and should be changed to 'mmc'. Signed-off-by: Johan Jonker <jbx6244@gmail.com> --- .../devicetree/bindings/mmc/rockchip-dw-mshc.txt | 49 -------- .../devicetree/bindings/mmc/rockchip-dw-mshc.yaml | 123 +++++++++++++++++++++ MAINTAINERS | 1 + 3 files changed, 124 insertions(+), 49 deletions(-) delete mode 100644 Documentation/devicetree/bindings/mmc/rockchip-dw-mshc.txt create mode 100644 Documentation/devicetree/bindings/mmc/rockchip-dw-mshc.yaml diff --git a/Documentation/devicetree/bindings/mmc/rockchip-dw-mshc.txt b/Documentation/devicetree/bindings/mmc/rockchip-dw-mshc.txt deleted file mode 100644 index 6f629b12b..000000000 --- a/Documentation/devicetree/bindings/mmc/rockchip-dw-mshc.txt +++ /dev/null @@ -1,49 +0,0 @@ -* Rockchip specific extensions to the Synopsys Designware Mobile - Storage Host Controller - -The Synopsys designware mobile storage host controller is used to interface -a SoC with storage medium such as eMMC or SD/MMC cards. This file documents -differences between the core Synopsys dw mshc controller properties described -by synopsys-dw-mshc.txt and the properties used by the Rockchip specific -extensions to the Synopsys Designware Mobile Storage Host Controller. - -Required Properties: - -* compatible: should be - - "rockchip,rk2928-dw-mshc": for Rockchip RK2928 and following, - before RK3288 - - "rockchip,rk3288-dw-mshc": for Rockchip RK3288 - - "rockchip,rv1108-dw-mshc", "rockchip,rk3288-dw-mshc": for Rockchip RV1108 - - "rockchip,px30-dw-mshc", "rockchip,rk3288-dw-mshc": for Rockchip PX30 - - "rockchip,rk3036-dw-mshc", "rockchip,rk3288-dw-mshc": for Rockchip RK3036 - - "rockchip,rk3228-dw-mshc", "rockchip,rk3288-dw-mshc": for Rockchip RK322x - - "rockchip,rk3328-dw-mshc", "rockchip,rk3288-dw-mshc": for Rockchip RK3328 - - "rockchip,rk3368-dw-mshc", "rockchip,rk3288-dw-mshc": for Rockchip RK3368 - - "rockchip,rk3399-dw-mshc", "rockchip,rk3288-dw-mshc": for Rockchip RK3399 - -Optional Properties: -* clocks: from common clock binding: if ciu-drive and ciu-sample are - specified in clock-names, should contain handles to these clocks. - -* clock-names: Apart from the clock-names described in synopsys-dw-mshc.txt - two more clocks "ciu-drive" and "ciu-sample" are supported. They are used - to control the clock phases, "ciu-sample" is required for tuning high- - speed modes. - -* rockchip,default-sample-phase: The default phase to set ciu-sample at - probing, low speeds or in case where all phases work at tuning time. - If not specified 0 deg will be used. - -* rockchip,desired-num-phases: The desired number of times that the host - execute tuning when needed. If not specified, the host will do tuning - for 360 times, namely tuning for each degree. - -Example: - - rkdwmmc0@12200000 { - compatible = "rockchip,rk3288-dw-mshc"; - reg = <0x12200000 0x1000>; - interrupts = <0 75 0>; - #address-cells = <1>; - #size-cells = <0>; - }; diff --git a/Documentation/devicetree/bindings/mmc/rockchip-dw-mshc.yaml b/Documentation/devicetree/bindings/mmc/rockchip-dw-mshc.yaml new file mode 100644 index 000000000..2f70f5ef0 --- /dev/null +++ b/Documentation/devicetree/bindings/mmc/rockchip-dw-mshc.yaml @@ -0,0 +1,123 @@ +# SPDX-License-Identifier: GPL-2.0 +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/mmc/rockchip-dw-mshc.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Rockchip designware mobile storage host controller device tree bindings + +description: + Rockchip uses the Synopsys designware mobile storage host controller + to interface a SoC with storage medium such as eMMC or SD/MMC cards. + This file documents the combined properties for the core Synopsys dw mshc + controller that are not already included in the synopsys-dw-mshc-common.yaml + file and the Rockchip specific extensions. + +allOf: + - $ref: "synopsys-dw-mshc-common.yaml#" + +maintainers: + - Heiko Stuebner <heiko@sntech.de> + +# Everything else is described in the common file +properties: + compatible: + oneOf: + # for Rockchip RK2928 and before RK3288 + - const: rockchip,rk2928-dw-mshc + # for Rockchip RK3288 + - const: rockchip,rk3288-dw-mshc + - items: + - enum: + # for Rockchip PX30 + - rockchip,px30-dw-mshc + # for Rockchip RK3036 + - rockchip,rk3036-dw-mshc + # for Rockchip RK322x + - rockchip,rk3228-dw-mshc + # for Rockchip RK3328 + - rockchip,rk3328-dw-mshc + # for Rockchip RK3368 + - rockchip,rk3368-dw-mshc + # for Rockchip RK3399 + - rockchip,rk3399-dw-mshc + # for Rockchip RV1108 + - rockchip,rv1108-dw-mshc + - const: rockchip,rk3288-dw-mshc + + reg: + maxItems: 1 + + interrupts: + maxItems: 1 + + clocks: + minItems: 2 + maxItems: 4 + description: + Handle to "biu" and "ciu" clocks for the bus interface unit clock and + the card interface unit clock. If "ciu-drive" and "ciu-sample" are + specified in clock-names, it should also contain + handles to these clocks. + + clock-names: + minItems: 2 + items: + - const: biu + - const: ciu + - const: ciu-drive + - const: ciu-sample + description: + Apart from the clock-names "biu" and "ciu" two more clocks + "ciu-drive" and "ciu-sample" are supported. They are used + to control the clock phases, "ciu-sample" is required for tuning + high speed modes. + + rockchip,default-sample-phase: + allOf: + - $ref: /schemas/types.yaml#/definitions/uint32 + minimum: 0 + maximum: 360 + default: 0 + description: + The default phase to set "ciu-sample" at probing, + low speeds or in case where all phases work at tuning time. + If not specified 0 deg will be used. + + rockchip,desired-num-phases: + allOf: + - $ref: /schemas/types.yaml#/definitions/uint32 + minimum: 0 + maximum: 360 + default: 360 + description: + The desired number of times that the host execute tuning when needed. + If not specified, the host will do tuning for 360 times, + namely tuning for each degree. + +required: + - compatible + - reg + - interrupts + - clocks + - clock-names + +examples: + - | + #include <dt-bindings/clock/rk3288-cru.h> + #include <dt-bindings/interrupt-controller/arm-gic.h> + #include <dt-bindings/interrupt-controller/irq.h> + sdmmc: mmc@ff0c0000 { + compatible = "rockchip,rk3288-dw-mshc"; + reg = <0x0 0xff0c0000 0x0 0x4000>; + interrupts = <GIC_SPI 32 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&cru HCLK_SDMMC>, <&cru SCLK_SDMMC>, + <&cru SCLK_SDMMC_DRV>, <&cru SCLK_SDMMC_SAMPLE>; + clock-names = "biu", "ciu", "ciu-drive", "ciu-sample"; + resets = <&cru SRST_MMC0>; + reset-names = "reset"; + fifo-depth = <0x100>; + max-frequency = <150000000>; + }; + +... diff --git a/MAINTAINERS b/MAINTAINERS index d6ad01d71..1b16c0fdf 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -2240,6 +2240,7 @@ L: linux-rockchip@lists.infradead.org T: git git://git.kernel.org/pub/scm/linux/kernel/git/mmind/linux-rockchip.git S: Maintained F: Documentation/devicetree/bindings/i2c/i2c-rk3x.txt +F: Documentation/devicetree/bindings/mmc/rockchip-dw-mshc.yaml F: arch/arm/boot/dts/rk3* F: arch/arm/boot/dts/rv1108* F: arch/arm/mach-rockchip/ -- 2.11.0 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH v2 2/3] dt-bindings: mmc: convert rockchip dw-mshc bindings to yaml 2020-01-16 15:22 ` [PATCH v2 2/3] dt-bindings: mmc: convert rockchip " Johan Jonker @ 2020-01-22 16:05 ` Rob Herring 2020-01-24 11:25 ` Ulf Hansson 1 sibling, 0 replies; 9+ messages in thread From: Rob Herring @ 2020-01-22 16:05 UTC (permalink / raw) To: Johan Jonker Cc: mark.rutland, devicetree, ulf.hansson, heiko, linux-mmc, linux-kernel, linux-rockchip, robh+dt, linux-arm-kernel On Thu, 16 Jan 2020 16:22:29 +0100, Johan Jonker wrote: > Current dts files with 'dwmmc' nodes are manually verified. > In order to automate this process rockchip-dw-mshc.txt > has to be converted to yaml. In the new setup > rockchip-dw-mshc.yaml will inherit properties from > mmc-controller.yaml and synopsys-dw-mshc-common.yaml. > 'dwmmc' will no longer be a valid name for a node and > should be changed to 'mmc'. > > Signed-off-by: Johan Jonker <jbx6244@gmail.com> > --- > .../devicetree/bindings/mmc/rockchip-dw-mshc.txt | 49 -------- > .../devicetree/bindings/mmc/rockchip-dw-mshc.yaml | 123 +++++++++++++++++++++ > MAINTAINERS | 1 + > 3 files changed, 124 insertions(+), 49 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/mmc/rockchip-dw-mshc.txt > create mode 100644 Documentation/devicetree/bindings/mmc/rockchip-dw-mshc.yaml > Reviewed-by: Rob Herring <robh@kernel.org> _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v2 2/3] dt-bindings: mmc: convert rockchip dw-mshc bindings to yaml 2020-01-16 15:22 ` [PATCH v2 2/3] dt-bindings: mmc: convert rockchip " Johan Jonker 2020-01-22 16:05 ` Rob Herring @ 2020-01-24 11:25 ` Ulf Hansson 1 sibling, 0 replies; 9+ messages in thread From: Ulf Hansson @ 2020-01-24 11:25 UTC (permalink / raw) To: Johan Jonker Cc: Mark Rutland, DTML, Heiko Stuebner, linux-mmc@vger.kernel.org, Linux Kernel Mailing List, open list:ARM/Rockchip SoC..., Rob Herring, Linux ARM On Thu, 16 Jan 2020 at 16:22, Johan Jonker <jbx6244@gmail.com> wrote: > > Current dts files with 'dwmmc' nodes are manually verified. > In order to automate this process rockchip-dw-mshc.txt > has to be converted to yaml. In the new setup > rockchip-dw-mshc.yaml will inherit properties from > mmc-controller.yaml and synopsys-dw-mshc-common.yaml. > 'dwmmc' will no longer be a valid name for a node and > should be changed to 'mmc'. > > Signed-off-by: Johan Jonker <jbx6244@gmail.com> Applied for next, thanks! Kind regards Uffe > --- > .../devicetree/bindings/mmc/rockchip-dw-mshc.txt | 49 -------- > .../devicetree/bindings/mmc/rockchip-dw-mshc.yaml | 123 +++++++++++++++++++++ > MAINTAINERS | 1 + > 3 files changed, 124 insertions(+), 49 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/mmc/rockchip-dw-mshc.txt > create mode 100644 Documentation/devicetree/bindings/mmc/rockchip-dw-mshc.yaml > > diff --git a/Documentation/devicetree/bindings/mmc/rockchip-dw-mshc.txt b/Documentation/devicetree/bindings/mmc/rockchip-dw-mshc.txt > deleted file mode 100644 > index 6f629b12b..000000000 > --- a/Documentation/devicetree/bindings/mmc/rockchip-dw-mshc.txt > +++ /dev/null > @@ -1,49 +0,0 @@ > -* Rockchip specific extensions to the Synopsys Designware Mobile > - Storage Host Controller > - > -The Synopsys designware mobile storage host controller is used to interface > -a SoC with storage medium such as eMMC or SD/MMC cards. This file documents > -differences between the core Synopsys dw mshc controller properties described > -by synopsys-dw-mshc.txt and the properties used by the Rockchip specific > -extensions to the Synopsys Designware Mobile Storage Host Controller. > - > -Required Properties: > - > -* compatible: should be > - - "rockchip,rk2928-dw-mshc": for Rockchip RK2928 and following, > - before RK3288 > - - "rockchip,rk3288-dw-mshc": for Rockchip RK3288 > - - "rockchip,rv1108-dw-mshc", "rockchip,rk3288-dw-mshc": for Rockchip RV1108 > - - "rockchip,px30-dw-mshc", "rockchip,rk3288-dw-mshc": for Rockchip PX30 > - - "rockchip,rk3036-dw-mshc", "rockchip,rk3288-dw-mshc": for Rockchip RK3036 > - - "rockchip,rk3228-dw-mshc", "rockchip,rk3288-dw-mshc": for Rockchip RK322x > - - "rockchip,rk3328-dw-mshc", "rockchip,rk3288-dw-mshc": for Rockchip RK3328 > - - "rockchip,rk3368-dw-mshc", "rockchip,rk3288-dw-mshc": for Rockchip RK3368 > - - "rockchip,rk3399-dw-mshc", "rockchip,rk3288-dw-mshc": for Rockchip RK3399 > - > -Optional Properties: > -* clocks: from common clock binding: if ciu-drive and ciu-sample are > - specified in clock-names, should contain handles to these clocks. > - > -* clock-names: Apart from the clock-names described in synopsys-dw-mshc.txt > - two more clocks "ciu-drive" and "ciu-sample" are supported. They are used > - to control the clock phases, "ciu-sample" is required for tuning high- > - speed modes. > - > -* rockchip,default-sample-phase: The default phase to set ciu-sample at > - probing, low speeds or in case where all phases work at tuning time. > - If not specified 0 deg will be used. > - > -* rockchip,desired-num-phases: The desired number of times that the host > - execute tuning when needed. If not specified, the host will do tuning > - for 360 times, namely tuning for each degree. > - > -Example: > - > - rkdwmmc0@12200000 { > - compatible = "rockchip,rk3288-dw-mshc"; > - reg = <0x12200000 0x1000>; > - interrupts = <0 75 0>; > - #address-cells = <1>; > - #size-cells = <0>; > - }; > diff --git a/Documentation/devicetree/bindings/mmc/rockchip-dw-mshc.yaml b/Documentation/devicetree/bindings/mmc/rockchip-dw-mshc.yaml > new file mode 100644 > index 000000000..2f70f5ef0 > --- /dev/null > +++ b/Documentation/devicetree/bindings/mmc/rockchip-dw-mshc.yaml > @@ -0,0 +1,123 @@ > +# SPDX-License-Identifier: GPL-2.0 > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/mmc/rockchip-dw-mshc.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Rockchip designware mobile storage host controller device tree bindings > + > +description: > + Rockchip uses the Synopsys designware mobile storage host controller > + to interface a SoC with storage medium such as eMMC or SD/MMC cards. > + This file documents the combined properties for the core Synopsys dw mshc > + controller that are not already included in the synopsys-dw-mshc-common.yaml > + file and the Rockchip specific extensions. > + > +allOf: > + - $ref: "synopsys-dw-mshc-common.yaml#" > + > +maintainers: > + - Heiko Stuebner <heiko@sntech.de> > + > +# Everything else is described in the common file > +properties: > + compatible: > + oneOf: > + # for Rockchip RK2928 and before RK3288 > + - const: rockchip,rk2928-dw-mshc > + # for Rockchip RK3288 > + - const: rockchip,rk3288-dw-mshc > + - items: > + - enum: > + # for Rockchip PX30 > + - rockchip,px30-dw-mshc > + # for Rockchip RK3036 > + - rockchip,rk3036-dw-mshc > + # for Rockchip RK322x > + - rockchip,rk3228-dw-mshc > + # for Rockchip RK3328 > + - rockchip,rk3328-dw-mshc > + # for Rockchip RK3368 > + - rockchip,rk3368-dw-mshc > + # for Rockchip RK3399 > + - rockchip,rk3399-dw-mshc > + # for Rockchip RV1108 > + - rockchip,rv1108-dw-mshc > + - const: rockchip,rk3288-dw-mshc > + > + reg: > + maxItems: 1 > + > + interrupts: > + maxItems: 1 > + > + clocks: > + minItems: 2 > + maxItems: 4 > + description: > + Handle to "biu" and "ciu" clocks for the bus interface unit clock and > + the card interface unit clock. If "ciu-drive" and "ciu-sample" are > + specified in clock-names, it should also contain > + handles to these clocks. > + > + clock-names: > + minItems: 2 > + items: > + - const: biu > + - const: ciu > + - const: ciu-drive > + - const: ciu-sample > + description: > + Apart from the clock-names "biu" and "ciu" two more clocks > + "ciu-drive" and "ciu-sample" are supported. They are used > + to control the clock phases, "ciu-sample" is required for tuning > + high speed modes. > + > + rockchip,default-sample-phase: > + allOf: > + - $ref: /schemas/types.yaml#/definitions/uint32 > + minimum: 0 > + maximum: 360 > + default: 0 > + description: > + The default phase to set "ciu-sample" at probing, > + low speeds or in case where all phases work at tuning time. > + If not specified 0 deg will be used. > + > + rockchip,desired-num-phases: > + allOf: > + - $ref: /schemas/types.yaml#/definitions/uint32 > + minimum: 0 > + maximum: 360 > + default: 360 > + description: > + The desired number of times that the host execute tuning when needed. > + If not specified, the host will do tuning for 360 times, > + namely tuning for each degree. > + > +required: > + - compatible > + - reg > + - interrupts > + - clocks > + - clock-names > + > +examples: > + - | > + #include <dt-bindings/clock/rk3288-cru.h> > + #include <dt-bindings/interrupt-controller/arm-gic.h> > + #include <dt-bindings/interrupt-controller/irq.h> > + sdmmc: mmc@ff0c0000 { > + compatible = "rockchip,rk3288-dw-mshc"; > + reg = <0x0 0xff0c0000 0x0 0x4000>; > + interrupts = <GIC_SPI 32 IRQ_TYPE_LEVEL_HIGH>; > + clocks = <&cru HCLK_SDMMC>, <&cru SCLK_SDMMC>, > + <&cru SCLK_SDMMC_DRV>, <&cru SCLK_SDMMC_SAMPLE>; > + clock-names = "biu", "ciu", "ciu-drive", "ciu-sample"; > + resets = <&cru SRST_MMC0>; > + reset-names = "reset"; > + fifo-depth = <0x100>; > + max-frequency = <150000000>; > + }; > + > +... > diff --git a/MAINTAINERS b/MAINTAINERS > index d6ad01d71..1b16c0fdf 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -2240,6 +2240,7 @@ L: linux-rockchip@lists.infradead.org > T: git git://git.kernel.org/pub/scm/linux/kernel/git/mmind/linux-rockchip.git > S: Maintained > F: Documentation/devicetree/bindings/i2c/i2c-rk3x.txt > +F: Documentation/devicetree/bindings/mmc/rockchip-dw-mshc.yaml > F: arch/arm/boot/dts/rk3* > F: arch/arm/boot/dts/rv1108* > F: arch/arm/mach-rockchip/ > -- > 2.11.0 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH v2 3/3] dt-bindings: mmc: rockchip-dw-mshc: add description for rk3308 2020-01-16 15:22 [PATCH v2 1/3] dt-bindings: mmc: convert synopsys dw-mshc bindings to yaml Johan Jonker 2020-01-16 15:22 ` [PATCH v2 2/3] dt-bindings: mmc: convert rockchip " Johan Jonker @ 2020-01-16 15:22 ` Johan Jonker 2020-01-22 16:05 ` Rob Herring 2020-01-24 11:25 ` Ulf Hansson 2020-01-22 16:05 ` [PATCH v2 1/3] dt-bindings: mmc: convert synopsys dw-mshc bindings to yaml Rob Herring 2020-01-24 11:25 ` Ulf Hansson 3 siblings, 2 replies; 9+ messages in thread From: Johan Jonker @ 2020-01-16 15:22 UTC (permalink / raw) To: ulf.hansson Cc: mark.rutland, devicetree, heiko, linux-mmc, linux-kernel, linux-rockchip, robh+dt, linux-arm-kernel The description below is already in use for rk3308.dtsi, but was somehow never added to a document, so add "rockchip,rk3308-dw-mshc", "rockchip,rk3288-dw-mshc" for mmc nodes on a rk3308 platform to rockchip-dw-mshc.yaml. Signed-off-by: Johan Jonker <jbx6244@gmail.com> --- Documentation/devicetree/bindings/mmc/rockchip-dw-mshc.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/mmc/rockchip-dw-mshc.yaml b/Documentation/devicetree/bindings/mmc/rockchip-dw-mshc.yaml index 2f70f5ef0..89c3edd6a 100644 --- a/Documentation/devicetree/bindings/mmc/rockchip-dw-mshc.yaml +++ b/Documentation/devicetree/bindings/mmc/rockchip-dw-mshc.yaml @@ -35,6 +35,8 @@ properties: - rockchip,rk3036-dw-mshc # for Rockchip RK322x - rockchip,rk3228-dw-mshc + # for Rockchip RK3308 + - rockchip,rk3308-dw-mshc # for Rockchip RK3328 - rockchip,rk3328-dw-mshc # for Rockchip RK3368 -- 2.11.0 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH v2 3/3] dt-bindings: mmc: rockchip-dw-mshc: add description for rk3308 2020-01-16 15:22 ` [PATCH v2 3/3] dt-bindings: mmc: rockchip-dw-mshc: add description for rk3308 Johan Jonker @ 2020-01-22 16:05 ` Rob Herring 2020-01-24 11:25 ` Ulf Hansson 1 sibling, 0 replies; 9+ messages in thread From: Rob Herring @ 2020-01-22 16:05 UTC (permalink / raw) To: Johan Jonker Cc: mark.rutland, devicetree, ulf.hansson, heiko, linux-mmc, linux-kernel, linux-rockchip, robh+dt, linux-arm-kernel On Thu, 16 Jan 2020 16:22:30 +0100, Johan Jonker wrote: > The description below is already in use for rk3308.dtsi, > but was somehow never added to a document, so add > "rockchip,rk3308-dw-mshc", "rockchip,rk3288-dw-mshc" > for mmc nodes on a rk3308 platform to rockchip-dw-mshc.yaml. > > Signed-off-by: Johan Jonker <jbx6244@gmail.com> > --- > Documentation/devicetree/bindings/mmc/rockchip-dw-mshc.yaml | 2 ++ > 1 file changed, 2 insertions(+) > Acked-by: Rob Herring <robh@kernel.org> _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v2 3/3] dt-bindings: mmc: rockchip-dw-mshc: add description for rk3308 2020-01-16 15:22 ` [PATCH v2 3/3] dt-bindings: mmc: rockchip-dw-mshc: add description for rk3308 Johan Jonker 2020-01-22 16:05 ` Rob Herring @ 2020-01-24 11:25 ` Ulf Hansson 1 sibling, 0 replies; 9+ messages in thread From: Ulf Hansson @ 2020-01-24 11:25 UTC (permalink / raw) To: Johan Jonker Cc: Mark Rutland, DTML, Heiko Stuebner, linux-mmc@vger.kernel.org, Linux Kernel Mailing List, open list:ARM/Rockchip SoC..., Rob Herring, Linux ARM On Thu, 16 Jan 2020 at 16:22, Johan Jonker <jbx6244@gmail.com> wrote: > > The description below is already in use for rk3308.dtsi, > but was somehow never added to a document, so add > "rockchip,rk3308-dw-mshc", "rockchip,rk3288-dw-mshc" > for mmc nodes on a rk3308 platform to rockchip-dw-mshc.yaml. > > Signed-off-by: Johan Jonker <jbx6244@gmail.com> Applied for next, thanks! Kind regards Uffe > --- > Documentation/devicetree/bindings/mmc/rockchip-dw-mshc.yaml | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Documentation/devicetree/bindings/mmc/rockchip-dw-mshc.yaml b/Documentation/devicetree/bindings/mmc/rockchip-dw-mshc.yaml > index 2f70f5ef0..89c3edd6a 100644 > --- a/Documentation/devicetree/bindings/mmc/rockchip-dw-mshc.yaml > +++ b/Documentation/devicetree/bindings/mmc/rockchip-dw-mshc.yaml > @@ -35,6 +35,8 @@ properties: > - rockchip,rk3036-dw-mshc > # for Rockchip RK322x > - rockchip,rk3228-dw-mshc > + # for Rockchip RK3308 > + - rockchip,rk3308-dw-mshc > # for Rockchip RK3328 > - rockchip,rk3328-dw-mshc > # for Rockchip RK3368 > -- > 2.11.0 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v2 1/3] dt-bindings: mmc: convert synopsys dw-mshc bindings to yaml 2020-01-16 15:22 [PATCH v2 1/3] dt-bindings: mmc: convert synopsys dw-mshc bindings to yaml Johan Jonker 2020-01-16 15:22 ` [PATCH v2 2/3] dt-bindings: mmc: convert rockchip " Johan Jonker 2020-01-16 15:22 ` [PATCH v2 3/3] dt-bindings: mmc: rockchip-dw-mshc: add description for rk3308 Johan Jonker @ 2020-01-22 16:05 ` Rob Herring 2020-01-24 11:25 ` Ulf Hansson 3 siblings, 0 replies; 9+ messages in thread From: Rob Herring @ 2020-01-22 16:05 UTC (permalink / raw) To: Johan Jonker Cc: mark.rutland, devicetree, ulf.hansson, heiko, linux-mmc, linux-kernel, linux-rockchip, robh+dt, linux-arm-kernel On Thu, 16 Jan 2020 16:22:28 +0100, Johan Jonker wrote: > Current dts files with 'dwmmc' nodes are manually verified. > In order to automate this process synopsys-dw-mshc.txt > has to be converted to yaml. In the new setup > synopsys-dw-mshc.yaml will inherit properties from > mmc-controller.yaml and synopsys-dw-mshc-common.yaml. > 'dwmmc' will no longer be a valid name for a node and > should be changed to 'mmc'. > > Signed-off-by: Johan Jonker <jbx6244@gmail.com> > --- > .../bindings/mmc/synopsys-dw-mshc-common.yaml | 68 ++++++++++ > .../devicetree/bindings/mmc/synopsys-dw-mshc.txt | 141 --------------------- > .../devicetree/bindings/mmc/synopsys-dw-mshc.yaml | 70 ++++++++++ > 3 files changed, 138 insertions(+), 141 deletions(-) > create mode 100644 Documentation/devicetree/bindings/mmc/synopsys-dw-mshc-common.yaml > delete mode 100644 Documentation/devicetree/bindings/mmc/synopsys-dw-mshc.txt > create mode 100644 Documentation/devicetree/bindings/mmc/synopsys-dw-mshc.yaml > Reviewed-by: Rob Herring <robh@kernel.org> _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v2 1/3] dt-bindings: mmc: convert synopsys dw-mshc bindings to yaml 2020-01-16 15:22 [PATCH v2 1/3] dt-bindings: mmc: convert synopsys dw-mshc bindings to yaml Johan Jonker ` (2 preceding siblings ...) 2020-01-22 16:05 ` [PATCH v2 1/3] dt-bindings: mmc: convert synopsys dw-mshc bindings to yaml Rob Herring @ 2020-01-24 11:25 ` Ulf Hansson 3 siblings, 0 replies; 9+ messages in thread From: Ulf Hansson @ 2020-01-24 11:25 UTC (permalink / raw) To: Johan Jonker Cc: Mark Rutland, DTML, Heiko Stuebner, linux-mmc@vger.kernel.org, Linux Kernel Mailing List, open list:ARM/Rockchip SoC..., Rob Herring, Linux ARM On Thu, 16 Jan 2020 at 16:22, Johan Jonker <jbx6244@gmail.com> wrote: > > Current dts files with 'dwmmc' nodes are manually verified. > In order to automate this process synopsys-dw-mshc.txt > has to be converted to yaml. In the new setup > synopsys-dw-mshc.yaml will inherit properties from > mmc-controller.yaml and synopsys-dw-mshc-common.yaml. > 'dwmmc' will no longer be a valid name for a node and > should be changed to 'mmc'. > > Signed-off-by: Johan Jonker <jbx6244@gmail.com> Applied for next, thanks! Kind regards Uffe > --- > .../bindings/mmc/synopsys-dw-mshc-common.yaml | 68 ++++++++++ > .../devicetree/bindings/mmc/synopsys-dw-mshc.txt | 141 --------------------- > .../devicetree/bindings/mmc/synopsys-dw-mshc.yaml | 70 ++++++++++ > 3 files changed, 138 insertions(+), 141 deletions(-) > create mode 100644 Documentation/devicetree/bindings/mmc/synopsys-dw-mshc-common.yaml > delete mode 100644 Documentation/devicetree/bindings/mmc/synopsys-dw-mshc.txt > create mode 100644 Documentation/devicetree/bindings/mmc/synopsys-dw-mshc.yaml > > diff --git a/Documentation/devicetree/bindings/mmc/synopsys-dw-mshc-common.yaml b/Documentation/devicetree/bindings/mmc/synopsys-dw-mshc-common.yaml > new file mode 100644 > index 000000000..890d47a87 > --- /dev/null > +++ b/Documentation/devicetree/bindings/mmc/synopsys-dw-mshc-common.yaml > @@ -0,0 +1,68 @@ > +# SPDX-License-Identifier: GPL-2.0 > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/mmc/synopsys-dw-mshc-common.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Synopsys Designware Mobile Storage Host Controller Common Properties > + > +allOf: > + - $ref: "mmc-controller.yaml#" > + > +maintainers: > + - Ulf Hansson <ulf.hansson@linaro.org> > + > +# Everything else is described in the common file > +properties: > + resets: > + maxItems: 1 > + > + reset-names: > + const: reset > + > + clock-frequency: > + description: > + Should be the frequency (in Hz) of the ciu clock. If this > + is specified and the ciu clock is specified then we'll try to set the ciu > + clock to this at probe time. > + > + fifo-depth: > + allOf: > + - $ref: /schemas/types.yaml#/definitions/uint32 > + description: > + The maximum size of the tx/rx fifo's. If this property is not > + specified, the default value of the fifo size is determined from the > + controller registers. > + > + card-detect-delay: > + allOf: > + - $ref: /schemas/types.yaml#/definitions/uint32 > + - default: 0 > + description: > + Delay in milli-seconds before detecting card after card > + insert event. The default value is 0. > + > + data-addr: > + allOf: > + - $ref: /schemas/types.yaml#/definitions/uint32 > + description: > + Override fifo address with value provided by DT. The default FIFO reg > + offset is assumed as 0x100 (version < 0x240A) and 0x200(version >= 0x240A) > + by driver. If the controller does not follow this rule, please use > + this property to set fifo address in device tree. > + > + fifo-watermark-aligned: > + allOf: > + - $ref: /schemas/types.yaml#/definitions/flag > + description: > + Data done irq is expected if data length is less than > + watermark in PIO mode. But fifo watermark is requested to be aligned > + with data length in some SoC so that TX/RX irq can be generated with > + data done irq. Add this watermark quirk to mark this requirement and > + force fifo watermark setting accordingly. > + > + dmas: > + maxItems: 1 > + > + dma-names: > + const: rx-tx > diff --git a/Documentation/devicetree/bindings/mmc/synopsys-dw-mshc.txt b/Documentation/devicetree/bindings/mmc/synopsys-dw-mshc.txt > deleted file mode 100644 > index 7e5e427a2..000000000 > --- a/Documentation/devicetree/bindings/mmc/synopsys-dw-mshc.txt > +++ /dev/null > @@ -1,141 +0,0 @@ > -* Synopsys Designware Mobile Storage Host Controller > - > -The Synopsys designware mobile storage host controller is used to interface > -a SoC with storage medium such as eMMC or SD/MMC cards. This file documents > -differences between the core mmc properties described by mmc.txt and the > -properties used by the Synopsys Designware Mobile Storage Host Controller. > - > -Required Properties: > - > -* compatible: should be > - - snps,dw-mshc: for controllers compliant with synopsys dw-mshc. > -* #address-cells: should be 1. > -* #size-cells: should be 0. > - > -# Slots (DEPRECATED): The slot specific information are contained within > - child-nodes with each child-node representing a supported slot. There should > - be atleast one child node representing a card slot. The name of the child node > - representing the slot is recommended to be slot@n where n is the unique number > - of the slot connected to the controller. The following are optional properties > - which can be included in the slot child node. > - > - * reg: specifies the physical slot number. The valid values of this > - property is 0 to (num-slots -1), where num-slots is the value > - specified by the num-slots property. > - > - * bus-width: as documented in mmc core bindings. > - > - * wp-gpios: specifies the write protect gpio line. The format of the > - gpio specifier depends on the gpio controller. If a GPIO is not used > - for write-protect, this property is optional. > - > - * disable-wp: If the wp-gpios property isn't present then (by default) > - we'd assume that the write protect is hooked up directly to the > - controller's special purpose write protect line (accessible via > - the WRTPRT register). However, it's possible that we simply don't > - want write protect. In that case specify 'disable-wp'. > - NOTE: This property is not required for slots known to always > - connect to eMMC or SDIO cards. > - > -Optional properties: > - > -* resets: phandle + reset specifier pair, intended to represent hardware > - reset signal present internally in some host controller IC designs. > - See Documentation/devicetree/bindings/reset/reset.txt for details. > - > -* reset-names: request name for using "resets" property. Must be "reset". > - (It will be used together with "resets" property.) > - > -* clocks: from common clock binding: handle to biu and ciu clocks for the > - bus interface unit clock and the card interface unit clock. > - > -* clock-names: from common clock binding: Shall be "biu" and "ciu". > - If the biu clock is missing we'll simply skip enabling it. If the > - ciu clock is missing we'll just assume that the clock is running at > - clock-frequency. It is an error to omit both the ciu clock and the > - clock-frequency. > - > -* clock-frequency: should be the frequency (in Hz) of the ciu clock. If this > - is specified and the ciu clock is specified then we'll try to set the ciu > - clock to this at probe time. > - > -* fifo-depth: The maximum size of the tx/rx fifo's. If this property is not > - specified, the default value of the fifo size is determined from the > - controller registers. > - > -* card-detect-delay: Delay in milli-seconds before detecting card after card > - insert event. The default value is 0. > - > -* data-addr: Override fifo address with value provided by DT. The default FIFO reg > - offset is assumed as 0x100 (version < 0x240A) and 0x200(version >= 0x240A) by > - driver. If the controller does not follow this rule, please use this property > - to set fifo address in device tree. > - > -* fifo-watermark-aligned: Data done irq is expected if data length is less than > - watermark in PIO mode. But fifo watermark is requested to be aligned with data > - length in some SoC so that TX/RX irq can be generated with data done irq. Add this > - watermark quirk to mark this requirement and force fifo watermark setting > - accordingly. > - > -* vmmc-supply: The phandle to the regulator to use for vmmc. If this is > - specified we'll defer probe until we can find this regulator. > - > -* dmas: List of DMA specifiers with the controller specific format as described > - in the generic DMA client binding. Refer to dma.txt for details. > - > -* dma-names: request names for generic DMA client binding. Must be "rx-tx". > - Refer to dma.txt for details. > - > -Aliases: > - > -- All the MSHC controller nodes should be represented in the aliases node using > - the following format 'mshc{n}' where n is a unique number for the alias. > - > -Example: > - > -The MSHC controller node can be split into two portions, SoC specific and > -board specific portions as listed below. > - > - dwmmc0@12200000 { > - compatible = "snps,dw-mshc"; > - clocks = <&clock 351>, <&clock 132>; > - clock-names = "biu", "ciu"; > - reg = <0x12200000 0x1000>; > - interrupts = <0 75 0>; > - #address-cells = <1>; > - #size-cells = <0>; > - data-addr = <0x200>; > - fifo-watermark-aligned; > - resets = <&rst 20>; > - reset-names = "reset"; > - }; > - > -[board specific internal DMA resources] > - > - dwmmc0@12200000 { > - clock-frequency = <400000000>; > - clock-freq-min-max = <400000 200000000>; > - broken-cd; > - fifo-depth = <0x80>; > - card-detect-delay = <200>; > - vmmc-supply = <&buck8>; > - bus-width = <8>; > - cap-mmc-highspeed; > - cap-sd-highspeed; > - }; > - > -[board specific generic DMA request binding] > - > - dwmmc0@12200000 { > - clock-frequency = <400000000>; > - clock-freq-min-max = <400000 200000000>; > - broken-cd; > - fifo-depth = <0x80>; > - card-detect-delay = <200>; > - vmmc-supply = <&buck8>; > - bus-width = <8>; > - cap-mmc-highspeed; > - cap-sd-highspeed; > - dmas = <&pdma 12>; > - dma-names = "rx-tx"; > - }; > diff --git a/Documentation/devicetree/bindings/mmc/synopsys-dw-mshc.yaml b/Documentation/devicetree/bindings/mmc/synopsys-dw-mshc.yaml > new file mode 100644 > index 000000000..05f9f36dc > --- /dev/null > +++ b/Documentation/devicetree/bindings/mmc/synopsys-dw-mshc.yaml > @@ -0,0 +1,70 @@ > +# SPDX-License-Identifier: GPL-2.0 > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/mmc/synopsys-dw-mshc.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Synopsys Designware Mobile Storage Host Controller Binding > + > +allOf: > + - $ref: "synopsys-dw-mshc-common.yaml#" > + > +maintainers: > + - Ulf Hansson <ulf.hansson@linaro.org> > + > +# Everything else is described in the common file > +properties: > + compatible: > + const: snps,dw-mshc > + > + reg: > + maxItems: 1 > + > + interrupts: > + maxItems: 1 > + > + clocks: > + minItems: 2 > + maxItems: 2 > + description: > + Handle to "biu" and "ciu" clocks for the > + bus interface unit clock and the card interface unit clock. > + > + clock-names: > + items: > + - const: biu > + - const: ciu > + > +required: > + - compatible > + - reg > + - interrupts > + - clocks > + - clock-names > + > +examples: > + - | > + mmc@12200000 { > + compatible = "snps,dw-mshc"; > + reg = <0x12200000 0x1000>; > + interrupts = <0 75 0>; > + clocks = <&clock 351>, <&clock 132>; > + clock-names = "biu", "ciu"; > + dmas = <&pdma 12>; > + dma-names = "rx-tx"; > + resets = <&rst 20>; > + reset-names = "reset"; > + vmmc-supply = <&buck8>; > + #address-cells = <1>; > + #size-cells = <0>; > + broken-cd; > + bus-width = <8>; > + cap-mmc-highspeed; > + cap-sd-highspeed; > + card-detect-delay = <200>; > + clock-freq-min-max = <400000 200000000>; > + clock-frequency = <400000000>; > + data-addr = <0x200>; > + fifo-depth = <0x80>; > + fifo-watermark-aligned; > + }; > -- > 2.11.0 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2020-01-24 11:26 UTC | newest] Thread overview: 9+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2020-01-16 15:22 [PATCH v2 1/3] dt-bindings: mmc: convert synopsys dw-mshc bindings to yaml Johan Jonker 2020-01-16 15:22 ` [PATCH v2 2/3] dt-bindings: mmc: convert rockchip " Johan Jonker 2020-01-22 16:05 ` Rob Herring 2020-01-24 11:25 ` Ulf Hansson 2020-01-16 15:22 ` [PATCH v2 3/3] dt-bindings: mmc: rockchip-dw-mshc: add description for rk3308 Johan Jonker 2020-01-22 16:05 ` Rob Herring 2020-01-24 11:25 ` Ulf Hansson 2020-01-22 16:05 ` [PATCH v2 1/3] dt-bindings: mmc: convert synopsys dw-mshc bindings to yaml Rob Herring 2020-01-24 11:25 ` Ulf Hansson
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).