From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6903CC2D0DB for ; Thu, 23 Jan 2020 15:08:27 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 37C7A2087E for ; Thu, 23 Jan 2020 15:08:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="LziRpY1E" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 37C7A2087E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=KTu8EhN9D0SLhUPfFFznedmLPIetX3bNYohRfvFvk5g=; b=LziRpY1EqQ+S2l y7un5ShVkucsl5V+ClhVUCYFikVpsmzBOA7fm4mVxo2p4ZCCxLDB4JQYzPBzFMU0964HpHuiQZ+dp 5wOEM+aDlF6/lCWa2IlOU5DKz+WXxmNPoAIXryu4lMc4S5GMSRWQhxvBjuFIlSGoefqSJwmFM4ApL Dc9zQqEpjDpq7VWO8VJjrqaaegnh6q/0wV2QrRJ28tSIg73TCPS6AM8AizcvWUDFkgxGS08OY4w4W K1KkJIhuQs8lQM6aGpjnbrgwWwa6LL982Dgyna+R2wwl8/GfoUMsd7Edc49Va0/r3OA2LJ/YUlpIe kHL/HDK6v9yZwYiI2W8g==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iue5q-0008Q4-KI; Thu, 23 Jan 2020 15:08:26 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iue5n-0008PI-OG for linux-arm-kernel@lists.infradead.org; Thu, 23 Jan 2020 15:08:25 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 40DD51FB; Thu, 23 Jan 2020 07:08:23 -0800 (PST) Received: from bogus (e103737-lin.cambridge.arm.com [10.1.197.49]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 734A13F68E; Thu, 23 Jan 2020 07:08:22 -0800 (PST) Date: Thu, 23 Jan 2020 15:08:20 +0000 From: Sudeep Holla To: Marc Zyngier Subject: Re: [PATCH] arm64: dts: fast models: Fix FVP PCI interrupt-map property Message-ID: <20200123150820.GB37953@bogus> References: <20200123145112.22170-1-maz@kernel.org> <20200123150104.GA37953@bogus> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200123_070823_836154_76F618EB X-CRM114-Status: GOOD ( 13.95 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Lorenzo Pieralisi , Liviu Dudau , linux-arm-kernel@lists.infradead.org, Rob Herring Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Jan 23, 2020 at 03:04:55PM +0000, Marc Zyngier wrote: > On 2020-01-23 15:01, Sudeep Holla wrote: > > On Thu, Jan 23, 2020 at 02:51:12PM +0000, Marc Zyngier wrote: > > > The interrupt map for the FVP's PCI node is missing the > > > parent-unit-address cells for each of the INTx entries, leading to the > > > kernel code failing to parse the entries correctly. > > > > > > Add the missing zero cells, which are pretty useless as far as the GIC > > > is concerned, but that the spec requires. This allows INTx to be > > > usable > > > on the model, and VFIO to work correctly. > > > > > > > I assume we need, > > > > Fixes: fa083b99eb28 ("arm64: dts: fast models: Add DTS fo Base RevC > > FVP") > > > > Please shout if that's not necessary. > > Yes, you're absolutely right (I'm not shouting! ;-). > Thanks for the patch and not shouting :), I will send it for v5.6, it will get backported anyways with fixes tag. -- Regards, Sudeep _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel