From: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
To: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
Cc: Florian Fainelli <f.fainelli@gmail.com>,
kbuild-all@lists.01.org, kbuild test robot <lkp@intel.com>,
linux-pci@vger.kernel.org, Jeremy Linton <jeremy.linton@arm.com>,
Bjorn Helgaas <helgaas@kernel.org>,
Jim Quinlan <james.quinlan@broadcom.com>,
bcm-kernel-feedback-list@broadcom.com,
Andrew Murray <andrew.murray@arm.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] PCI: brcmstb: fix resource_size.cocci warnings
Date: Mon, 27 Jan 2020 10:33:08 +0000 [thread overview]
Message-ID: <20200127103300.GA25542@e121166-lin.cambridge.arm.com> (raw)
In-Reply-To: <C06GWEBMF4LE.2DU8RMRR4F9Q8@linux-9qgx>
On Mon, Jan 27, 2020 at 10:31:22AM +0100, Nicolas Saenz Julienne wrote:
> On Mon Jan 27, 2020 at 4:09 AM, kbuild test robot wrote:
> > From: kbuild test robot <lkp@intel.com>
> >
> > drivers/pci/controller/pcie-brcmstb.c:552:13-16: ERROR: Missing
> > resource_size with res
> >
> >
> > Use resource_size function on resource object
> > instead of explicit computation.
> >
> > Generated by: scripts/coccinelle/api/resource_size.cocci
> >
> > Fixes: 8ad90d975e00 ("PCI: brcmstb: Add Broadcom STB PCIe host
> > controller driver")
> > CC: Jim Quinlan <james.quinlan@broadcom.com>
> > Signed-off-by: kbuild test robot <lkp@intel.com>
> > ---
>
> Reviewed-by: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
Applied on top on pci/brcmstb, thanks.
Lorenzo
> Regards,
> Nicolas
>
> >
> > tree:
> > https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
> > master
> > head: 702ccea170f07783bd002055a353a0866c062267
> > commit: 8ad90d975e00c297a198f6ecbd65e414fbb06dc9 [8319/11283] PCI:
> > brcmstb: Add Broadcom STB PCIe host controller driver
> >
> > pcie-brcmstb.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > --- a/drivers/pci/controller/pcie-brcmstb.c
> > +++ b/drivers/pci/controller/pcie-brcmstb.c
> > @@ -549,7 +549,7 @@ static int brcm_pcie_setup(struct brcm_p
> >
> > brcm_pcie_set_outbound_win(pcie, num_out_wins, res->start,
> > res->start - entry->offset,
> > - res->end - res->start + 1);
> > + resource_size(res));
> > num_out_wins++;
> > }
> >
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2020-01-27 10:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <202001270436.kA25JaWy%lkp@intel.com>
2020-01-26 20:09 ` [PATCH] PCI: brcmstb: fix resource_size.cocci warnings kbuild test robot
2020-01-27 9:31 ` Nicolas Saenz Julienne
2020-01-27 10:33 ` Lorenzo Pieralisi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200127103300.GA25542@e121166-lin.cambridge.arm.com \
--to=lorenzo.pieralisi@arm.com \
--cc=andrew.murray@arm.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=f.fainelli@gmail.com \
--cc=helgaas@kernel.org \
--cc=james.quinlan@broadcom.com \
--cc=jeremy.linton@arm.com \
--cc=kbuild-all@lists.01.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-pci@vger.kernel.org \
--cc=lkp@intel.com \
--cc=nsaenzjulienne@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox