From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,URIBL_DBL_ABUSE_MALW autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B3C12C2D0DB for ; Mon, 27 Jan 2020 12:32:01 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6910920702 for ; Mon, 27 Jan 2020 12:32:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="aogHdbFu"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="gpjLwG+c" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6910920702 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=06mv8IU/8dJ/5EJtrXSICE2Uaz+BqEwHWyvVVMXgH5Q=; b=aogHdbFuZUJ4wK VyAyvf6aQinMBrdnuq3JshrdgncoJTmU1WP2NaaMtF9iZgCJI4lwvh0UMQ2gz11mPUi8tZ/NvXOKK lK6rZJDDh2UQ0EpS5x2U7n8/ZgwTwGPssRh4tQUjeiRzkZ9O5g1Zzs/O5iKhTfXgHENquWg4mB5xT qxbbLFLreBIref9+LVn8GFG8bGErytdkOXKopC3bOL6m7M1AsqKqRVU+smoKY+fqVlyJbYvodliJC tvtjlyKfiWfvGGiVbdN5kjU7zDuqCqnBzT0c9FBuB2QLt9roK9m2AXLLVLVLmj9D4KtnGje5Ql0nI EUDRqeFQuiuyblhN7APQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iw3Ye-0006Ls-SO; Mon, 27 Jan 2020 12:32:00 +0000 Received: from us-smtp-1.mimecast.com ([207.211.31.81] helo=us-smtp-delivery-1.mimecast.com) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iw3YQ-000698-IK for linux-arm-kernel@lists.infradead.org; Mon, 27 Jan 2020 12:31:48 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1580128305; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=RKjG1/5cA7SZH1QMU5AvJ91rZVjHPgjPOojbBcC6/cs=; b=gpjLwG+chdkYTmdvdRbceOsRrYlw/+VOYMRKP0eBERjPdMoJ+DxpBHNVozcrOBInaECcGM rBQ6SvLvOpLnGWSUypG7v4NudueYCLSOB3MYSrZhYZglPX80htglM8GMiUstbA4+CTQ4W/ gaPoOnUDpqLSl9+aCKlhAE+/Dyu3M9M= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-259-7tc7XUzxOJe_owBE1WQQ9Q-1; Mon, 27 Jan 2020 07:31:39 -0500 X-MC-Unique: 7tc7XUzxOJe_owBE1WQQ9Q-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id A6CEE8017CC; Mon, 27 Jan 2020 12:31:35 +0000 (UTC) Received: from krava (unknown [10.43.17.48]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 2EADC451F; Mon, 27 Jan 2020 12:31:32 +0000 (UTC) Date: Mon, 27 Jan 2020 13:31:29 +0100 From: Jiri Olsa To: James Clark Subject: Re: [PATCH v2 2/7] perf tools: Add support for "report" for some spe events Message-ID: <20200127123129.GE1114818@krava> References: <20200123160734.3775-1-james.clark@arm.com> <20200123160734.3775-3-james.clark@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200123160734.3775-3-james.clark@arm.com> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200127_043146_684302_5960CC6A X-CRM114-Status: GOOD ( 14.95 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Al Grant , wxf.wang@hisilicon.com, Peter Zijlstra , Will Deacon , suzuki.poulose@arm.com, linux-kernel@vger.kernel.org, Arnaldo Carvalho de Melo , gengdongjiu@huawei.com, linux-perf-users@vger.kernel.org, Alexander Shishkin , Ingo Molnar , liuqi115@hisilicon.com, Tan Xiaojun , huawei.libin@huawei.com, Namhyung Kim , nd@arm.com, liwei391@huawei.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Jan 23, 2020 at 04:07:29PM +0000, James Clark wrote: SNIP > diff --git a/tools/perf/util/auxtrace.h b/tools/perf/util/auxtrace.h > index 749d72cd9c7b..b47108599280 100644 > --- a/tools/perf/util/auxtrace.h > +++ b/tools/perf/util/auxtrace.h > @@ -111,6 +111,22 @@ struct itrace_synth_opts { > int range_num; > }; > > +/** > + * struct arm_spe_synth_opts - ARM SPE tracing synthesis options. > + * @set: indicates whether or not options have been set > + * @llc_miss: whether to synthesize last level cache miss events > + * @tlb_miss: whether to synthesize TLB miss events > + * @branch_miss: whether to synthesize Branch miss events > + * @remote_access: whether to synthesize Remote access events > + */ > +struct arm_spe_synth_opts { > + bool set; > + bool llc_miss; > + bool tlb_miss; > + bool branch_miss; > + bool remote_access; hum, why don't you add that to itrace_synth_opts instead? seems generic enough I don't follow the code much, but I assume itrace_synth_opts is generic object, as it's already used by some of the s390 and x86 code.. also I don't like new pointer to synth_ops in perf_session jirka > diff --git a/tools/perf/util/session.h b/tools/perf/util/session.h > index f76480166d38..cee134d7643f 100644 > --- a/tools/perf/util/session.h > +++ b/tools/perf/util/session.h > @@ -19,6 +19,7 @@ struct thread; > > struct auxtrace; > struct itrace_synth_opts; > +struct arm_spe_synth_opts; > > struct perf_session { > struct perf_header header; > @@ -26,6 +27,7 @@ struct perf_session { > struct evlist *evlist; > struct auxtrace *auxtrace; > struct itrace_synth_opts *itrace_synth_opts; > + struct arm_spe_synth_opts *arm_spe_synth_opts; > struct list_head auxtrace_index; > struct trace_event tevent; > struct perf_record_time_conv time_conv; > -- > 2.25.0 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel